opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-24 15:04:27 +08:00
Code Issues Packages Projects Releases Wiki Activity
11,310 Commits 479 Branches 388 Tags
aa689cbb394ea4378b577a3fc29d30faac33a014
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Jon Ayers ebfc98df58 chore: move guards to satisfy CodeQL (#19600) 2025-08-28 12:33:51 -04:00
Jon Ayers be40b8ca3e chore: set more explicit guards for serving bin files (#19597) 2025-08-27 19:12:05 -07:00
Jon Ayers 0f1fc88d5a chore: pin devcontainer-cli for .devcontainer config (#19594) 2025-08-27 19:26:47 -04:00
Jon Ayers 252f7d461e chore: pin dependencies in Dockerfiles (#19587) 
Fixes up some security issues related to lack of pinned dependencies
 2025-08-27 18:41:28 -04:00
Jon Ayers e99c33e0d1 chore: restrict who can make releases (#19326) 
This PR confines who can run the `Release` action to members with
`maintain` or above
 2025-08-12 23:43:28 -04:00
Jon Ayers 064436a300 chore: fix formdata for apidocgen (#19319) 2025-08-12 12:30:09 -04:00
Jon Ayers 8a8c13382e feat: update form-data dependency to 4.0.4 (#19128) 2025-08-04 12:42:50 -04:00
Jon Ayers 2a2851e494 chore: check integrity of Go in Dockefile (#19130) 2025-08-04 08:27:27 -04:00
Jon Ayers 40dbc557bd fix: ignore goroutine leak for protocol lookup on windows (#19131) 2025-08-04 08:26:56 -04:00
Jon Ayers c9ed0dd927 chore: pin dependencies in Dockerfiles (#19129) 2025-08-03 18:26:41 -04:00
Jon Ayers 40a6367d4b chore: update CLAUDE.md to discourage time.Sleep (#18967) 2025-07-21 12:55:16 -04:00
Jon Ayers 7a3a6d4d26 chore: update README logos (#18619) 2025-06-26 19:27:17 +00:00
Jon Ayers 8b27983d14 fix: fix TestAcquireJobWithCancel_Cancel flake (#18441) 2025-06-18 22:51:13 -04:00
Jon Ayers b0fa3275d2 fix: increase TestAcquireJob_LongPoll timeout to prevent flakiness (#18442) 
I'll be honest I'm not even really sure the point of this test but it
was failing due to

```
2025-06-16T15:01:54.0863251Z         	Error:      	Received unexpected error:
2025-06-16T15:01:54.0863554Z         	            	acquire job:
2025-06-16T15:01:54.0864230Z         	            	    github.com/coder/coder/v2/coderd/provisionerdserver.(*server).AcquireJob
2025-06-16T15:01:54.0865173Z         	            	        /home/runner/work/coder/coder/coderd/provisionerdserver/provisionerdserver.go:329
2025-06-16T15:01:54.0865683Z         	            	  - failed to acquire job:
2025-06-16T15:01:54.0866374Z         	            	    github.com/coder/coder/v2/coderd/provisionerdserver.(*Acquirer).AcquireJob
2025-06-16T15:01:54.0867262Z         	            	        /home/runner/work/coder/coder/coderd/provisionerdserver/acquirer.go:148
2025-06-16T15:01:54.0867819Z         	            	  - pq: canceling statement due to user request
```

which is certainly unintended.
 2025-06-19 02:50:53 +00:00
Jon Ayers a9f1a6b2a2 fix: revert fix: persist terraform modules during template import (#17665) (#17734) 
This reverts commit ae3d90b057.
 2025-05-08 22:03:08 -04:00
Jon Ayers c06ef7c1eb chore!: remove JFrog integration (#17353) 
- Removes displaying XRay scan results in the dashboard. I'm not sure
  anyone was even using this integration so it's just debt for us to
  maintain. We can open up a separate issue to get rid of the db tables
  once we know for sure that we haven't broken anyone.
 2025-04-11 14:45:21 -04:00
Jon AyersandClaude 8faaa14820 chore: update Terraform to 1.11.4 (#17323) 
Co-authored-by: Claude <noreply@anthropic.com>
 2025-04-09 22:50:15 -04:00
Jon Ayers 900eb251eb chore: update Terraform to 1.11.3 (#17256) 
- Generated with Claude Code
 2025-04-04 10:31:45 -04:00
Jon Ayers 3a0e8ddf97 chore: update esbuild to 0.25.0 (#17214) 
- Resolves GHSA-67mh-4wv8-2f99
 2025-04-04 02:21:32 -04:00
Jon Ayers ae44ecfc07 chore: update prismjs to 1.30.0 (#17215) 
- Resolves GHSA-x7hr-w5r2-h6wg
 2025-04-03 14:13:34 -04:00
Jon Ayers d6c034d2a3 chore: pin dogfood npm dependencies (#17216) 2025-04-02 03:54:49 -04:00
Jon Ayers b1f5d45112 chore: disable e2e-premium tests (#17213) 
- These tests are providing no value in their current state due to the
frequency of their intermittent failures.
 2025-04-02 07:26:12 +00:00
Jon Ayers d575e7f3ff chore: force babel dependency to 7.26.10 (#17193) 
A bunch of dependency issues with babel, it seems forcing an update to
7.26.10 is ok for now
 2025-04-01 22:05:23 -04:00
Jon Ayers 989c3ec62e chore: pin various dependencies in CI files (#17180) 2025-04-01 00:15:15 -04:00
Jon Ayers 83405677bf chore: pin goimports to 0.31.0 (#17177) 2025-03-31 22:56:21 -04:00
Jon Ayers 7b14b4f5e1 chore: update msw to 2.4.8 (#17167) 
- Fixes a transitive vuln in path-to-regexp
 2025-03-31 15:10:00 -04:00
Jon Ayers 562a6c9ce0 chore: add .cursorrules config (#17160) 2025-03-28 19:33:13 +00:00
Jon Ayers 1360bfe60d chore: fix false positives in CodeQL for TS (#17139) 
Fixes some false positives flagged by CodeQL
 2025-03-27 16:09:53 -05:00
Jon Ayers eded0ed4b6 chore: fix false positives in CodeQL (#17138) 
Clears up some false positives being surfaced by CodeQL
 2025-03-27 16:06:58 -05:00
Jon Ayers 2dc99c8469 fix: correct spurious edits made during the lint fixing slog (#17113) 2025-03-27 01:13:21 -05:00
Jon AyersandClaude 17ddee05e5 chore: update golang to 1.24.1 (#17035) 
- Update go.mod to use Go 1.24.1
- Update GitHub Actions setup-go action to use Go 1.24.1
- Fix linting issues with golangci-lint by:
  - Updating to golangci-lint v1.57.1 (more compatible with Go 1.24.1)

🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <claude@anthropic.com>
 2025-03-26 01:56:39 -05:00
Jon AyersandClaude 8da568b132 chore: update Terraform version from 1.11.0 to 1.11.2 (#17081) 
🤖 Generated with [Claude Code](https://claude.ai/code)

---------

Co-authored-by: Claude <claude@anthropic.com>
 2025-03-25 00:57:15 -05:00
Jon Ayers 10f1e0b39a chore: update terraform to 1.11.0 (#16781) 2025-03-04 14:28:41 -05:00
Jon Ayers 89479cc843 fix(dogfood): re-enable process priority management for dogfood (#15765) 
- The dogfood-related bugs with this feature are (hopefully) resolved.

This reverts commit 19ec6af2ad.
 2024-12-16 21:05:28 +02:00
Jon Ayers 05914cb929 fix: disable init() function in github/charmbracelet/bubbletea dependency (#15817) 
- Fixes an issue where an init function
causes writes to the terminal when using `agent-exec` which results in raw
ansi characters being printed to the web terminal.
- Was also causing significant latency in launching a web terminal
 2024-12-16 20:58:36 +02:00
Jon Ayers 354d0fc4c8 fix: filter agent-exec env vars (#15764) 
- Filters env vars specific to agent-exec from the exec'd process. This
is to prevent any issues when developing Coder in Coder, particularly
agent tests in the cli pkg.
 2024-12-05 16:33:27 +00:00
Jon Ayers f8d938d299 fix: fix oom_score adjustments failing if caps set (#15758) 
- Fixes an issue where oom scores would fail to be adjusted in cases
where the `coder` binary has capabilities set on it. This is because
`PR_SET_DUMPABLE` is set to `0` when a process is executed with elevated
capabilities. The fix is to flip `PR_SET_DUMPABLE` to `1` prior to
writing to `oom_score_adj`.
 2024-12-05 15:30:58 +02:00
Jon Ayers ce573b9faa fix: add agent exec abstraction (#15717) 2024-12-04 23:30:25 +02:00
Jon Ayers a16f877c5b fix: update portforward storybook tests to include host (#15680) 2024-11-28 15:22:36 +02:00
Jon Ayers ffb0ebb5b6 fix: use url-parse for url construction (#15670) 
This fixes some CodeQL-flagged issues. They're not real issues but the
refactor is small and it'll keep the analysis tools quiet.
 2024-11-27 23:52:11 +02:00
Jon Ayers 24d44b4518 fix: add additional context to agent exec errors (#15676) 2024-11-27 21:29:08 +02:00
Jon Ayers b08238c8db chore: enable process priority management for dogfood (#15674) 2024-11-27 20:43:56 +02:00
Jon Ayers 1f238fed59 feat: integrate new agentexec pkg (#15609) 
- Integrates the `agentexec` pkg into the agent and removes the
legacy system of iterating over the process tree. It adds some linting
rules to hopefully catch future improper uses of `exec.Command` in the package.
 2024-11-27 20:12:15 +02:00
Jon Ayers 45d9274aca chore: disable parallelization when running security action (#15666) 
- `make -j` appears to be broken for clean builds
 2024-11-26 23:35:51 +02:00
Jon Ayers bbc549d2df feat: add agent exec pkg (#15577) 2024-11-25 17:22:12 +02:00
Jon Ayers 48bb452829 fix: fix tailnet resume using incorrect DB reference (#15522) 
- We were instantiating a cryptokey cache with a vanilla reference to
the database instead of one wrapped by dbcrypt.
- Fixes an issue where failing to instantiate unrelated keycaches does
not fatally error out.
 2024-11-18 14:09:04 -06:00
Jon Ayers 097fdaffe2 chore: add quota to source-controlled template (#15271) 2024-10-29 16:31:46 +00:00
Jon Ayers fd60e1c2ba fix: fix security workflow not installing protoc properly (#15263) 2024-10-29 01:30:43 +00:00
Jon Ayers fb4219f57d fix: parse int to correct bit size (#15257) 2024-10-28 20:31:01 +00:00
Jon Ayers cd890aa3a0 feat: enable key rotation (#15066) 
This PR contains the remaining logic necessary to hook up key rotation
to the product.
 2024-10-25 17:14:35 +01:00
Jon Ayers bcd68ee249 fix: fix build in security workflow (#15209) 
- Fixes an issue where building the Docker image failed due to moving
the directory hosting the Dockerfile
- Removed the Palo Alto scanning since our subscription there is set to
expire. Trivy is still running though.
 2024-10-24 01:21:18 +01:00
Jon Ayers f537193682 chore: refactor keycache implementation to reduce duplication (#15100) 2024-10-16 20:01:45 +01:00
Jon Ayers 7da231bc92 fix: fix error handling to prevent spam in proc prio management (#15071) 2024-10-15 02:17:10 +00:00
Jon Ayers 384873a114 feat: add wsproxy implementation for key fetching (#14917) 2024-10-14 20:04:10 +01:00
Jon Ayers 68ec532ca7 feat: add jwt pkg (#14928) 
- Adds a `jwtutils` package to be shared amongst the various
packages in the codebase that make use of JWTs. It's intended to help us
standardize on one library instead of some implementations using
`go-jose` and others using `golang-jwt`.

The main reason we're converging on `go-jose` is due to its support for
JWEs, `golang-jwt` also has a repo to handle it but it doesn't look
maintained: https://github.com/golang-jwt/jwe
 2024-10-03 21:09:52 -05:00
Jon Ayers 21b92ef893 feat: add cache abstraction for fetching signing keys (#14777) 
- Adds the database implementation for fetching and caching keys
used for JWT signing. It's been merged into the `keyrotate` pkg and
renamed to `cryptokeys` since they're coupled concepts.
 2024-10-01 11:04:51 -05:00
Jon Ayers 3fdeaf7b24 feat: add endpoint for fetching workspace proxy keys (#14789) 2024-09-26 21:01:49 +01:00
Jon Ayers 2d5c068525 feat: implement key rotation system (#14710) 2024-09-19 19:12:44 +01:00
Jon Ayers 45160c7679 feat: add schema for key rotation (#14662) 2024-09-17 18:08:18 +01:00
Jon Ayers bfdc29f466 fix: suppress benign errors when listing processes (#14660) 2024-09-12 23:00:04 +01:00
Jon Ayers 9f4972901c fix: avoid logging no such process errors for process priority (#14655) 2024-09-12 18:00:42 +00:00
Jon Ayers 328e69629c fix: limit OAuth redirects to local paths (#14585) 
- This prevents a malicious user from crafting a redirect
  URL to a nefarious site under their control.
 2024-09-10 15:58:50 +01:00
Jon Ayers b6d35edebd chore: remove meticulous from CI (#14369) 2024-08-20 14:13:13 -04:00
Jon Ayers 4fc047954e fix: avoid deleting peers on graceful close (#14165) 
* fix: avoid deleting peers on graceful close

- Fixes an issue where a coordinator deletes all
  its peers on shutdown. This can cause disconnects
  whenever a coderd is redeployed.
 2024-08-14 15:16:08 -04:00
Jon Ayers 203f48af56 fix: extend locking in wsproxy to avoid race (and fix flake) (#14167) 2024-08-05 14:30:44 -04:00
Jon Ayers 4e0cb60eeb fix: ignore errors on provided logger (#14169) 2024-08-05 17:22:34 +00:00
Jon Ayers f9b660e573 fix: ignore coderd log errors (#14166) 
- This is the source of a lot of our flakes recently.
 2024-08-05 12:07:06 -04:00
Jon Ayers f3ff172979 chore: remove dependency license review (#14131) 
- It's bafflingly buggy and is a source of annoyance for virtually the
  whole team.
- Will revisit if we don't have alternatives to catching invalid licenses.
 2024-08-02 14:14:14 -04:00
Jon Ayers 3a614f1602 fix: random typos in offline docs documentation (#13979) 2024-07-23 11:48:58 -05:00
Jon Ayers 8d4bccc612 feat: add meticulous recorder (#13886) 2024-07-18 20:15:07 -05:00
Jon Ayers 464e7979c4 docs: remove mention of built-in remote desktop on the roadmap (#13459) 2024-07-09 16:29:44 -05:00
Jon Ayers 7995d7c3d6 fix: only render tooltip when require_active_version enabled (#13484) 2024-06-06 02:52:49 +00:00
Jon Ayers ee817b4d80 fix: fix nix flake sed command (#13243) 2024-05-11 01:10:19 +03:00
Jon Ayers 82c1562f82 fix: skip license review for dependabot (#13239) 2024-05-10 18:14:03 +00:00
Jon Ayers 8269124ab7 feat: sign windows binaries (#13086) 2024-04-29 10:43:27 -05:00
Jon Ayers 0c993566dd hotfix: skip dependency license review on main (#12982) 2024-04-16 23:08:22 -05:00
Jon Ayers 80f5978124 chore: add license review to CI (#12981) 2024-04-16 22:52:07 -05:00
Jon Ayers 426e9f2b96 feat: support adjusting child proc oom scores (#12655) 2024-04-03 09:42:03 -05:00
Jon Ayers 951dfaa99c feat: add workspace_id to workspace_build audit logs (#12718) 2024-03-22 15:10:32 -05:00
Jon Ayers 73c5993bea fix: only display xray results if vulns > 0 (#11989) 2024-02-02 11:02:46 -06:00
Jon Ayers 0c30dde9b5 feat: add customizable upgrade message on client/server version mismatch (#11587) 2024-01-30 17:11:37 -06:00
Jon Ayers 4f5a2f0a9b feat: add backend for jfrog xray support (#11829) 2024-01-29 19:30:02 -06:00
Jon Ayers 383eed93f8 fix: use correct logger for lifecycle_executor (#11763) 2024-01-23 14:33:55 -06:00
Jon Ayers 552e9fe22f fix: avoid returning 500 on apps when workspace stopped (#11656) 2024-01-17 12:06:59 -06:00
Jon Ayers 1196f83ebd feat: automatically activate dormant workspaces when manually started (#11655) 2024-01-16 16:42:04 -06:00
Jon AyersMuhammad Atif Alikirby
 		6ebcee3b49 docs: add workspace cleanup docs (#11146) 
Co-authored-by: Muhammad Atif Ali <atif@coder.com>
Co-authored-by: kirby <kirby@coder.com>
 2024-01-16 15:12:56 -06:00
Jon Ayers aecdafdcf2 fix: fix template edit overriding with flag defaults (#11564) 2024-01-11 16:18:46 -06:00
Jon Ayers 9b437032e9 feat: remove workspace_actions experiment (#11427) 2024-01-10 16:19:39 -06:00
Jon Ayers 0b7d68dc3f chore: remove template_update_policies experiment (#11250) 2023-12-21 13:39:33 -06:00
Jon Ayers 56cbd47082 chore: fix TestWorkspaceAutobuild/DormancyThresholdOK flake (#11251) 2023-12-18 09:23:06 -06:00
Jon Ayers 06394a5b8c Revert "fix: prevent data race when mutating tags (#11200)" (#11216) 
This reverts commit 82f7b0cef4.
 2023-12-14 12:37:55 -06:00
Jon Ayers 82f7b0cef4 fix: prevent data race when mutating tags (#11200) 2023-12-14 08:56:59 +00:00
Jon Ayers 41dbe7de4e fix: use correct permission when determining orphan deletion privileges (#11143) 2023-12-12 08:24:04 -06:00
Jon Ayers 45c07317c0 docs: add documentation for template update policies (#11145) 2023-12-11 19:05:25 -06:00
Jon AyersandMcKayla Washburn ba3b835339 fix: prevent editing build parameters if template requires active version (#11117) 
Co-authored-by: McKayla Washburn <mckayla@hey.com>
 2023-12-11 15:54:16 -07:00
Jon Ayers 37f6b38d53 fix: return 403 when rebuilding workspace with require_active_version (#11114) 2023-12-08 23:03:46 -06:00
Jon Ayers 02696f2df9 chore: fix flake in TestExecutorAutostopTemplateDisabled (#11096) 2023-12-08 09:02:54 +00:00
Jon Ayers e73a202aed feat: show dormant workspaces by default (#11053) 2023-12-07 18:09:35 -06:00
Jon Ayers ce49a55f56 chore: update build_reason 'autolock' -> 'dormancy' (#11074) 2023-12-07 17:11:57 -06:00
Jon Ayers 967db2801b chore: refactor ResolveAutostart tests to use dbfake (#10603) 2023-11-30 19:33:04 -06:00