opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-24 15:04:27 +08:00
Code Issues Packages Projects Releases Wiki Activity
3,611 Commits 479 Branches 388 Tags
9c4ccd76a01ac227dd5bca83d3e9d44606229afe
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Kyle CarberryandColin Adler 385a4262e2 fix: remove audit-logging flag from the server (#6991) 
Co-authored-by: Colin Adler <colin1adler@gmail.com>
 2023-04-04 12:11:10 -05:00
Kyle Carberry c12bc39821 fix: always show a newly created workspace at the top of the list (#6984) 
Fixes #5795.
 2023-04-04 08:24:04 -05:00
Kyle Carberry 861d4afdd8 fix: update tailscale to remove websocket logs (#6981) 2023-04-03 16:28:49 +00:00
Kyle Carberry bc18f6c113 fix: add CODER_AGENT_TAILNET_LISTEN_PORT for specifying a static tailnet port (#6980) 
Fixes #5175.
 2023-04-03 16:20:19 +00:00
Kyle Carberry 4ee01dc95c fix: remove orphan rbac warning message (#6979) 
The request will fail if the user doesn't have permissions, so it seems
useless to output this.
 2023-04-03 11:15:56 -05:00
Kyle Carberry 55c0b26977 fix: update status text for the workspace progress bar (#6977) 
Fixes #4691.
 2023-04-03 11:00:56 -05:00
Kyle Carberry 2d051094e7 fix: ignore deleted workspaces in global stats (#6973) 
Fixes #6568.
 2023-04-03 14:46:09 +00:00
Kyle Carberry 84956c16cc fix: reduce spacing when agent metadata doesn't exist (#6937) 2023-03-31 22:08:42 +00:00
Kyle Carberry cd807bc0c8 fix: delete old addresses from the active derp mesh mapping (#6926) 2023-03-31 14:25:01 +00:00
Kyle Carberry b5f5740d0b chore: ensure agent conn routine is closed before exit (#6900) 
This caused a leak in `main`!
 2023-03-30 17:20:14 +00:00
Kyle Carberry e496bdb687 chore: update slog to fix local leak with http.Transport (#6899) 2023-03-30 12:13:15 -05:00
Kyle Carberry a63c97b8de chore: wrap audit logs in a mutex to fix data race (#6898) 
This was seen in `main`!
 2023-03-30 12:13:03 -05:00
Kyle Carberry 5780006adb chore: use http-swagger/v2 for go:embed to reduce binary size (#6897) 
I'm testing how much this will reduce the size, but it should
be by a few MB!
 2023-03-30 16:46:58 +00:00
Kyle Carberry 8f55f5c28b chore: ensure go.mod has proper references to forked deps (#6893) 
There were a few that have been merged upstream!
 2023-03-30 11:19:11 -05:00
Kyle Carberry a6b7e8c43a chore: use an older version of fastclock to resolve leak (#6892) 2023-03-30 10:58:56 -05:00
Kyle Carberry 04e404e448 chore: dial the remote socket continually until connect (#6891) 
It's possible that the command starts but the socket isn't ready
even when the file exists.
 2023-03-30 15:36:23 +00:00
Kyle Carberry 5686fc9983 chore: skip chdir template push test on windows (#6890) 
See https://github.com/coder/coder/actions/runs/4565958214/jobs/8057842941
 2023-03-30 10:21:13 -05:00
Kyle Carberry 401b9276ae chore: clone styles to prevent race (#6888) 
See https://github.com/coder/coder/actions/runs/4565541977/jobs/8056830691?pr=6885
 2023-03-30 10:18:24 -05:00
Kyle Carberry 5c1dc1b7fe fix: iterate through all workspace updates on logs overflow (#6885) 
This was causing some flakes!
 2023-03-30 10:05:45 -05:00
Kyle Carberry e470162305 chore: move away from set-output in GitHub Actions (#6884) 
This is deprecated! See:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
 2023-03-30 09:58:56 -05:00
Kyle Carberry 1f600fc526 chore: use defer instead of t.Cleanup for chdir (#6887) 
This _might_ resolve the races in `TestTemplatePush`.
 2023-03-30 09:48:03 -05:00
Kyle Carberry 6378294071 chore: upgrade from deprecated protobuf import (#6883) 
This was displaying a warning when running `go get ./...`.
 2023-03-30 14:17:44 +00:00
Kyle Carberry a2d3635207 fix: update tailscale to resolve h2 vs http/1.1 (#6827) 
DERP will always fallback to WebSockets if h2 is chosen now!
 2023-03-27 21:05:10 +00:00
Kyle Carberry 5e01e6e448 fix: check if logs are completed before publishing (#6824) 2023-03-27 15:50:53 -05:00
Kyle Carberry ad0c0df104 chore: update tailscale to fix http2 upgrade (#6811) 
See https://github.com/coder/tailscale/pull/15
 2023-03-27 14:22:11 -05:00
Kyle Carberry ffb4cd5962 chore: fix race when expecting parameters (#6814) 
See https://github.com/coder/coder/actions/runs/4532378002/jobs/7983840014
 2023-03-27 14:18:33 -05:00
Kyle Carberry d7d210de36 Revert "chore: update tailscale to fix http2 upgrade (#6761)" (#6779) 
This reverts commit 622fc6d9c2.
 2023-03-24 12:40:05 -05:00
Kyle Carberry 622fc6d9c2 chore: update tailscale to fix http2 upgrade (#6761) 
See https://github.com/coder/tailscale/pull/15
 2023-03-24 11:20:21 -05:00
Kyle Carberry 2383f64d89 fix: add dbauthz for streaming startup logs (#6758) 
This was causing logs to end early!
 2023-03-23 15:02:29 -05:00
Kyle CarberryandAsher cb7375450b feat: add startup script logs to the ui (#6558) 
* Add startup script logs to the database

* Add coderd endpoints for startup script logs

* Push startup script logs from agent

* Pull startup script logs on frontend

* Rename queries

* Add constraint

* Start creating log sending loop

* Add log sending to the agent

* Add tests for streaming logs

* Shorten notify channel name

* Add FE

* Improve bulk log performance

* Finish UI display

* Fix startup log visibility

* Add warning for overflow

* Fix agent queue logs overflow

* Display staartup logs in a virtual DOM for performance

* Fix agent queue with loads of logs

* Fix authorize test

* Remove faulty test

* Fix startup and shutdown reporting error

* Fix gen

* Fix comments

* Periodically purge old database entries

* Add test fixture for migration

* Add Storybook

* Check if there are logs when displaying features

* Fix startup component overflow gap

* Fix startup log wrapping

---------

Co-authored-by: Asher <ash@coder.com>
 2023-03-23 14:09:13 -05:00
Kyle Carberry ed9a3b9251 fix: use a background context when piping derp connections (#6750) 
This was causing boatloads of connects to reestablish every time...

See https://github.com/coder/coder/issues/6746
 2023-03-23 09:54:07 -05:00
Kyle Carberry dab4a0e6ef fix: add ResourceUserData to provisionerd to allow git auth (#6743) 
This was breaking passing a git auth token through!
 2023-03-22 17:23:49 -05:00
Kyle Carberry df31636e72 feat: pass access_token to coder_git_auth resource (#6713) 
This allows template authors to leverage git auth to perform
custom actions, like clone repositories.
 2023-03-22 19:37:08 +00:00
Kyle Carberry ad9c9b468f fix: block updating mutable parameters (#6717) 2023-03-22 11:05:04 -05:00
Kyle Carberry 38d278ac46 fix: use the default value for a rich parameter if unset (#6715) 
This fixes an error thrown on the workspace settings page when
a new parameter is added and the workspace hasn't been built yet.
 2023-03-22 00:02:55 +00:00
Kyle Carberry abe1e89f80 chore: increase parallelism of TestWorkspaceQuota (#6710) 
This does a lot of build operations, so having multiple provisioner
daemons is great.

We were actually approaching the ceiling here for test duration!
 2023-03-21 22:44:01 +00:00
Kyle Carberry 7e854adbb3 fix: poll audit logs to ensure write is last (#6708) 2023-03-21 19:19:09 +00:00
Kyle Carberry 71eecb3515 chore: embed build info in the html to reduce requests (#6605) 
This will reduce a request on every page load of Coder!
 2023-03-21 19:04:54 +00:00
Kyle Carberry e1c755be81 chore: remove fast metric cache interval for apps tests (#6702) 
This wasn't helping CI run fast, that's for sure!
 2023-03-21 18:13:34 +00:00
Kyle Carberry aaa3b31a0b chore: add echo helper to create an agent with token (#6576) 
This should reduce some LOC and duplication in tests!
 2023-03-21 18:03:38 +00:00
Kyle Carberry d05b48267a fix: update tailscale to resolve websocket stun fallback (#6696) 
See https://github.com/coder/tailscale/pull/14
 2023-03-21 12:37:34 -05:00
Kyle Carberry 247470b1d6 fix: increase timeout of CreateTemplatePage initial render (#6694) 
This might fix some test flakes we've been seeing!
 2023-03-21 13:24:07 -03:00
Kyle Carberry 1b35ac80f2 fix: ensure agent DisconnectedAt is greater than or equal LastConnectedAt (#6692) 
See https://github.com/coder/coder/actions/runs/4471502401/jobs/7856475920
 2023-03-21 11:08:39 -05:00
Kyle Carberry c3fb1b325f feat: add owner_oidc_access_token to coder_workspace data source (#6042) 
See the discussion in Discord here:
https://discord.com/channels/747933592273027093/1071182088490987542/1071182088490987542

Related provider PR: coder/terraform-provider-coder#91
 2023-03-17 15:25:08 -05:00
Kyle CarberryandColin Adler ffca3a5fb3 fix: remove noop templates plan command (#6617) 
Co-authored-by: Colin Adler <colin1adler@gmail.com>
 2023-03-16 21:28:22 +00:00
Kyle Carberry b693b9f599 chore: fix workspace audit log flake (#6494) 
This happened because sometimes a build would be queued
and completed intermittently in CI.

See https://github.com/coder/coder/actions/runs/4358121985/jobs/7618290591
 2023-03-16 12:47:54 -05:00
Kyle Carberry f91b3acf93 fix: group routine workspace agent stats by id (#6601) 
Before this was creating separate rows for distinct stat entries, which
resulted in significantly more data being sent to telemetry.
 2023-03-14 10:52:03 -05:00
Kyle Carberry 17bc5794d4 fix: direct embedded derp traffic directly to the server (#6595) 
Prior to this change, DERP traffic would route from `coderd` to the
`CODER_ACCESS_URL` to reach the internal DERP server, which may have
resulted in slower connections due to proxying, or the failure of
web traffic entirely.

If your Coder deployment has a proxy in front of it, your traffic through
web terminals, apps, and port-forwarding is about to get a lot faster!
 2023-03-14 14:46:47 +00:00
Kyle Carberry 35df1b10d0 feat: add workspace agent stat reporting to telemetry (#6577) 
This aggregates stats periodically and sends them by agent ID to
our telemetry server. It should help us identify which editors are
primarily in use.
 2023-03-13 14:16:54 -05:00
Kyle Carberry 7fa6483d84 fix: allow the BINARY_DIR to be configured in the agent script (#6567) 2023-03-11 19:39:40 +00:00
Kyle Carberry 1db2b12b8e chore: add a test to ensure audit code works with AGPL (#6561) 
Fixes the regression seen in v0.19.1.
 2023-03-10 17:04:40 +00:00
Kyle Carberry 7eb2c2ff6d Revert "chore: Implement joins with golang templates (#6429)" (#6560) 
This reverts commit 8b125d6c5d.
 2023-03-10 10:39:02 -06:00
Kyle Carberry 4a07fcd9d2 fix: ensure local derp uses the hostname (#6559) 
This broke deployments that use a custom port with an access
URL. We should write a test for this!
 2023-03-10 09:58:31 -06:00
Kyle Carberry 65878b04ce fix: remove "something went wrong" text for watching a workspace (#6541) 
This text wasn't useful to a customer anyways, because we don't get
an error from EventSource. This can happen if you close your laptop
and open it again, so it's better if we don't display it.
 2023-03-09 20:54:28 +00:00
Kyle Carberry 1b3b0ea962 fix: adjust workspace filter query when the path changes (#6539) 
Previously, when a status would change the filter wouldn't update.
This makes it update if a new value is passed in.
 2023-03-09 14:23:23 -06:00
Kyle Carberry 9a7998301b fix: remove deployment bar info icon and adjust language (#6537) 
Re @bpmct's feedback
 2023-03-09 20:08:50 +00:00
Kyle Carberry 70b093ff2a fix: filter session count sums by created_at (#6529) 
Fixes the session totals being waaaaay too high!
 2023-03-09 17:08:41 +02:00
Kyle Carberry 1cc10f2ffb fix: only sum connection latencies when they are set (#6524) 
This was producing a median that didn't make sense.
 2023-03-09 03:53:09 +00:00
Kyle Carberry a78786119d chore: resolve race when running load tests with logs (#6523) 
See https://github.com/coder/coder/actions/runs/4370166746/jobs/7644793277
 2023-03-08 21:12:20 -06:00
Kyle Carberry 5304b4e483 feat: add connection statistics for workspace agents (#6469) 
* fix: don't make session counts cumulative

This made for some weird tracking... we want the point-in-time
number of counts!

* Add databasefake query for getting agent stats

* Add deployment stats endpoint

* The query... works?!?

* Fix aggregation query

* Select from multiple tables instead

* Fix continuous stats

* Increase period of stat refreshes

* Add workspace counts to deployment stats

* fmt

* Add a slight bit of responsiveness

* Fix template version editor overflow

* Add refresh button

* Fix font family on button

* Fix latest stat being reported

* Revert agent conn stats

* Fix linting error

* Fix tests

* Fix gen

* Fix migrations

* Block on sending stat updates

* Add test fixtures

* Fix response structure

* make gen
 2023-03-08 21:05:45 -06:00
Kyle Carberry 9d40d2ffdc fix: remove create first user from the cli message (#6493) 
This adjusts our setup to just show the Web UI, since you
can now create everything from there!
 2023-03-09 02:54:46 +00:00
Kyle Carberry db2bdd1cab fix: pass sdk header transport to websocket connections (#6521) 
Fixes #6520.
 2023-03-09 02:29:02 +00:00
Kyle Carberry d67552f852 fix: add more cached certificates to azure instance identity (#6519) 
This was failing for GovCloud. Now it falls back to fetch, and a test
has been added to notify when certificates are becoming outdated.
 2023-03-08 19:32:10 -06:00
Kyle Carberry 7df1e3bdd6 fix: centralize deployment config blocks to resolve race (#6512) 
See https://github.com/coder/coder/actions/runs/4365865438/jobs/7635236079
 2023-03-08 16:55:52 +00:00
Kyle Carberry 524b14adbc fix: fetch provisioner logs after end of logs message (#6495) 
I think this should _actually_ fix it. See
https://github.com/coder/coder/actions/runs/4358242625/jobs/7618562167

The problem was that this loop is ran async so even though
messages are sent in order, we were processing too slowly and
the end of logs was published first.
 2023-03-09 01:13:08 +10:00
Kyle Carberry bb0a996fc2 chore: fix buffered provisioner job logs close flake (#6492) 
See https://github.com/coder/coder/actions/runs/4357599919/jobs/7617111287
 2023-03-07 20:08:13 +00:00
Kyle Carberry f287889cd7 chore: move client pubsub for HA coordinator after register (#6487) 
Similar fix that happened for the agent. See:
https://github.com/coder/coder/actions/runs/4356099388/jobs/7613634277
 2023-03-07 16:46:54 +00:00
Kyle Carberry 4c204fc348 chore: ensure auto-approve-docs has a deep enough depth (#6484) 
* chore: ensure auto-approve-docs has a deep enough depth

This was failing on numerous PRs.

* Remove check because it isn't working
 2023-03-07 10:05:00 -06:00
Kyle Carberry 23bebb40e2 fix: bump migration to resolve duplicate id (#6486) 
This happened because two PRs with different migrations
merged at the same time!
 2023-03-07 10:04:06 -06:00
Kyle Carberry f19076cf06 chore: fix coordinator flake by moving pubsub below register (#6482) 
After making the in-memory pubsub conform to the expectations of
PostgreSQL, this flake started appearing.

This fixes it because the agent socket is registered when a message
is received.
 2023-03-07 09:38:18 -06:00
Kyle Carberry 87ed7a7dba chore: use nil map on agent stats to check if report interval should be returned (#6479) 
See https://github.com/coder/coder/actions/runs/4350638262/jobs/7601537088
 2023-03-07 14:25:04 +00:00
Kyle Carberry fd02f73708 chore: ensure pubsub messages are delivered in order for in-memory variant (#6474) 
PostgreSQL provides this guarantee, which led to some flakes in tests.
See: https://github.com/coder/coder/actions/runs/4350034299/jobs/7600478096
 2023-03-07 04:36:25 +00:00
Kyle Carberry 74632e460c fix: adjust build state permission to require template update (#6472) 2023-03-07 04:24:32 +00:00
Kyle Carberry 29ced72cda chore: fix stats leaking in tests (#6478) 
See https://github.com/coder/coder/actions/runs/4350254306/jobs/7601134509
 2023-03-07 04:09:02 +00:00
Kyle Carberry 034641dc77 chore: migrate security checks to run on a cron (#6477) 
They were taking a long time and seemed to be reducing concurrency
for our other CI actions.
 2023-03-06 21:46:40 -06:00
Kyle Carberry 7a8ccda40e chore: copy forced derp websockets to fix flake (#6475) 
See: https://github.com/coder/coder/actions/runs/4350034299/jobs/7600478389
 2023-03-06 21:29:41 -06:00
Kyle Carberry 964032d783 chore: ignore query cancel error in activitybump (#6476) 
See https://github.com/coder/coder/actions/runs/4350254306/jobs/7600782432

It's fine to ignore this, because workspace agent stats happen async
and might occur when shutting down.
 2023-03-06 21:27:21 -06:00
Kyle Carberry 09f87d1df1 chore: remove empty case for metricscache (#6473) 
This wasn't necessary to test and just caused flakes.
See: https://github.com/coder/coder/actions/runs/4350034299/jobs/7600340648
 2023-03-06 21:13:08 -06:00
Kyle Carberry cf75d7e1fb fix: clean up idle http conns on wsconncache close (#6471) 
See https://github.com/coder/coder/actions/runs/4346769070/jobs/7593243836
 2023-03-06 20:45:49 -06:00
Kyle Carberry e0137bcff1 fix: ensure tailnet websockets are closed (#6470) 
See: https://github.com/coder/tailscale/pull/10
 2023-03-06 20:45:24 -06:00
Kyle Carberry 2ff1c6d613 feat: add agent stats for different connection types (#6412) 
This allows us to track when our extensions are used, when the
web terminal is used, and average connection latency to the agent.
 2023-03-02 08:06:00 -06:00
Kyle Carberry 1724cbf872 feat: automatically use websockets if DERP upgrade is unavailable (#6381) 
* feat: automatically use websockets if DERP upgrade is unavailable

This might be our biggest hangup for deployments at the moment...

Load balancers by default do not support the DERP protocol, so many
of our prospects and customers run into failing workspace connections.
This automatically swaps to use WebSockets, and reports the reason to
coderd.

In a future contribution, a warning will appear by the agent if it was
forced to use WebSockets instead of DERP.

* Fix nil pointer type in Tailscale dep

* Fix requested changes
 2023-03-01 22:18:14 +00:00
Kyle Carberry 9ea21bf8ee fix: hardcode azure instance identity intermediate certificates (#6402) 
This was broken for an airgapped customer!
 2023-03-01 17:39:24 +00:00
Kyle Carberry 8850ce0d9a fix: use bigint instead of integer in stats migration (#6380) 
This broke dogfood!
 2023-02-28 13:55:37 -06:00
Kyle Carberry 05e449943d chore: convert agent stats to use a table (#6374) 
* chore: convert workspace agent stats from json to table

* chore: convert agent stats to use a table

Backwards compatibility becomes hard when all agent stats are in a JSON blob.
We also want to query this table for new agents that are failing health checks
so we can display it in the UI.

* Fix migration using default values
 2023-02-28 13:33:33 -06:00
Kyle Carberry 7f226d4f90 feat: add support for coder_git_auth data source (#6334) 
* Add git auth providers schema

* Pipe git auth providers to the schema

* Add git auth providers to the API

* Add gitauth endpoint to query authenticated state

* Add endpoint to query git state

* Use BroadcastChannel to automatically authenticate with Git

* Add error validation for submitting the create workspace form

* Fix panic on template dry-run

* Add tests for the template version Git auth endpoint

* Show error if no gitauth is configured

* Add gitauth to cliui

* Fix unused method receiver

* Fix linting errors

* Fix dbauthz querier test

* Fix make gen

* Add JavaScript test for git auth

* Fix bad error message

* Fix provisionerd test race

See https://github.com/coder/coder/actions/runs/4277960646/jobs/7447232814

* Fix requested changes

* Add comment to CreateWorkspacePageView
 2023-02-27 10:18:19 -06:00
Kyle Carberry 3d8b77d6f1 chore: improve clarity of the agent logs (#6345) 
I looked through these logs when debugging and there was a bit of spam!
 2023-02-27 09:20:24 -06:00
Kyle Carberry 7c46f76c82 chore: fetch templates by id without lock in dbfake (#6351) 
See https://github.com/coder/coder/actions/runs/4276632002/jobs/7444857508
 2023-02-26 15:29:43 -06:00
Kyle Carberry acbe968f41 chore: increase activitybump deadline duration to fix flake (#6350) 
This is a bad fix because the test is still dependant on time, but it's
still an improvement.
 2023-02-26 13:42:01 -06:00
Kyle Carberry 1fb7365cb1 fix: use -U when installing with rpm (#6349) 
Fixes #6275.
 2023-02-26 18:11:23 +00:00
Kyle Carberry 17adfd1134 chore: improve times of ratelimit tests (#6346) 
From 5s to 130ms!
 2023-02-25 22:01:01 +00:00
Kyle Carberry d613ba9987 security: add X-Content-Type-Options: nosniff to block MIME-sniffing (#6344) 
coder/security#12
 2023-02-25 11:18:45 -06:00
Kyle Carberry 8a4a179565 fix: use proper generated cli.md for deploy (#6323) 2023-02-23 11:07:57 -06:00
Kyle Carberry 2a8a147e7d fix: don't log disconnect error when the database is shutting down (#6309) 
* fix: don't log disconnect error when the database is shutting down

Seen in: https://github.com/coder/coder/actions/runs/4244980490/jobs/7379867681

* Generalize the query close error
 2023-02-22 16:07:26 -06:00
Kyle Carberry a79f4a095d fix: allow mapped resources in our terraform provider (#6255) 2023-02-17 16:05:38 +00:00
Kyle Carberry d5af536ea2 fix: allow mapped resources in our terraform provider (#6242) 
Fixes #6234.
 2023-02-16 13:04:40 -06:00
Kyle Carberry 51f17b1820 fix: allow disabling all password auth even if owner (#6193) 
* fix: allow disabling all password auth even if owner

Removes any and all ability to auth with a password.

* Hide create user if password auth is disabled
 2023-02-14 08:58:12 -06:00
Kyle Carberry 2d0a69ba47 fix: require client pipe to be closed in provisionerd test (#6188) 
https://github.com/coder/coder/actions/runs/4165019548/jobs/7207442687
 2023-02-14 00:46:05 +00:00
Kyle Carberry c0c83f17b2 fix: follow tailscale idioms for when to update nodes (#6164) 2023-02-10 16:59:24 -06:00
Kyle Carberry 4827d9edb8 fix: increase generated password length resolve flake (#6116) 2023-02-08 20:59:07 +00:00