opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-24 15:04:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(site): use total_member_count for group subtitles when sharing (#21744)

Browse Source 
Justification:

- Populating `members` is authorized with `group_member.read` which is
not required to be able to share a workspace

- Populating `total_member_count` is authorized with `group.read` which
is required to be able to share

- The updated helper is only used in template/workspace sharing UIs, so
other pages that might need counts of readable members are unaffected

Related to: https://github.com/coder/internal/issues/1302
This commit is contained in:
George K
2026-01-29 08:33:02 -08:00
committed by GitHub
parent 9f6ce7542a
commit f5d4926bc1
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
site/src/modules/groups.ts
+3 -5
View File
@@ -41,13 +41,11 @@ export const getGroupSubtitle = (group: Group): string => {
return "All users";
}
if (!group.members) {
return "0 members";
}
const total = group.total_member_count ?? group.members?.length ?? 0;
if (group.members.length === 1) {
if (total === 1) {
return "1 member";
}
return `${group.members.length} members`;
return `${total} members`;
};