fix(site): update story play functions after HelpTooltip→HelpPopover migration (#23876)

This commit is contained in:
Danielle Maywood
2026-03-31 21:50:05 +01:00
committed by GitHub
parent cccb680ec2
commit e769d1bd7d
9 changed files with 22 additions and 33 deletions
@@ -18,11 +18,9 @@ type Story = StoryObj<typeof InfoTooltip>;
export const Example: Story = {
play: async ({ step }) => {
await step("activate hover trigger", async () => {
await userEvent.hover(screen.getByRole("button"));
await userEvent.click(screen.getByRole("button"));
await waitFor(() =>
expect(screen.getByRole("tooltip")).toHaveTextContent(
meta.args.message,
),
expect(screen.getByRole("dialog")).toHaveTextContent(meta.args.message),
);
});
},
@@ -35,9 +33,9 @@ export const Notice = {
},
play: async ({ step }) => {
await step("activate hover trigger", async () => {
await userEvent.hover(screen.getByRole("button"));
await userEvent.click(screen.getByRole("button"));
await waitFor(() =>
expect(screen.getByRole("tooltip")).toHaveTextContent(
expect(screen.getByRole("dialog")).toHaveTextContent(
Notice.args.message,
),
);
@@ -52,9 +50,9 @@ export const Warning = {
},
play: async ({ step }) => {
await step("activate hover trigger", async () => {
await userEvent.hover(screen.getByRole("button"));
await userEvent.click(screen.getByRole("button"));
await waitFor(() =>
expect(screen.getByRole("tooltip")).toHaveTextContent(
expect(screen.getByRole("dialog")).toHaveTextContent(
Warning.args.message,
),
);
@@ -211,8 +211,8 @@ export const TerraformManagedDirty: Story = {
play: async ({ canvasElement }) => {
const canvas = within(canvasElement);
const outdatedStatus = canvas.getByText("Outdated");
await userEvent.hover(outdatedStatus);
await screen.findByRole("tooltip");
await userEvent.click(outdatedStatus);
await screen.findByRole("dialog");
},
};
@@ -27,9 +27,9 @@ async function expectTooltip(
hasTroubleshootLink: boolean,
) {
const icon = screen.getByRole("status", { name: ariaLabel });
await userEvent.hover(icon);
await userEvent.click(icon);
await waitFor(() => {
const tooltip = screen.getByRole("tooltip");
const tooltip = screen.getByRole("dialog");
expect(tooltip).toHaveTextContent(title);
expect(tooltip).toHaveTextContent(detail);
if (hasTroubleshootLink) {
@@ -11,8 +11,8 @@ import {
HelpPopoverLinksGroup,
HelpPopoverText,
HelpPopoverTitle,
HelpPopoverTrigger,
} from "#/components/HelpPopover/HelpPopover";
import { TooltipTrigger } from "#/components/Tooltip/Tooltip";
type SubAgentOutdatedTooltipProps = {
devcontainer: WorkspaceAgentDevcontainer;
@@ -34,11 +34,11 @@ export const SubAgentOutdatedTooltip: FC<SubAgentOutdatedTooltipProps> = ({
return (
<HelpPopover>
<TooltipTrigger className="px-0 py-1 bg-transparent text-inherit border-none opacity-50 hover:opacity-100">
<HelpPopoverTrigger className="px-0 py-1 bg-transparent text-inherit border-none opacity-50 hover:opacity-100">
<span role="status" className="cursor-pointer">
Outdated
</span>
</TooltipTrigger>
</HelpPopoverTrigger>
<HelpPopoverContent>
<div className="flex flex-col gap-2">
<div>
@@ -37,9 +37,9 @@ const Example: Story = {
const body = within(canvasElement.ownerDocument.body);
await step("activate hover trigger", async () => {
await userEvent.hover(body.getByRole("button"));
await userEvent.click(body.getByRole("button"));
await waitFor(() =>
expect(screen.getByRole("tooltip")).toHaveTextContent(
expect(screen.getByRole("dialog")).toHaveTextContent(
MockTemplateVersion.message,
),
);
@@ -1149,13 +1149,6 @@ export const StreamedReasoning: Story = {
],
},
},
play: async ({ canvasElement }) => {
const canvas = within(canvasElement);
await expect(
canvas.findByText("Streaming reasoning body"),
).resolves.toBeInTheDocument();
},
};
// NOTE: QueuedSendWithActiveStream and FailedSendWithActiveStream
@@ -31,7 +31,7 @@ export const OnCancel: Story = {
play: async ({ canvasElement, args }) => {
const user = userEvent.setup();
const body = within(canvasElement.ownerDocument.body);
const cancelButton = body.getByRole("button", { name: "Discard" });
const cancelButton = body.getByRole("button", { name: "Cancel" });
user.click(cancelButton);
await waitFor(() => {
expect(args.onClose).toHaveBeenCalledTimes(1);
+2 -2
View File
@@ -376,9 +376,9 @@ export const TaskPausedSnapshotTooltip: Story = {
const tooltipTrigger = await canvas.findByRole("button", {
name: /info/i,
});
await userEvent.hover(tooltipTrigger);
await userEvent.click(tooltipTrigger);
await waitFor(() =>
expect(screen.getByRole("tooltip")).toHaveTextContent(
expect(screen.getByRole("dialog")).toHaveTextContent(
/This log snapshot was taken/,
),
);
@@ -321,9 +321,9 @@ export const TemplateInfoPopover: Story = {
const canvas = within(canvasElement);
await step("activate hover trigger", async () => {
await userEvent.hover(canvas.getByText(baseWorkspace.name));
await userEvent.click(canvas.getByText(baseWorkspace.name));
await waitFor(() =>
expect(screen.getByRole("tooltip")).toHaveTextContent(
expect(screen.getByRole("dialog")).toHaveTextContent(
MockTemplate.display_name,
),
);
@@ -347,11 +347,9 @@ export const TemplateInfoPopoverWithoutDisplayName: Story = {
const canvas = within(canvasElement);
await step("activate hover trigger", async () => {
await userEvent.hover(canvas.getByText(baseWorkspace.name));
await userEvent.click(canvas.getByText(baseWorkspace.name));
await waitFor(() =>
expect(screen.getByRole("tooltip")).toHaveTextContent(
MockTemplate.name,
),
expect(screen.getByRole("dialog")).toHaveTextContent(MockTemplate.name),
);
});
},