opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-24 15:04:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: Remove quotes on GitSSH (#1043)

Browse Source
This commit is contained in:
Kyle Carberry
2022-04-18 15:12:39 -05:00
committed by GitHub
parent 6d948ffba2
commit e5a1c305d3
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
agent/agent.go
+1 -1
View File
@@ -237,7 +237,7 @@ func (a *agent) handleSSHSession(session ssh.Session) error {
if err != nil {
return xerrors.Errorf("getting os executable: %w", err)
}
cmd.Env = append(cmd.Env, fmt.Sprintf(`GIT_SSH_COMMAND="%s gitssh --"`, executablePath))
cmd.Env = append(cmd.Env, fmt.Sprintf(`GIT_SSH_COMMAND=%s gitssh --`, executablePath))
sshPty, windowSize, isPty := session.Pty()
if isPty {
agent/agent_test.go
+1 -1
View File
@@ -57,7 +57,7 @@ func TestAgent(t *testing.T) {
}
output, err := session.Output(command)
require.NoError(t, err)
require.Contains(t, string(output), "gitssh --")
require.True(t, strings.HasSuffix(strings.TrimSpace(string(output)), "gitssh --"))
})
t.Run("SessionTTY", func(t *testing.T) {