opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-24 15:04:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(site): await dialog close after publish to prevent act() warnings (#22334)

Browse Source 
State updates from setIsPublishingDialogOpen,
setLastSuccessfulPublishedVersion, and navigation were firing after
waitFor resolved, causing sporadic act() warnings and timeouts in the
publish template version tests (or so says Claude Sonnet 4.6).

Fixes coder/internal#1369

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Jeremy Ruppel
2026-02-27 08:59:22 -05:00
committed by GitHub
co-authored by Claude Sonnet 4.6
parent 173299fcec
commit dea451de41
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
site/src/pages/TemplateVersionEditorPage/TemplateVersionEditorPage.test.tsx
+12 -2
View File
@@ -147,9 +147,14 @@ test("Use custom name, message and set it as active when publishing", async () =
name: "v1.0",
message: "Informative message",
});
expect(updateActiveTemplateVersion).toBeCalledWith("test-template", {
id: "new-version-id",
});
});
expect(updateActiveTemplateVersion).toBeCalledWith("test-template", {
id: "new-version-id",
// Wait for the dialog to close so all async state updates (setIsPublishingDialogOpen,
// setLastSuccessfulPublishedVersion, navigation) settle before the test ends.
await waitFor(() => {
expect(screen.queryByTestId("dialog")).not.toBeInTheDocument();
});
});
@@ -195,6 +200,11 @@ test("Do not mark as active if promote is not checked", async () => {
});
});
expect(updateActiveTemplateVersion).toBeCalledTimes(0);
// Wait for the dialog to close so all async state updates settle before the
// test ends, preventing act() warnings from pending state mutations.
await waitFor(() => {
expect(screen.queryByTestId("dialog")).not.toBeInTheDocument();
});
});
test("Patch request is not send when there are no changes", async () => {