opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-22 05:05:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: extract checkbox label from dynamic parameter styling prop (#17651)

Browse Source 
resolves #17474 

A label will only be shown next to the checkbox If there is a value for
`label` in the styling prop for the dynamic parameter



<img width="457" alt="Screenshot 2025-05-01 at 21 35 32"
src="https://github.com/user-attachments/assets/3b3a8160-65a2-4411-b763-0d07a4eeb699"
/>
This commit is contained in:
Jaayden Halko
2025-05-08 08:02:27 -04:00
committed by GitHub
parent b6182fe054
commit c66e80e862
5 changed files with 17 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
go.mod
+1 -1
View File
@@ -488,7 +488,7 @@ require (
require (
github.com/anthropics/anthropic-sdk-go v0.2.0-beta.3
github.com/coder/preview v0.0.1
github.com/coder/preview v0.0.2-0.20250506154333-6f500ca7b245
github.com/fsnotify/fsnotify v1.9.0
github.com/kylecarbs/aisdk-go v0.0.8
github.com/mark3labs/mcp-go v0.25.0
go.sum
+2 -2
View File
@@ -907,8 +907,8 @@ github.com/coder/pq v1.10.5-0.20240813183442-0c420cb5a048 h1:3jzYUlGH7ZELIH4XggX
github.com/coder/pq v1.10.5-0.20240813183442-0c420cb5a048/go.mod h1:AlVN5x4E4T544tWzH6hKfbfQvm3HdbOxrmggDNAPY9o=
github.com/coder/pretty v0.0.0-20230908205945-e89ba86370e0 h1:3A0ES21Ke+FxEM8CXx9n47SZOKOpgSE1bbJzlE4qPVs=
github.com/coder/pretty v0.0.0-20230908205945-e89ba86370e0/go.mod h1:5UuS2Ts+nTToAMeOjNlnHFkPahrtDkmpydBen/3wgZc=
github.com/coder/preview v0.0.1 h1:2X5McKdMOZJILTIDf7qRplXKupT+91qTJBN67XUh5cA=
github.com/coder/preview v0.0.1/go.mod h1:eInDmOdSDF8cxCvapIvYkGRzmzvcvGAFL1HYqcA4g+E=
github.com/coder/preview v0.0.2-0.20250506154333-6f500ca7b245 h1:RGoANNubwwPZF8puiYAk2qbzhVgipBMNu8WIrY1VIbI=
github.com/coder/preview v0.0.2-0.20250506154333-6f500ca7b245/go.mod h1:5VnO9yw7vq19hBgBqqBksE2BH53UTmNYH1QltkYLXJI=
github.com/coder/quartz v0.1.2 h1:PVhc9sJimTdKd3VbygXtS4826EOCpB1fXoRlLnCrE+s=
github.com/coder/quartz v0.1.2/go.mod h1:vsiCc+AHViMKH2CQpGIpFgdHIEQsxwm8yCscqKmzbRA=
github.com/coder/retry v1.5.1 h1:iWu8YnD8YqHs3XwqrqsjoBTAVqT9ml6z9ViJ2wlMiqc=
site/src/api/typesGenerated.ts
Generated
+8 -2
View File
@@ -1796,8 +1796,7 @@ export interface PreviewParameterData {
readonly type: PreviewParameterType;
// this is likely an enum in an external package "github.com/coder/terraform-provider-coder/v2/provider.ParameterFormType"
readonly form_type: string;
// empty interface{} type, falling back to unknown
readonly styling: unknown;
readonly styling: PreviewParameterStyling;
readonly mutable: boolean;
readonly default_value: NullHCLString;
readonly icon: string;
@@ -1816,6 +1815,13 @@ export interface PreviewParameterOption {
readonly icon: string;
}
// From types/parameter.go
export interface PreviewParameterStyling {
readonly placeholder?: string;
readonly disabled?: boolean;
readonly label?: string;
}
// From types/enum.go
export type PreviewParameterType = string;
site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx
+5 -17
View File
@@ -181,10 +181,7 @@ const ParameterField: FC<ParameterFieldProps> = ({
>
<SelectTrigger>
<SelectValue
placeholder={
(parameter.styling as { placeholder?: string })?.placeholder ||
"Select option"
}
placeholder={parameter.styling?.placeholder || "Select option"}
/>
</SelectTrigger>
<SelectContent>
@@ -245,10 +242,7 @@ const ParameterField: FC<ParameterFieldProps> = ({
onChange(JSON.stringify(values));
}}
hidePlaceholderWhenSelected
placeholder={
(parameter.styling as { placeholder?: string })?.placeholder ||
"Select option"
}
placeholder={parameter.styling?.placeholder || "Select option"}
emptyIndicator={
<p className="text-center text-md text-content-primary">
No results found
@@ -304,9 +298,7 @@ const ParameterField: FC<ParameterFieldProps> = ({
}}
disabled={disabled}
/>
<Label htmlFor={parameter.name}>
{parameter.display_name || parameter.name}
</Label>
<Label htmlFor={parameter.name}>{parameter.styling?.label}</Label>
</div>
);
@@ -343,9 +335,7 @@ const ParameterField: FC<ParameterFieldProps> = ({
target.style.height = `${target.scrollHeight}px`;
}}
disabled={disabled}
placeholder={
(parameter.styling as { placeholder?: string })?.placeholder
}
placeholder={parameter.styling?.placeholder}
required={parameter.required}
/>
);
@@ -377,9 +367,7 @@ const ParameterField: FC<ParameterFieldProps> = ({
}}
disabled={disabled}
required={parameter.required}
placeholder={
(parameter.styling as { placeholder?: string })?.placeholder
}
placeholder={parameter.styling?.placeholder}
{...inputProps}
/>
);
site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx
+1 -2
View File
@@ -493,7 +493,6 @@ export const CreateWorkspacePageViewExperimental: FC<
<div className="flex flex-col gap-9">
{parameters.map((parameter, index) => {
const parameterField = `rich_parameter_values.${index}`;
const parameterInputName = `${parameterField}.value`;
const isPresetParameter = presetParameterNames.includes(
parameter.name,
);
@@ -501,7 +500,7 @@ export const CreateWorkspacePageViewExperimental: FC<
disabledParams?.includes(
parameter.name.toLowerCase().replace(/ /g, "_"),
) ||
(parameter.styling as { disabled?: boolean })?.disabled ||
parameter.styling?.disabled ||
creatingWorkspace ||
isPresetParameter;