opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-24 15:04:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

flake: verify parameters in parallel in e2e tests (#22557)

Browse Source 
This is an attempt to address coder/internal#1154

Tests appear to fail often on `verifyParameters`, which asserts input
visibility and value in series for all expected parameters. This change
makes the same assertions in parallel, hopefully completing before
timeout.
This commit is contained in:
Jeremy Ruppel
2026-03-03 14:56:41 -05:00
committed by GitHub
parent 6acdd6ca7d
commit b73f21662b
1 changed files with 54 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files
site/e2e/helpers.ts
+54 -45
View File
@@ -178,53 +178,62 @@ export const verifyParameters = async (
waitUntil: "networkidle",
});
for (const buildParameter of expectedBuildParameters) {
const richParameter = richParameters.find(
(richParam) => richParam.name === buildParameter.name,
);
if (!richParameter) {
throw new Error(
"build parameter is expected to be present in rich parameter schema",
);
}
const parameterLabel = page.getByTestId(
`parameter-field-${richParameter.displayName}`,
);
await expect(parameterLabel).toBeVisible();
if (richParameter.options.length > 0) {
const parameterValue = parameterLabel.getByLabel(buildParameter.value);
const value = await parameterValue.isChecked();
expect(value).toBe(true);
continue;
}
switch (richParameter.type) {
case "bool":
{
const parameterField = parameterLabel.locator("input");
const value = await parameterField.isChecked();
expect(value.toString()).toEqual(buildParameter.value);
await Promise.all(
expectedBuildParameters.map(
async (buildParameter: WorkspaceBuildParameter) => {
const richParameter = richParameters.find(
(richParam) => richParam.name === buildParameter.name,
);
if (!richParameter) {
throw new Error(
"build parameter is expected to be present in rich parameter schema",
);
}
break;
case "string":
case "number":
{
const parameterField = parameterLabel.locator("input");
// Dynamic parameters can hydrate after initial render with
// stale or empty values. Retry with a longer timeout to
// allow the page to settle.
await expect(parameterField).toHaveValue(buildParameter.value, {
timeout: 15_000,
});
const parameterLabel = page.getByTestId(
`parameter-field-${richParameter.displayName}`,
);
await expect(parameterLabel).toBeVisible({
timeout: 10_000,
});
if (richParameter.options.length > 0) {
const parameterValue = parameterLabel.getByLabel(
buildParameter.value,
);
const value = await parameterValue.isChecked();
expect(value).toBe(true);
return;
}
break;
default:
// Some types like `list(string)` are not tested
throw new Error("not implemented yet");
}
}
switch (richParameter.type) {
case "bool":
{
const parameterField = parameterLabel.locator("input");
const value = await parameterField.isChecked();
expect(value.toString()).toEqual(buildParameter.value);
}
break;
case "string":
case "number":
{
const parameterField = parameterLabel.locator("input").first();
// Dynamic parameters can hydrate after initial render with
// stale or empty values. Retry with a longer timeout to
// allow the page to settle.
await expect(parameterField).toHaveValue(buildParameter.value, {
timeout: 15_000,
});
}
break;
default:
// Some types like `list(string)` are not tested
throw new Error("not implemented yet");
}
},
),
);
};
/**