opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-21 12:44:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

test: index AI budget audit logs by action (#26630)

Browse Source 
Fixes
https://linear.app/codercom/issue/AIGOV-436/flake-testgroupaibudgetaudit
This commit is contained in:
Yevhenii Shcherbina
2026-06-23 13:57:21 -04:00
committed by GitHub
parent 24f97e86ad
commit a06e5a3698
1 changed files with 24 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
enterprise/coderd/aibridge_test.go
+24 -6
View File
@@ -45,6 +45,20 @@ func aibridgeOpts(t *testing.T) *coderdenttest.Options {
}
}
// auditLogsByAction indexes audit rows by their action so callers can assert
// on a specific entry without relying on row order, which GetAuditLogsOffset
// does not guarantee. It requires every action among the rows to be unique.
func auditLogsByAction(t *testing.T, rows []database.GetAuditLogsOffsetRow) map[database.AuditAction]database.AuditLog {
t.Helper()
byAction := make(map[database.AuditAction]database.AuditLog, len(rows))
for _, r := range rows {
_, dup := byAction[r.AuditLog.Action]
require.Falsef(t, dup, "duplicate audit action %q: helper assumes distinct actions", r.AuditLog.Action)
byAction[r.AuditLog.Action] = r.AuditLog
}
return byAction
}
func TestAIBridgeListSessions(t *testing.T) {
t.Parallel()
@@ -2261,9 +2275,11 @@ func TestGroupAIBudget(t *testing.T) {
)
require.NoError(t, err)
require.Len(t, rows, 2, "expected one upsert and one delete audit entry")
// GetAuditLogsOffset returns entries sorted by time in descending order.
upsertLog := rows[1].AuditLog
deleteLog := rows[0].AuditLog
// Match rows by action, not position. GetAuditLogsOffset does not
// guarantee row order.
byAction := auditLogsByAction(t, rows)
upsertLog := byAction[database.AuditActionWrite]
deleteLog := byAction[database.AuditActionDelete]
require.Equal(t, database.AuditActionWrite, upsertLog.Action)
require.Equal(t, group.ID, upsertLog.ResourceID)
@@ -2548,9 +2564,11 @@ func TestUserAIBudgetOverride(t *testing.T) {
)
require.NoError(t, err)
require.Len(t, rows, 2, "expected one upsert and one delete audit entry")
// GetAuditLogsOffset returns entries sorted by time in descending order.
upsertLog := rows[1].AuditLog
deleteLog := rows[0].AuditLog
// Match rows by action, not position. GetAuditLogsOffset does not
// guarantee row order.
byAction := auditLogsByAction(t, rows)
upsertLog := byAction[database.AuditActionWrite]
deleteLog := byAction[database.AuditActionDelete]
require.Equal(t, database.AuditActionWrite, upsertLog.Action)
require.Equal(t, targetUser.ID, upsertLog.ResourceID)