fix: remove double border <BuildParametersPopover /> (#22367)

This `<Popover />` had a double border on the bottom for some reason, I
believe there used to be multiple things within this previously but
there is no longer. All this does is simply tighten things up
ever-so-slightly.

| Old | New |
| --- | --- |
| <img width="321" height="209" alt="OLD_BUILD_OPTIONS"
src="https://github.com/user-attachments/assets/9eb3322d-5ac1-4d74-ab2a-39e963eae668"
/> | <img width="321" height="209" alt="NEW_BUILD_OPTIONS"
src="https://github.com/user-attachments/assets/f2200003-0fd5-4c90-8660-5424c3cf1807"
/> |
This commit is contained in:
Jake Howell
2026-02-27 22:14:55 +11:00
committed by GitHub
parent 9cce241202
commit 900f6ef576
@@ -1,4 +1,3 @@
import { useTheme } from "@emotion/react";
import { richParameters } from "api/queries/templates";
import { workspaceBuildParameters } from "api/queries/workspaceBuilds";
import type {
@@ -102,8 +101,6 @@ const BuildParametersPopoverContent: FC<BuildParametersPopoverContentProps> = ({
onSubmit,
setIsOpen,
}) => {
const theme = useTheme();
if (
!workspace.template_use_classic_parameter_flow &&
ephemeralParameters &&
@@ -149,19 +146,13 @@ const BuildParametersPopoverContent: FC<BuildParametersPopoverContentProps> = ({
{buildParameters && ephemeralParameters ? (
ephemeralParameters.length > 0 ? (
<>
<div
css={{
color: theme.palette.text.secondary,
padding: 20,
borderBottom: `1px solid ${theme.palette.divider}`,
}}
>
<div className="p-5 text-content-secondary">
<HelpTooltipTitle>Build Options</HelpTooltipTitle>
<HelpTooltipText>
These parameters only apply for a single workspace start.
</HelpTooltipText>
</div>
<div css={{ padding: 20 }}>
<div className="p-5">
<Form
onSubmit={(buildParameters) => {
onSubmit(buildParameters);
@@ -178,13 +169,7 @@ const BuildParametersPopoverContent: FC<BuildParametersPopoverContentProps> = ({
</div>
</>
) : (
<div
css={{
color: theme.palette.text.secondary,
padding: 20,
borderBottom: `1px solid ${theme.palette.divider}`,
}}
>
<div className="p-5 text-content-secondary">
<HelpTooltipTitle>Build Options</HelpTooltipTitle>
<HelpTooltipText>
This template has no ephemeral build options.
@@ -251,11 +236,11 @@ const Form: FC<FormProps> = ({
);
})}
</FormFields>
<div css={{ paddingTop: "24px", paddingBottom: "8px" }}>
<div className="pb-2 pt-6">
<Button
data-testid="build-parameters-submit"
type="submit"
css={{ width: "100%" }}
className="w-full"
>
Build workspace
</Button>