opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-21 20:51:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(site): roll back optimistic message when server queues it (#22522)

Browse Source 
## Problem

When a user sends a message while the agent is busy, the message appears
in the chat timeline as if it was sent and being processed (with the
"Thinking..." shimmer), instead of appearing in the queued messages list
above the input.

## Root Cause

`handleSend` in `AgentDetail.tsx` unconditionally injects an optimistic
user message into the conversation timeline and sets chat status to
`"pending"` **before** awaiting the server response. However, the server
can respond with `{ queued: true, queued_message: {...} }` (via
`CreateChatMessageResponse`) when the agent is already busy — meaning
the message was queued, not processed.

The client never inspected `response.queued` after the request
succeeded, so the optimistic message stayed in the timeline even though
the server queued it.

## Fix

After `sendMutation.mutateAsync(request)` resolves, check
`response.queued`. If true, roll back the optimistic message and restore
the previous chat status. The `queue_update` SSE event from the
WebSocket stream handles adding it to the queued messages list.

## Changes

- **`site/src/pages/AgentsPage/AgentDetail.tsx`**: Capture the response
from `sendMutation.mutateAsync` and roll back the optimistic message +
status when `response.queued === true`.
This commit is contained in:
Kyle Carberry
2026-03-02 16:31:12 -05:00
committed by GitHub
parent 5eebd3829f
commit 7e0895a1ee
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
site/src/pages/AgentsPage/AgentDetail.tsx
+10 -1
View File
@@ -718,7 +718,16 @@ const AgentDetail: FC = () => {
store.setChatStatus("pending");
try {
await sendMutation.mutateAsync(request);
const response = await sendMutation.mutateAsync(request);
if (response.queued) {
// The server queued the message instead of processing
// it immediately (the agent is already busy). Roll back
// the optimistic timeline message so it doesn't appear
// as a sent message. The queue_update SSE event will
// add it to the queued messages list.
store.replaceMessages(previousMessages);
store.setChatStatus(previousChatStatus);
}
} catch (error) {
// Roll back the optimistic message so the timeline
// returns to its previous state.