opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-24 15:04:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore(provisionersdk): ignore io.EOF in Session.requestReader (#18234)

Browse Source 
My understanding is that `io.EOF` is eventually expected, so logging it
as an error may be confusing. For other errors we should definitely
WARN.

```
[info]  provisionerd-ip-172-31-12-44-14: recv done on Session  session_id=22b9ef8a-9cd6-4188-98e0-573a50d724cc  error=EOF
```
This commit is contained in:
Cian Johnston
2025-06-06 09:05:22 +01:00
committed by GitHub
parent 08eff7f433
commit 7c2fb66181
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
provisionersdk/session.go
+5 -1
View File
@@ -100,7 +100,11 @@ func (s *Session) requestReader(done <-chan struct{}) <-chan *proto.Request {
for {
req, err := s.stream.Recv()
if err != nil {
s.Logger.Info(s.Context(), "recv done on Session", slog.Error(err))
if !xerrors.Is(err, io.EOF) {
s.Logger.Warn(s.Context(), "recv done on Session", slog.Error(err))
} else {
s.Logger.Info(s.Context(), "recv done on Session")
}
return
}
select {