opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-24 15:04:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: ui error handling should be specific to general (#14346)

Browse Source 
* chore: ui error handling should be specific to general

Specific errors should be checked before defaulting to a general
error handling
This commit is contained in:
Steven Masley
2024-08-19 13:28:43 -05:00
committed by GitHub
parent 422e044859
commit 755afa31cf
2 changed files with 18 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
site/src/api/errors.ts
+9 -6
View File
@@ -115,18 +115,21 @@ export const getErrorDetail = (error: unknown): string | undefined => {
return error.detail;
}
if (error instanceof Error) {
return "Please check the developer console for more details.";
}
if (isApiError(error)) {
// APIErrors that are empty still benefit from checking the developer
// console if no detail is provided. So only use the detail field if
// it is not empty.
if (isApiError(error) && error.response.data.detail) {
return error.response.data.detail;
}
if (isApiErrorResponse(error)) {
if (isApiErrorResponse(error) && error.detail) {
return error.detail;
}
if (error instanceof Error) {
return "Please check the developer console for more details.";
}
return undefined;
};
site/src/components/Alert/ErrorAlert.stories.tsx
+9
View File
@@ -34,6 +34,15 @@ export const WithOnlyMessage: Story = {
},
};
export const APIErrorWithDetail: Story = {
args: {
error: mockApiError({
message: "Magic dust is missing",
detail: "without magic dust, the requested operation will never work",
}),
},
};
export const WithDismiss: Story = {
args: {
dismissible: true,