opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-22 05:05:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(site): avoid showing disabled fields in group settings page (#9154)

Browse Source 
Previously we allowed interaction with the icon setter and showed
confusing help text under the disabled "Display Name" field.
This commit is contained in:
Ammar Bandukwala
2023-08-17 14:21:36 -05:00
committed by GitHub
parent 2f6687a475
commit 720ad9a653
1 changed files with 25 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
site/src/pages/GroupsPage/SettingsGroupPageView.tsx
+25 -19
View File
@@ -57,27 +57,33 @@ const UpdateGroupForm: FC<{
autoFocus
fullWidth
label="Name"
disabled={group.id === group.organization_id}
/>
<TextField
{...getFieldHelpers(
"display_name",
"Optional: keep empty to default to the name.",
)}
onChange={onChangeTrimmed(form)}
autoComplete="display_name"
autoFocus
fullWidth
label="Display Name"
disabled={isEveryoneGroup(group)}
/>
<LazyIconField
{...getFieldHelpers("avatar_url")}
onChange={onChangeTrimmed(form)}
fullWidth
label={t("form.fields.icon")}
onPickEmoji={(value) => form.setFieldValue("avatar_url", value)}
/>
{isEveryoneGroup(group) ? (
<></>
) : (
<>
<TextField
{...getFieldHelpers(
"display_name",
"Optional: keep empty to default to the name.",
)}
onChange={onChangeTrimmed(form)}
autoComplete="display_name"
autoFocus
fullWidth
label="Display Name"
disabled={isEveryoneGroup(group)}
/>
<LazyIconField
{...getFieldHelpers("avatar_url")}
onChange={onChangeTrimmed(form)}
fullWidth
label={t("form.fields.icon")}
onPickEmoji={(value) => form.setFieldValue("avatar_url", value)}
/>
</>
)}
<TextField
{...getFieldHelpers(
"quota_allowance",