mirror of
https://github.com/coder/coder.git
synced 2026-09-24 15:04:27 +08:00
fix(site): fix orphan values on insights (#10036)
This commit is contained in:
@@ -162,6 +162,11 @@ export const Loaded: Story = {
|
||||
value: "us-west2-a",
|
||||
count: 1,
|
||||
},
|
||||
// Test orphan values
|
||||
{
|
||||
value: "us-west-orphan",
|
||||
count: 1,
|
||||
},
|
||||
],
|
||||
},
|
||||
{
|
||||
|
||||
@@ -436,6 +436,7 @@ const TemplateParametersUsagePanel = ({
|
||||
</ParameterUsageRow>
|
||||
{parameter.values
|
||||
.sort((a, b) => b.count - a.count)
|
||||
.filter((usage) => filterOrphanValues(usage, parameter))
|
||||
.map((usage, usageIndex) => (
|
||||
<ParameterUsageRow
|
||||
key={`${parameterIndex}-${usageIndex}`}
|
||||
@@ -456,6 +457,16 @@ const TemplateParametersUsagePanel = ({
|
||||
);
|
||||
};
|
||||
|
||||
const filterOrphanValues = (
|
||||
usage: TemplateParameterValue,
|
||||
parameter: TemplateParameterUsage,
|
||||
) => {
|
||||
if (parameter.options) {
|
||||
return parameter.options.some((o) => o.value === usage.value);
|
||||
}
|
||||
return true;
|
||||
};
|
||||
|
||||
const ParameterUsageRow = styled(Box)(({ theme }) => ({
|
||||
display: "flex",
|
||||
alignItems: "baseline",
|
||||
|
||||
Reference in New Issue
Block a user