fix(site): fix orphan values on insights (#10036)

This commit is contained in:
Bruno Quaresma
2023-10-04 10:16:59 -03:00
committed by GitHub
parent 2405bbe1b9
commit 5e0cb372b4
2 changed files with 16 additions and 0 deletions
@@ -162,6 +162,11 @@ export const Loaded: Story = {
value: "us-west2-a",
count: 1,
},
// Test orphan values
{
value: "us-west-orphan",
count: 1,
},
],
},
{
@@ -436,6 +436,7 @@ const TemplateParametersUsagePanel = ({
</ParameterUsageRow>
{parameter.values
.sort((a, b) => b.count - a.count)
.filter((usage) => filterOrphanValues(usage, parameter))
.map((usage, usageIndex) => (
<ParameterUsageRow
key={`${parameterIndex}-${usageIndex}`}
@@ -456,6 +457,16 @@ const TemplateParametersUsagePanel = ({
);
};
const filterOrphanValues = (
usage: TemplateParameterValue,
parameter: TemplateParameterUsage,
) => {
if (parameter.options) {
return parameter.options.some((o) => o.value === usage.value);
}
return true;
};
const ParameterUsageRow = styled(Box)(({ theme }) => ({
display: "flex",
alignItems: "baseline",