mirror of
https://github.com/coder/coder.git
synced 2026-09-22 05:05:20 +08:00
fix: Parse CODER_GITAUTH_N_NO_REFRESH env var value instead of key (#7051)
This commit is contained in:
+1
-1
@@ -145,7 +145,7 @@ func ReadGitAuthProvidersFromEnv(environ []string) ([]codersdk.GitAuthConfig, er
|
||||
case "REGEX":
|
||||
provider.Regex = v.Value
|
||||
case "NO_REFRESH":
|
||||
b, err := strconv.ParseBool(key)
|
||||
b, err := strconv.ParseBool(v.Value)
|
||||
if err != nil {
|
||||
return nil, xerrors.Errorf("parse bool: %s", v.Value)
|
||||
}
|
||||
|
||||
@@ -84,6 +84,7 @@ func TestReadGitAuthProvidersFromEnv(t *testing.T) {
|
||||
"CODER_GITAUTH_1_TOKEN_URL=google.com",
|
||||
"CODER_GITAUTH_1_VALIDATE_URL=bing.com",
|
||||
"CODER_GITAUTH_1_SCOPES=repo:read repo:write",
|
||||
"CODER_GITAUTH_1_NO_REFRESH=true",
|
||||
})
|
||||
require.NoError(t, err)
|
||||
require.Len(t, providers, 2)
|
||||
@@ -99,6 +100,7 @@ func TestReadGitAuthProvidersFromEnv(t *testing.T) {
|
||||
assert.Equal(t, "google.com", providers[1].TokenURL)
|
||||
assert.Equal(t, "bing.com", providers[1].ValidateURL)
|
||||
assert.Equal(t, []string{"repo:read", "repo:write"}, providers[1].Scopes)
|
||||
assert.Equal(t, true, providers[1].NoRefresh)
|
||||
})
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user