opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-24 15:04:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

test: fix TestUserAIBudgetOverride audit flake (#27013)

Browse Source 
Closes
https://linear.app/codercom/issue/AIGOV-502/flake-testuseraibudgetoverrideauditupsertspendlimit

The `Audit/UpsertEverything` and `Audit/UpsertSpendLimit` subtests
grabbed `rows[0]` from `GetAuditLogsOffset`, assuming strict time-desc
order. Both upserts emit `AuditActionWrite` against the same override
with no ordering tiebreaker, so when the create and update entries share
a timestamp the create entry could sort first and fail the assertion.

Select the update entry by the spend limit it results in via a new
`auditLogByNewSpendLimit` helper instead of by row position.

<hr/>

We could make `auditLogByNewSpendLimit` more generic, but since we don't
have any other use cases for it right now, I think we can postpone that
until the need arises.

Related PR: https://github.com/coder/coder/pull/26630/changes
This commit is contained in:
Yevhenii Shcherbina
2026-07-06 14:18:02 -04:00
committed by GitHub
parent 96130e2bc5
commit 2ec7f5c69b
1 changed files with 26 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
enterprise/coderd/aibridge_test.go
+26 -4
View File
@@ -59,6 +59,24 @@ func auditLogsByAction(t *testing.T, rows []database.GetAuditLogsOffsetRow) map[
return byAction
}
// auditLogByNewSpendLimit selects the audit row whose diff sets spend_limit to
// the given value so callers can assert on a specific entry without relying on
// row order, which GetAuditLogsOffset does not guarantee. It requires the
// resulting spend_limit among the rows to be unique.
func auditLogByNewSpendLimit(t *testing.T, rows []database.GetAuditLogsOffsetRow, newSpendLimit string) database.AuditLog {
t.Helper()
var matches []database.AuditLog
for _, r := range rows {
var diff audit.Map
require.NoError(t, json.Unmarshal(r.AuditLog.Diff, &diff))
if field, ok := diff["spend_limit"]; ok && field.New == newSpendLimit {
matches = append(matches, r.AuditLog)
}
}
require.Lenf(t, matches, 1, "want exactly one audit entry setting spend_limit to %q, got %d", newSpendLimit, len(matches))
return matches[0]
}
func TestAIBridgeListSessions(t *testing.T) {
t.Parallel()
@@ -2687,8 +2705,10 @@ func TestUserAIBudgetOverride(t *testing.T) {
)
require.NoError(t, err)
require.Len(t, rows, 2, "expected one create and one update audit entry")
// GetAuditLogsOffset returns entries sorted by time in descending order.
updateLog := rows[0].AuditLog
// Both upserts emit AuditActionWrite; select the update by the spend
// limit it results in rather than row order, which GetAuditLogsOffset
// does not guarantee.
updateLog := auditLogByNewSpendLimit(t, rows, "$1000.00")
var updateDiff audit.Map
require.NoError(t, json.Unmarshal(updateLog.Diff, &updateDiff))
@@ -2744,8 +2764,10 @@ func TestUserAIBudgetOverride(t *testing.T) {
)
require.NoError(t, err)
require.Len(t, rows, 2, "expected one create and one update audit entry")
// GetAuditLogsOffset returns entries sorted by time in descending order.
updateLog := rows[0].AuditLog
// Both upserts emit AuditActionWrite; select the update by the spend
// limit it results in rather than row order, which GetAuditLogsOffset
// does not guarantee.
updateLog := auditLogByNewSpendLimit(t, rows, "$1000.00")
var updateDiff audit.Map
require.NoError(t, json.Unmarshal(updateLog.Diff, &updateDiff))