opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-24 15:04:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(site): compute selected model as derived state in AgentDetail (#22816)

Browse Source
This commit is contained in:
Danielle Maywood
2026-03-09 14:57:55 +00:00
committed by GitHub
parent b33b8e476b
commit 26adc26a26
1 changed files with 22 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
site/src/pages/AgentsPage/AgentDetail.tsx
+22 -16
View File
@@ -753,20 +753,24 @@ const AgentDetail: FC = () => {
// Extract PR number from diff status URL.
const prMatch = diffStatusQuery.data?.url?.match(/\/pull\/(\d+)/)?.[1];
const prNumber = prMatch ? Number(prMatch) : undefined;
useEffect(() => {
setSelectedModel((current) => {
if (current && modelOptions.some((model) => model.id === current)) {
return current;
// Compute an effective selected model by validating the user's
// explicit choice against the current model options, falling
// back to the chat's last model or the first available option.
const effectiveSelectedModel = useMemo(() => {
if (
selectedModel &&
modelOptions.some((model) => model.id === selectedModel)
) {
return selectedModel;
}
if (chatLastModelConfigID) {
const fromChat = modelIDByConfigID.get(chatLastModelConfigID);
if (fromChat && modelOptions.some((model) => model.id === fromChat)) {
return fromChat;
}
if (chatLastModelConfigID) {
const fromChat = modelIDByConfigID.get(chatLastModelConfigID);
if (fromChat && modelOptions.some((model) => model.id === fromChat)) {
return fromChat;
}
}
return modelOptions[0]?.id ?? "";
});
}, [chatLastModelConfigID, modelIDByConfigID, modelOptions]);
}
return modelOptions[0]?.id ?? "";
}, [selectedModel, chatLastModelConfigID, modelIDByConfigID, modelOptions]);
const compressionThreshold = useMemo(() => {
if (!chatLastModelConfigID) {
@@ -874,7 +878,9 @@ const AgentDetail: FC = () => {
return;
}
const selectedModelConfigID =
(selectedModel && modelConfigIDByModelID.get(selectedModel)) || undefined;
(effectiveSelectedModel &&
modelConfigIDByModelID.get(effectiveSelectedModel)) ||
undefined;
const request: TypesGen.CreateChatMessageRequest = {
content,
model_config_id: selectedModelConfigID,
@@ -1117,7 +1123,7 @@ const AgentDetail: FC = () => {
initialValue=""
isDisabled={isInputDisabled}
isLoading={false}
selectedModel={selectedModel}
selectedModel={effectiveSelectedModel}
onModelChange={setSelectedModel}
modelOptions={modelOptions}
modelSelectorPlaceholder={modelSelectorPlaceholder}
@@ -1247,7 +1253,7 @@ const AgentDetail: FC = () => {
isSendPending={isSubmissionPending}
isInterruptPending={interruptMutation.isPending}
hasModelOptions={hasModelOptions}
selectedModel={selectedModel}
selectedModel={effectiveSelectedModel}
onModelChange={setSelectedModel}
modelOptions={modelOptions}
modelSelectorPlaceholder={modelSelectorPlaceholder}