mirror of
https://github.com/coder/coder.git
synced 2026-11-19 18:51:12 +08:00
chore: improve variable names of mocked users (#17701)
Many times I got confused when using MockUser and MockUser2 so I just decided to better naming them to MockUserOwner and MockUserMember.
This commit is contained in:
@@ -6,8 +6,8 @@ import {
|
||||
MockPrimaryWorkspaceProxy,
|
||||
MockProxyLatencies,
|
||||
MockSupportLinks,
|
||||
MockUser,
|
||||
MockUser2,
|
||||
MockUserMember,
|
||||
MockUserOwner,
|
||||
MockWorkspaceProxies,
|
||||
} from "testHelpers/entities";
|
||||
import { MobileMenu } from "./MobileMenu";
|
||||
@@ -36,7 +36,7 @@ const meta: Meta<typeof MobileMenu> = {
|
||||
proxyLatencies: MockProxyLatencies,
|
||||
proxies: MockWorkspaceProxies,
|
||||
},
|
||||
user: MockUser,
|
||||
user: MockUserOwner,
|
||||
supportLinks: MockSupportLinks,
|
||||
onSignOut: fn(),
|
||||
isDefaultOpen: true,
|
||||
@@ -63,7 +63,7 @@ export const Admin: Story = {
|
||||
|
||||
export const Auditor: Story = {
|
||||
args: {
|
||||
user: MockUser2,
|
||||
user: MockUserMember,
|
||||
canViewAuditLog: true,
|
||||
canViewDeployment: false,
|
||||
canViewHealth: false,
|
||||
@@ -74,7 +74,7 @@ export const Auditor: Story = {
|
||||
|
||||
export const OrgAdmin: Story = {
|
||||
args: {
|
||||
user: MockUser2,
|
||||
user: MockUserMember,
|
||||
canViewAuditLog: true,
|
||||
canViewDeployment: false,
|
||||
canViewHealth: false,
|
||||
@@ -85,7 +85,7 @@ export const OrgAdmin: Story = {
|
||||
|
||||
export const Member: Story = {
|
||||
args: {
|
||||
user: MockUser2,
|
||||
user: MockUserMember,
|
||||
canViewAuditLog: false,
|
||||
canViewDeployment: false,
|
||||
canViewHealth: false,
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
import type { Meta, StoryObj } from "@storybook/react";
|
||||
import { userEvent, within } from "@storybook/test";
|
||||
import { chromaticWithTablet } from "testHelpers/chromatic";
|
||||
import { MockUser, MockUser2 } from "testHelpers/entities";
|
||||
import { MockUserMember, MockUserOwner } from "testHelpers/entities";
|
||||
import { withDashboardProvider } from "testHelpers/storybook";
|
||||
import { NavbarView } from "./NavbarView";
|
||||
|
||||
@@ -10,7 +10,7 @@ const meta: Meta<typeof NavbarView> = {
|
||||
parameters: { chromatic: chromaticWithTablet, layout: "fullscreen" },
|
||||
component: NavbarView,
|
||||
args: {
|
||||
user: MockUser,
|
||||
user: MockUserOwner,
|
||||
canViewAuditLog: true,
|
||||
canViewDeployment: true,
|
||||
canViewHealth: true,
|
||||
@@ -33,7 +33,7 @@ export const ForAdmin: Story = {
|
||||
|
||||
export const ForAuditor: Story = {
|
||||
args: {
|
||||
user: MockUser2,
|
||||
user: MockUserMember,
|
||||
canViewAuditLog: true,
|
||||
canViewDeployment: false,
|
||||
canViewHealth: false,
|
||||
@@ -49,7 +49,7 @@ export const ForAuditor: Story = {
|
||||
|
||||
export const ForOrgAdmin: Story = {
|
||||
args: {
|
||||
user: MockUser2,
|
||||
user: MockUserMember,
|
||||
canViewAuditLog: true,
|
||||
canViewDeployment: false,
|
||||
canViewHealth: false,
|
||||
@@ -65,7 +65,7 @@ export const ForOrgAdmin: Story = {
|
||||
|
||||
export const ForMember: Story = {
|
||||
args: {
|
||||
user: MockUser2,
|
||||
user: MockUserMember,
|
||||
canViewAuditLog: false,
|
||||
canViewDeployment: false,
|
||||
canViewHealth: false,
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
import { screen } from "@testing-library/react";
|
||||
import userEvent from "@testing-library/user-event";
|
||||
import type { ProxyContextValue } from "contexts/ProxyContext";
|
||||
import { MockPrimaryWorkspaceProxy, MockUser } from "testHelpers/entities";
|
||||
import { MockPrimaryWorkspaceProxy, MockUserOwner } from "testHelpers/entities";
|
||||
import { renderWithAuth } from "testHelpers/renderHelpers";
|
||||
import { NavbarView } from "./NavbarView";
|
||||
|
||||
@@ -26,7 +26,7 @@ describe("NavbarView", () => {
|
||||
renderWithAuth(
|
||||
<NavbarView
|
||||
proxyContextValue={proxyContextValue}
|
||||
user={MockUser}
|
||||
user={MockUserOwner}
|
||||
onSignOut={noop}
|
||||
canViewDeployment
|
||||
canViewOrganizations
|
||||
@@ -43,7 +43,7 @@ describe("NavbarView", () => {
|
||||
renderWithAuth(
|
||||
<NavbarView
|
||||
proxyContextValue={proxyContextValue}
|
||||
user={MockUser}
|
||||
user={MockUserOwner}
|
||||
onSignOut={noop}
|
||||
canViewDeployment
|
||||
canViewOrganizations
|
||||
@@ -60,7 +60,7 @@ describe("NavbarView", () => {
|
||||
renderWithAuth(
|
||||
<NavbarView
|
||||
proxyContextValue={proxyContextValue}
|
||||
user={MockUser}
|
||||
user={MockUserOwner}
|
||||
onSignOut={noop}
|
||||
canViewDeployment
|
||||
canViewOrganizations
|
||||
@@ -78,7 +78,7 @@ describe("NavbarView", () => {
|
||||
renderWithAuth(
|
||||
<NavbarView
|
||||
proxyContextValue={proxyContextValue}
|
||||
user={MockUser}
|
||||
user={MockUserOwner}
|
||||
onSignOut={noop}
|
||||
canViewDeployment
|
||||
canViewOrganizations
|
||||
|
||||
@@ -8,7 +8,7 @@ import {
|
||||
MockAuthMethodsAll,
|
||||
MockPermissions,
|
||||
MockProxyLatencies,
|
||||
MockUser,
|
||||
MockUserOwner,
|
||||
MockWorkspaceProxies,
|
||||
} from "testHelpers/entities";
|
||||
import { withDesktopViewport } from "testHelpers/storybook";
|
||||
@@ -41,7 +41,7 @@ const meta: Meta<typeof ProxyMenu> = {
|
||||
],
|
||||
parameters: {
|
||||
queries: [
|
||||
{ key: ["me"], data: MockUser },
|
||||
{ key: ["me"], data: MockUserOwner },
|
||||
{ key: ["authMethods"], data: MockAuthMethodsAll },
|
||||
{ key: ["hasFirstUser"], data: true },
|
||||
{
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
import type { Meta, StoryObj } from "@storybook/react";
|
||||
import { expect, screen, userEvent, waitFor, within } from "@storybook/test";
|
||||
import { MockBuildInfo, MockUser } from "testHelpers/entities";
|
||||
import { MockBuildInfo, MockUserOwner } from "testHelpers/entities";
|
||||
import { withDashboardProvider } from "testHelpers/storybook";
|
||||
import { UserDropdown } from "./UserDropdown";
|
||||
|
||||
@@ -8,7 +8,7 @@ const meta: Meta<typeof UserDropdown> = {
|
||||
title: "modules/dashboard/UserDropdown",
|
||||
component: UserDropdown,
|
||||
args: {
|
||||
user: MockUser,
|
||||
user: MockUserOwner,
|
||||
buildInfo: MockBuildInfo,
|
||||
supportLinks: [
|
||||
{ icon: "docs", name: "Documentation", target: "" },
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
import { screen } from "@testing-library/react";
|
||||
import { Popover } from "components/deprecated/Popover/Popover";
|
||||
import { MockUser } from "testHelpers/entities";
|
||||
import { MockUserOwner } from "testHelpers/entities";
|
||||
import { render, waitForLoaderToBeRemoved } from "testHelpers/renderHelpers";
|
||||
import { Language, UserDropdownContent } from "./UserDropdownContent";
|
||||
|
||||
@@ -8,7 +8,7 @@ describe("UserDropdownContent", () => {
|
||||
it("has the correct link for the account item", async () => {
|
||||
render(
|
||||
<Popover>
|
||||
<UserDropdownContent user={MockUser} onSignOut={jest.fn()} />
|
||||
<UserDropdownContent user={MockUserOwner} onSignOut={jest.fn()} />
|
||||
</Popover>,
|
||||
);
|
||||
await waitForLoaderToBeRemoved();
|
||||
@@ -25,7 +25,7 @@ describe("UserDropdownContent", () => {
|
||||
const onSignOut = jest.fn();
|
||||
render(
|
||||
<Popover>
|
||||
<UserDropdownContent user={MockUser} onSignOut={onSignOut} />
|
||||
<UserDropdownContent user={MockUserOwner} onSignOut={onSignOut} />
|
||||
</Popover>,
|
||||
);
|
||||
await waitForLoaderToBeRemoved();
|
||||
|
||||
Reference in New Issue
Block a user