opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-24 15:04:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(site): use correct /api/experimental endpoint for PR insights (#23235)

Browse Source 
## Problem

The `/agents/settings/insights` page was broken because
`InsightsContent` was calling `/api/v2/chats/insights/pull-requests`,
but the backend route is registered under
`/api/experimental/chats/insights/pull-requests` (the entire `/chats`
route block lives under `r.Route("/api/experimental", ...)` in
`coderd.go`).

Every other chat endpoint in the frontend correctly uses
`/api/experimental/chats/...`, but this one was missed.

## Fix

- Added `getPRInsights` method to the API client (`api.ts`) pointing to
`/api/experimental/chats/insights/pull-requests`
- Added a `prInsights` react-query helper in `api/queries/chats.ts`
(matching the pattern of `chatCostUsers`, etc.)
- Updated `InsightsContent.tsx` to use the query helper instead of a raw
`fetch()` with the wrong URL
This commit is contained in:
Kyle Carberry
2026-03-18 16:46:53 +00:00
committed by GitHub
parent 119030d795
commit 2577d16af2
4 changed files with 54 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files
site/src/api/api.ts
+12
View File
@@ -3209,6 +3209,18 @@ class ApiMethods {
return response.data;
};
getPRInsights = async (params?: {
start_date?: string;
end_date?: string;
}): Promise<TypesGen.PRInsightsResponse> => {
const url = getURLWithSearchParams(
"/api/experimental/chats/insights/pull-requests",
params,
);
const response = await this.axios.get<TypesGen.PRInsightsResponse>(url);
return response.data;
};
getChatUsageLimitConfig =
async (): Promise<TypesGen.ChatUsageLimitConfigResponse> => {
const response =
site/src/api/queries/chats.ts
+12
View File
@@ -547,6 +547,18 @@ export const chatCostUsers = (params?: ChatCostUsersParams) => ({
staleTime: 60_000,
});
const prInsightsKey = (params?: { start_date?: string; end_date?: string }) =>
[...chatsKey, "prInsights", params] as const;
export const prInsights = (params?: {
start_date?: string;
end_date?: string;
}) => ({
queryKey: prInsightsKey(params),
queryFn: () => API.getPRInsights(params),
staleTime: 60_000,
});
const chatUsageLimitConfigKey = [...chatsKey, "usageLimitConfig"] as const;
export const chatUsageLimitConfig = () => ({
site/src/pages/AgentsPage/InsightsContent.tsx
+2 -22
View File
@@ -1,4 +1,4 @@
import type { PRInsightsResponse } from "api/typesGenerated";
import { prInsights } from "api/queries/chats";
import { Spinner } from "components/Spinner/Spinner";
import dayjs from "dayjs";
import { type FC, useCallback, useMemo, useState } from "react";
@@ -15,31 +15,11 @@ function timeRangeToDates(range: PRInsightsTimeRange) {
};
}
async function fetchPRInsights(
startDate: string,
endDate: string,
): Promise<PRInsightsResponse> {
const params = new URLSearchParams({
start_date: startDate,
end_date: endDate,
});
const resp = await fetch(
`/api/v2/chats/insights/pull-requests?${params.toString()}`,
);
if (!resp.ok) {
throw new Error(`Failed to fetch PR insights: ${resp.statusText}`);
}
return resp.json();
}
export const InsightsContent: FC = () => {
const [timeRange, setTimeRange] = useState<PRInsightsTimeRange>("30d");
const dates = useMemo(() => timeRangeToDates(timeRange), [timeRange]);
const { data, isLoading, error } = useQuery({
queryKey: ["prInsights", dates.start_date, dates.end_date],
queryFn: () => fetchPRInsights(dates.start_date, dates.end_date),
});
const { data, isLoading, error } = useQuery(prInsights(dates));
const handleTimeRangeChange = useCallback(
(range: PRInsightsTimeRange) => setTimeRange(range),
site/src/pages/AgentsPage/PRInsightsView.stories.tsx
+28 -13
View File
@@ -10,19 +10,30 @@ import { type PRInsightsTimeRange, PRInsightsView } from "./PRInsightsView";
const NOW = dayjs("2025-07-15");
// Deterministic PRNG so story snapshots are stable across runs.
function seededRandom(seed: number) {
let s = seed;
return () => {
s = (s * 16807) % 2147483647;
return (s - 1) / 2147483646;
};
}
function generateTimeSeries(
days: number,
opts: { avgCreated: number; avgMerged: number; avgClosed?: number },
seed = 42,
): TypesGen.PRInsightsTimeSeriesEntry[] {
const rand = seededRandom(seed);
const entries: TypesGen.PRInsightsTimeSeriesEntry[] = [];
for (let i = days - 1; i >= 0; i--) {
const date = NOW.subtract(i, "day").format("YYYY-MM-DD");
const jitter = () => Math.round((Math.random() - 0.3) * 3);
const jitter = () => Math.round((rand() - 0.3) * 3);
const created = Math.max(0, opts.avgCreated + jitter());
const merged = Math.min(created, Math.max(0, opts.avgMerged + jitter()));
const closed = Math.max(
0,
(opts.avgClosed ?? 0) + Math.round((Math.random() - 0.5) * 2),
(opts.avgClosed ?? 0) + Math.round((rand() - 0.5) * 2),
);
entries.push({
date,
@@ -134,7 +145,11 @@ const AUTHORS = [
},
];
function generatePRs(count: number): TypesGen.PRInsightsPullRequest[] {
function generatePRs(
count: number,
seed = 100,
): TypesGen.PRInsightsPullRequest[] {
const rand = seededRandom(seed);
const states: Array<"open" | "closed" | "merged"> = [
"merged",
"merged",
@@ -155,8 +170,8 @@ function generatePRs(count: number): TypesGen.PRInsightsPullRequest[] {
return Array.from({ length: count }, (_, i) => {
const state = states[i % states.length];
const author = AUTHORS[i % AUTHORS.length];
const additions = Math.round(40 + Math.random() * 400);
const deletions = Math.round(10 + Math.random() * 150);
const additions = Math.round(40 + rand() * 400);
const deletions = Math.round(10 + rand() * 150);
return {
chat_id: `chat-${i}`,
@@ -167,22 +182,22 @@ function generatePRs(count: number): TypesGen.PRInsightsPullRequest[] {
draft: state === "open" && i % 3 === 0,
additions,
deletions,
changed_files: Math.round(2 + Math.random() * 12),
commits: Math.round(1 + Math.random() * 6),
changed_files: Math.round(2 + rand() * 12),
commits: Math.round(1 + rand() * 6),
approved:
state === "merged" ? true : state === "open" ? undefined : false,
changes_requested: state === "closed" && i % 2 === 0,
reviewer_count:
state === "merged"
? Math.round(1 + Math.random() * 2)
: Math.round(Math.random() * 2),
? Math.round(1 + rand() * 2)
: Math.round(rand() * 2),
author_login: author.login,
author_avatar_url: author.avatar,
base_branch: "main",
model_display_name: models[i % models.length],
cost_micros: Math.round(1_500_000 + Math.random() * 8_000_000),
cost_micros: Math.round(1_500_000 + rand() * 8_000_000),
created_at: NOW.subtract(
i * 4 + Math.round(Math.random() * 8),
i * 4 + Math.round(rand() * 8),
"hour",
).toISOString(),
};
@@ -262,11 +277,11 @@ const lowVolumeData: TypesGen.PRInsightsResponse = {
prev_cost_per_merged_pr_micros: 4_200_000,
},
time_series: generateTimeSeries(30, { avgCreated: 0, avgMerged: 0 }),
by_model: MODELS.slice(0, 2).map((m) => ({
by_model: MODELS.slice(0, 2).map((m, i) => ({
...m,
total_prs: Math.round(m.total_prs / 6),
merged_prs: Math.round(m.merged_prs / 8),
merge_rate: 0.35 + Math.random() * 0.15,
merge_rate: 0.35 + i * 0.07,
})),
recent_prs: generatePRs(5),
};