mirror of
https://github.com/coder/coder.git
synced 2026-09-24 06:47:27 +08:00
fix: show task display name in task topbar (#20957)
## Description Update task topbar in task page to show display name, instead of task name. Follow-up PR: https://github.com/coder/coder/pull/20918 Related to internal slack thread: https://codercom.slack.com/archives/C0992H8HGCS/p1764086497375829
This commit is contained in:
@@ -1,5 +1,6 @@
|
||||
import {
|
||||
MockDeletedWorkspace,
|
||||
MockDisplayNameTasks,
|
||||
MockFailedWorkspace,
|
||||
MockStartingWorkspace,
|
||||
MockStoppedWorkspace,
|
||||
@@ -561,6 +562,38 @@ export const WorkspaceStartFailureWithDialog: Story = {
|
||||
},
|
||||
};
|
||||
|
||||
const longDisplayName =
|
||||
"Implement comprehensive authentication and authorization system with role-based access control";
|
||||
export const LongDisplayName: Story = {
|
||||
parameters: {
|
||||
queries: [
|
||||
{
|
||||
// Sidebar: uses getTasks() which returns an array
|
||||
key: ["tasks", { owner: MockTask.owner_name }],
|
||||
data: [
|
||||
{ ...MockDisplayNameTasks[0], display_name: longDisplayName },
|
||||
...MockDisplayNameTasks.slice(1),
|
||||
],
|
||||
},
|
||||
{
|
||||
// TaskTopbar: uses getTask() which returns a single task
|
||||
key: ["tasks", MockTask.owner_name, MockTask.id],
|
||||
data: { ...MockDisplayNameTasks[0], display_name: longDisplayName },
|
||||
},
|
||||
{
|
||||
// Workspace data for the task
|
||||
key: [
|
||||
"workspace",
|
||||
MockTask.owner_name,
|
||||
MockTask.workspace_name,
|
||||
"settings",
|
||||
],
|
||||
data: MockWorkspace,
|
||||
},
|
||||
],
|
||||
},
|
||||
};
|
||||
|
||||
function mockTaskWithWorkspace(
|
||||
sidebarApp: WorkspaceApp,
|
||||
activeApp: WorkspaceApp,
|
||||
|
||||
@@ -23,7 +23,7 @@ type TaskTopbarProps = { task: Task; workspace: Workspace };
|
||||
|
||||
export const TaskTopbar: FC<TaskTopbarProps> = ({ task, workspace }) => {
|
||||
return (
|
||||
<header className="flex flex-shrink-0 items-center p-3 border-solid border-border border-0 border-b">
|
||||
<header className="flex flex-shrink-0 items-center gap-2 p-3 border-solid border-border border-0 border-b">
|
||||
<TooltipProvider>
|
||||
<Tooltip>
|
||||
<TooltipTrigger asChild>
|
||||
@@ -38,7 +38,9 @@ export const TaskTopbar: FC<TaskTopbarProps> = ({ task, workspace }) => {
|
||||
</Tooltip>
|
||||
</TooltipProvider>
|
||||
|
||||
<h1 className="m-0 pl-2 text-base font-medium truncate">{task.name}</h1>
|
||||
<h1 className="m-0 pl-2 text-base font-medium max-w-[520px] truncate">
|
||||
{task.display_name}
|
||||
</h1>
|
||||
|
||||
{task.current_state?.uri && (
|
||||
<div className="flex items-center gap-2 flex-wrap ml-4">
|
||||
|
||||
@@ -4971,8 +4971,8 @@ export const MockAIPromptPresets: TypesGen.Preset[] = [
|
||||
|
||||
export const MockTask = {
|
||||
id: "test-task",
|
||||
name: "wild-test-123",
|
||||
display_name: "Task wild test",
|
||||
name: "perform-some-task-123",
|
||||
display_name: "Perform some task",
|
||||
organization_id: MockOrganization.id,
|
||||
owner_id: MockUserOwner.id,
|
||||
owner_name: MockUserOwner.username,
|
||||
|
||||
Reference in New Issue
Block a user