opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-24 15:04:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: fix flake in TestWorkspaceBuildsProvisionerState (#18839)

Browse Source 
Fixes https://github.com/coder/internal/issues/761
This commit is contained in:
Cian Johnston
2025-07-15 15:07:13 +10:00
committed by GitHub
parent 7c077d39c5
commit 1ee6b8d5b1
1 changed files with 16 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
coderd/workspacebuilds_test.go
+16 -10
View File
@@ -494,11 +494,14 @@ func TestWorkspaceBuildsProvisionerState(t *testing.T) {
require.NoError(t, err)
coderdtest.AwaitWorkspaceBuildJobCompleted(t, client, build.ID)
// Validate that the deletion was audited.
require.True(t, auditor.Contains(t, database.AuditLog{
ResourceID: build.ID,
Action: database.AuditActionDelete,
}))
// Validate that the deletion was audited. This happens after the transaction
// is committed, so it may not show up in the mock auditor immediately.
testutil.Eventually(ctx, t, func(context.Context) bool {
return auditor.Contains(t, database.AuditLog{
ResourceID: build.ID,
Action: database.AuditActionDelete,
})
}, testutil.IntervalFast)
})
t.Run("NoProvisioners", func(t *testing.T) {
@@ -535,11 +538,14 @@ func TestWorkspaceBuildsProvisionerState(t *testing.T) {
require.Empty(t, ws)
require.Equal(t, http.StatusGone, coderdtest.SDKError(t, err).StatusCode())
// Validate that the deletion was audited.
require.True(t, auditor.Contains(t, database.AuditLog{
ResourceID: build.ID,
Action: database.AuditActionDelete,
}))
// Validate that the deletion was audited. This happens after the transaction
// is committed, so it may not show up in the mock auditor immediately.
testutil.Eventually(ctx, t, func(context.Context) bool {
return auditor.Contains(t, database.AuditLog{
ResourceID: build.ID,
Action: database.AuditActionDelete,
})
}, testutil.IntervalFast)
})
})
}