opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-24 15:04:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(site): use async findBy queries in ChatModelAdminPanel stories (#23999)

Browse Source 
> This PR was authored by Mux on behalf of @ibetitsmike.

Chromatic tests for `ChatModelAdminPanel` were failing because
synchronous
`getByRole`/`getByLabelText` calls were used after `userEvent.click()`
actions
that trigger navigation to a conditionally-rendered detail view. The
switches
and inputs in `ProviderForm` aren't in the DOM immediately after click,
so the
synchronous queries fail with "Unable to find an accessible element."

Changed all post-click `getByRole`/`getByLabelText` calls to their async
`findByRole`/`findByLabelText` equivalents across three stories:
`ProviderWithUserKeysEnabled`, `EnvPresetProviders`, and
`CreateAndUpdateProvider`.
This commit is contained in:
Michael Suchacz
2026-04-03 00:07:40 +02:00
committed by GitHub
parent 5b6b7719df
commit 1c4a9ed745
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
site/src/pages/AgentsPage/components/ChatModelAdminPanel/ChatModelAdminPanel.stories.tsx
+9 -7
View File
@@ -318,7 +318,9 @@ export const EnvPresetProviders: Story = {
).toBeInTheDocument();
// Navigate to Anthropic detail view and verify it's also env-managed.
await userEvent.click(body.getByRole("button", { name: /Anthropic/i }));
await userEvent.click(
await body.findByRole("button", { name: /Anthropic/i }),
);
await expect(
await body.findByText(
"This provider key is configured from deployment environment settings and cannot be edited in this UI.",
@@ -436,10 +438,10 @@ export const CreateAndUpdateProvider: Story = {
await userEvent.click(await body.findByRole("button", { name: /OpenAI/i }));
await expect(
body.getByRole("switch", { name: "Central API key" }),
await body.findByRole("switch", { name: "Central API key" }),
).toBeChecked();
expect(
body.getByRole("switch", { name: "Allow user API keys" }),
await body.findByRole("switch", { name: "Allow user API keys" }),
).not.toBeChecked();
expect(
body.queryByRole("switch", { name: "Use central key as fallback" }),
@@ -450,11 +452,11 @@ export const CreateAndUpdateProvider: Story = {
"sk-provider-key",
);
await userEvent.type(
body.getByLabelText("Base URL"),
await body.findByLabelText("Base URL"),
"https://proxy.example.com/v1",
);
await userEvent.click(
body.getByRole("button", { name: "Create provider config" }),
await body.findByRole("button", { name: "Create provider config" }),
);
await waitFor(() => {
@@ -478,7 +480,7 @@ export const CreateAndUpdateProvider: Story = {
});
await userEvent.click(
body.getByRole("switch", { name: "Allow user API keys" }),
await body.findByRole("switch", { name: "Allow user API keys" }),
);
await userEvent.click(
await body.findByRole("switch", { name: "Use central key as fallback" }),
@@ -547,7 +549,7 @@ export const ProviderWithUserKeysEnabled: Story = {
).toBeInTheDocument();
await userEvent.click(body.getByRole("button", { name: /OpenAI/i }));
await expect(
body.getByRole("switch", { name: "Allow user API keys" }),
await body.findByRole("switch", { name: "Allow user API keys" }),
).toBeChecked();
await expect(
await body.findByRole("switch", {