opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-24 15:04:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(site): respect meta user appearance preference as theme fallback (#22152)

Browse Source 
Use the server-rendered meta tag value as an intermediate fallback for
theme preference, between the JS-fetched value and the default theme.
This ensures the correct theme is applied before the API response loads.

Fixes #20050
This commit is contained in:
Jeremy Ruppel
2026-02-20 16:32:49 -05:00
committed by GitHub
parent de4ff78cd1
commit 065266412a
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
site/src/contexts/ThemeProvider.tsx
+5 -2
View File
@@ -58,9 +58,12 @@ export const ThemeProvider: FC<PropsWithChildren> = ({ children }) => {
}, [themeQuery]);
// We might not be logged in yet, or the `theme_preference` could be an empty string.
// Prefer JS-fetched value, fall back to server-rendered meta tag, then default.
const themePreference =
appearanceSettingsQuery.data?.theme_preference || DEFAULT_THEME;
// The janky casting here is find because of the much more type safe fallback
appearanceSettingsQuery.data?.theme_preference ||
metadata.userAppearance?.value?.theme_preference ||
DEFAULT_THEME;
// The janky casting here is fine because of the much more type safe fallback
// We need to support `themePreference` being wrong anyway because the database
// value could be anything, like an empty string.