opensource/cloudpods
3
0
Fork 0
mirror of https://github.com/yunionio/cloudpods.git synced 2026-09-24 16:03:43 +08:00
Code Issues Packages Projects Releases Wiki Activity

db_dispatcher: remove unused GetExtraDetails call

Browse Source
This commit is contained in:
Yousong Zhou
2020-11-26 21:18:57 +08:00
parent 6c65eb1ea6
commit fd98674c92
1 changed files with 0 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/cloudcommon/db/db_dispatcher.go
-14
View File
@@ -827,25 +827,11 @@ func getModelItemDetails(manager IModelManager, item IModel, ctx context.Context
}
func getItemDetails(manager IModelManager, item IModel, ctx context.Context, userCred mcclient.TokenCredential, query jsonutils.JSONObject) (jsonutils.JSONObject, error) {
extraDict, err := GetExtraDetails(item, ctx, userCred, query, false)
if err != nil {
return nil, httperrors.NewGeneralError(err)
}
if extraDict == nil {
// override GetExtraDetails
return nil, nil
}
metaFields, excludeFields := GetDetailFields(manager, userCred)
fieldFilter := jsonutils.GetQueryStringArray(query, "field")
getFields := mergeFields(metaFields, fieldFilter, IsAllowGet(rbacutils.ScopeSystem, userCred, item))
excludes, _, _ := stringutils2.Split(stringutils2.NewSortedStrings(excludeFields), getFields)
//jsonDict := jsonutils.Marshal(item).(*jsonutils.JSONDict)
//jsonDict = jsonDict.CopyIncludes(getFields...)
// extraDict.Update(jsonDict)
// jsonDict = getModelExtraDetails(item, ctx, jsonDict)
var sortedListFields stringutils2.SSortedStrings
if len(fieldFilter) > 0 {
sortedListFields = stringutils2.NewSortedStrings(fieldFilter)