opensource/cloudpods
3
0
Fork 0
mirror of https://github.com/yunionio/cloudpods.git synced 2026-09-19 10:46:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(esxi): replace GetTemplateVMById with FetchTemplateVMById

Browse Source 
FetchTemplateVMById 更好，因为它更轻量，更快。
This commit is contained in:
rainzm
2020-09-09 21:58:16 +08:00
parent 7dfe68322a
commit ebf3692ba0
2 changed files with 1 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/hostman/storageman/imagecachemanager_agent.go
+1 -1
View File
@@ -225,7 +225,7 @@ func (c *SAgentImageCacheManager) perfetchTemplateVMImageCache(ctx context.Conte
if err != nil {
return nil, errors.Wrap(err, "host.GetDatacenter")
}
_, err = dc.GetTemplateVMById(data.ImageExternalId)
_, err = dc.FetchTemplateVMById(data.ImageExternalId)
if err != nil {
return nil, err
}
pkg/multicloud/esxi/datacenter.go
-21
View File
@@ -436,24 +436,3 @@ func (dc *SDatacenter) GetTemplateVMs() ([]*SVirtualMachine, error) {
}
return templateVms, nil
}
func (dc *SDatacenter) GetTemplateVMById(id string) (*SVirtualMachine, error) {
id = dc.manager.getPrivateId(id)
hosts, err := dc.GetIHosts()
if err != nil {
return nil, errors.Wrap(err, "SDatacenter.GetIHosts")
}
for _, ihost := range hosts {
host := ihost.(*SHost)
tvms, err := host.GetTemplateVMs()
if err != nil {
return nil, errors.Wrap(err, "host.GetTemplateVMs")
}
for i := range tvms {
if tvms[i].GetGlobalId() == id {
return tvms[i], nil
}
}
}
return nil, cloudprovider.ErrNotFound
}