Merge pull request #7811 from swordqiu/hotfix/qj-prevent-user-in-disabled-idp-login

fix: prevent users in disabled idp from login
This commit is contained in:
yunion-ci-robot
2020-09-07 20:57:46 +08:00
committed by GitHub
+5 -2
View File
@@ -17,7 +17,6 @@ package tokens
import (
"context"
"database/sql"
"fmt"
"time"
"yunion.io/x/jsonutils"
@@ -152,8 +151,12 @@ func authUserByIdentity(ctx context.Context, ident mcclient.SAuthenticationIdent
idp := idpObj.(*models.SIdentityProvider)
if idp.Enabled.IsFalse() {
return nil, errors.Wrap(httperrors.ErrInvalidStatus, "idp disabled")
}
if idp.Status != api.IdentityDriverStatusConnected && idp.Status != api.IdentityDriverStatusDisconnected {
return nil, errors.Error(fmt.Sprintf("invalid idp status %s", idp.Status))
return nil, errors.Wrapf(httperrors.ErrInvalidStatus, "invalid idp status %s", idp.Status)
}
conf, err := models.GetConfigs(idp, true, nil, nil)