opensource/cloudpods
3
0
Fork 0
mirror of https://github.com/yunionio/cloudpods.git synced 2026-09-19 02:37:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

acl delete condition fix

Browse Source
This commit is contained in:
tangbin
2020-07-17 20:39:01 +08:00
parent 192a49a055
commit a74853db79
1 changed files with 19 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/compute/models/loadbalanceracls.go
+19 -14
View File
@@ -363,22 +363,27 @@ func (lbacl *SLoadbalancerAcl) PerformPatch(ctx context.Context, userCred mcclie
}
func (lbacl *SLoadbalancerAcl) ValidateDeleteCondition(ctx context.Context) error {
man := CachedLoadbalancerAclManager
t := man.TableSpec().Instance()
pdF := t.Field("pending_deleted")
men := []db.IModelManager{
LoadbalancerListenerManager,
CachedLoadbalancerAclManager,
}
lbaclId := lbacl.Id
n, err := t.Query().
Filter(sqlchemy.OR(sqlchemy.IsNull(pdF), sqlchemy.IsFalse(pdF))).
Equals("acl_id", lbaclId).
CountWithError()
if err != nil {
return httperrors.NewInternalServerError("get acl count fail %s", err)
}
if n > 0 {
// return fmt.Errorf("acl %s is still referred to by %d %s",
// lbaclId, n, man.KeywordPlural())
return httperrors.NewResourceBusyError("acl %s is still referred to by %d %s", lbaclId, n, man.KeywordPlural())
for _, man := range men {
t := man.TableSpec().Instance()
pdF := t.Field("pending_deleted")
n, err := t.Query().
Filter(sqlchemy.OR(sqlchemy.IsNull(pdF), sqlchemy.IsFalse(pdF))).
Equals("acl_id", lbaclId).
CountWithError()
if err != nil {
return httperrors.NewInternalServerError("get acl count fail %s", err)
}
if n > 0 {
return httperrors.NewResourceBusyError("acl %s is still referred to by %d %s", lbaclId, n, man.KeywordPlural())
}
}
return nil
}