chore(plugin-object-viewer): remove navigatorId

webapp/.eslintrc.js

@@ -53,6 +53,7 @@ module.exports = {
     }],
     'eqeqeq': 'warn',
     'radix': 'off',
+    'no-use-before-define': 'off',
     'no-constant-condition': 'off',
     'no-console': 'off',
     'no-dupe-class-members': 'off',

webapp/configs/webpack.config.js

@@ -149,7 +149,6 @@ module.exports = (env, argv) => {
     // ],
     devtool: 'cheap-module-source-map',
     plugins: [
-      new IgnoreNotFoundExportPlugin(),
       new ForkTsCheckerWebpackPlugin({
         typescript: {
           diagnosticOptions: {
@@ -158,6 +157,7 @@ module.exports = (env, argv) => {
           },
         },
       }),
+      new IgnoreNotFoundExportPlugin(),
       new MiniCssExtractPlugin({
         // Options similar to the same options in webpackOptions.output
         // all options are optional

webapp/packages/plugin-data-viewer/src/DataViewerTabService.ts

@@ -39,7 +39,6 @@ export class DataViewerTabService {
 
     this.page = this.dbObjectPageService.register({
       key: dataViewerHandlerKey,
-      navigatorId: 'database',
       priority: 2,
       order: 2,
       getTabComponent: () => DataViewerTab,
@@ -50,7 +49,7 @@ export class DataViewerTabService {
     });
   }
 
-  registerTabHandler() {
+  registerTabHandler(): void {
     this.navNodeManagerService.navigator.addHandler(this.navigationHandler.bind(this));
   }
 

webapp/packages/plugin-object-viewer/src/ObjectPage/DBObjectPageService.ts

@@ -29,7 +29,7 @@ export class DBObjectPageService {
     return objectPage;
   }
 
-  getPage(pageId: string) {
+  getPage(pageId: string): ObjectPage | undefined {
     return this.pages.get(pageId);
   }
 

webapp/packages/plugin-object-viewer/src/ObjectPage/ObjectPage.ts

@@ -32,7 +32,6 @@ export type ObjectPageRestoreCallback = (tab: ITab<IObjectViewerTabState>) => Pr
 
 export interface ObjectPageOptions {
   key: string;
-  navigatorId: string;
   priority: number;
   order?: number;
   getTabComponent(): ObjectPageTabComponent;
@@ -44,7 +43,6 @@ export interface ObjectPageOptions {
 
 export class ObjectPage {
   key: string;
-  navigatorId: string;
   priority: number;
   @observable order?: number;
   getTabComponent: () => ObjectPageTabComponent;
@@ -55,7 +53,6 @@ export class ObjectPage {
 
   constructor(options: ObjectPageOptions) {
     this.key = options.key;
-    this.navigatorId = options.navigatorId;
     this.priority = options.priority;
     this.order = options.order;
     this.getTabComponent = options.getTabComponent;

webapp/packages/plugin-object-viewer/src/ObjectPropertiesPage/ObjectPropertiesPageService.ts

@@ -32,10 +32,9 @@ export class ObjectPropertiesPageService {
   ) {
   }
 
-  registerDBObjectPage() {
+  registerDBObjectPage(): void {
     this.page = this.dbObjectPageService.register({
       key: 'properties',
-      navigatorId: 'database',
       priority: 1,
       order: 1,
       getTabComponent: () => ObjectPropertiesPageTab,