chore: fixes after code review

This commit is contained in:
Dmitry Krupenya
2020-05-19 18:49:59 +03:00
parent 9a884733cf
commit 4216451198
5 changed files with 13 additions and 16 deletions
-1
View File
@@ -37,7 +37,6 @@
"eslint-plugin-import-helpers": "^1.0.2",
"eslint-plugin-jest": "^22.21.0",
"eslint-plugin-jsx-a11y": "^6.2.3",
"eslint-plugin-prettier": "^3.1.1",
"eslint-plugin-react": "^7.16.0",
"eslint-plugin-react-hooks": "^1.7.0",
"lerna": "^3.19.0",
@@ -18,7 +18,7 @@ const includePathOptions = {
};
const defaultBuilderOptions = {
babelConfig: path.join(__dirname, './babel-plugin.config.js'),
babelConfig: path.join(__dirname, 'babel-plugin.config.js'),
typescriptConfig: '', // tbd
}
@@ -20,6 +20,8 @@ function replacementWithPluginImportCode(pluginsList) {
let code = '';
const names = [];
console.info('build with plugins:');
console.info(pluginsList);
pluginsList.forEach(plugin => {
const name = plugin
@@ -41,7 +43,6 @@ function dirExists(path) {
const stats = fs.statSync(path)
return stats && stats.isDirectory()
} catch (e) {
console.log(e)
return false;
}
}
@@ -90,7 +91,7 @@ module.exports = (env, argv) => {
{
loader: 'babel-loader',
options: {
configFile: path.join(__dirname, './babel-app.config.js')
configFile: path.join(__dirname, 'babel-app.config.js')
},
},
{
@@ -122,15 +123,6 @@ module.exports = (env, argv) => {
new webpack.DefinePlugin({
version: JSON.stringify(require(path.resolve(argv.currentDir, './package.json')).buildVersion),
}),
new webpack.ProgressPlugin({
entries: true,
modules: true,
modulesCount: 100,
profile: true,
// handler: (percentage, message, ...args) => {
// // custom logic
// }
}),
new CircularDependencyPlugin({
// exclude detection of files based on a RegExp
// exclude: /\.js|node_modules/,
@@ -21,6 +21,15 @@ module.exports = (env, argv) => merge(commonConfig(env, argv), {
},
devtool: 'cheap-module-eval-source-map',
plugins: [
new webpack.ProgressPlugin({
entries: true,
modules: true,
modulesCount: 100,
profile: true,
// handler: (percentage, message, ...args) => {
// // custom logic
// }
}),
// new webpack.HotModuleReplacementPlugin(), // enable HMR globally
new webpack.NamedModulesPlugin(), // prints more readable module names in the browser console on HMR updates
],
-3
View File
@@ -42,7 +42,6 @@
"css-loader": "^3.2.1",
"extract-css-chunks-webpack-plugin": "^4.7.1",
"file-loader": "^5.0.2",
"fork-ts-checker-webpack-plugin": "^4.0.5",
"go-split": "^1.3.2",
"graphql": "^14.5.8",
"html-webpack-plugin": "^3.2.0",
@@ -58,10 +57,8 @@
"preact": "^10.4.1",
"preact-render-to-string": "^5.1.6",
"preact-ssr-prepass": "^1.0.1",
"prettier": "^1.19.1",
"prettier-eslint": "^9.0.0",
"raw-loader": "^3.1.0",
"react": "^16.13.1",
"react-dom": "^16.13.1",
"react-hot-loader": "^4.12.18",
"reakit": "1.0.0-beta.11",