chore(core): refactor placeholder

webapp/packages/core/placeholder/package.json

@@ -1,8 +0,0 @@
-{
-  "name": "@dbeaver/core/placeholder",
-  "private": true,
-  "sideEffects": false,
-  "main": "../dist/placeholder",
-  "module": "../dist/placeholder",
-  "types": "../dist/types/placeholder"
-}

webapp/packages/core/src/app/TopNavBar/TopNavBar.tsx

@@ -8,8 +8,8 @@
 
 import styled from 'reshadow';
 
+import { Placeholder } from '@dbeaver/core/blocks';
 import { useService } from '@dbeaver/core/di';
-import { Placeholder } from '@dbeaver/core/placeholder';
 import { useStyles } from '@dbeaver/core/theming';
 
 import { TopNavService } from './TopNavBarService';

webapp/packages/core/src/app/TopNavBar/TopNavBarService.ts

@@ -6,8 +6,8 @@
  * you may not use this file except in compliance with the License.
  */
 
+import { PlaceholderContainer } from '@dbeaver/core/blocks';
 import { injectable } from '@dbeaver/core/di';
-import { PlaceholderContainer } from '@dbeaver/core/placeholder';
 
 import { ConnectionSelector } from './ConnectionSchemaManager/ConnectionSelector/ConnectionSelector';
 import { Fill } from './Fill';

webapp/packages/core/src/blocks/Placeholder/PlaceholderContainer.ts

@@ -45,13 +45,13 @@ export class PlaceholderContainer<T = unknown> {
   }
 
   private findPosition(order: number) {
-    for (let i = 0; i < this.placeholders.length; i++) {
-      const placeholder = this.placeholders[i];
-      if (placeholder.order === undefined || order <= placeholder.order) {
-        return i;
-      }
+    const position = this.placeholders
+      .findIndex(placeholder => placeholder.order === undefined || order <= placeholder.order);
+
+    if (position === -1) {
+      return this.placeholders.length;
     }
 
-    return this.placeholders.length;
+    return position;
   }
 }

webapp/packages/core/src/blocks/index.ts

@@ -18,3 +18,5 @@ export * from './SanitizedHTML/SanitizedHTML';
 export * from './ItemList';
 export * from './PropertiesTable';
 export * from './IconButton';
+export * from './Placeholder/Placeholder';
+export * from './Placeholder/PlaceholderContainer';

webapp/packages/core/src/placeholder/index.ts

@@ -1,2 +0,0 @@
-export * from './Placeholder';
-export * from './PlaceholderContainer';

webapp/packages/dbeaver/configs/webpack/common.js

@@ -49,7 +49,6 @@ module.exports = (env, argv) => merge(commonConfig(env, argv), {
       "@dbeaver/core/extensions": path.resolve(__dirname, "../../../core/src/extensions"),
       "@dbeaver/core/product": path.resolve(__dirname, "../../../core/src/product"),
       "@dbeaver/core/plugin": path.resolve(__dirname, "../../../core/src/plugin"),
-      "@dbeaver/core/placeholder": path.resolve(__dirname, "../../../core/src/placeholder"),
 
       // rewrite imports for unnecessary work in `web/src/libs/sdk.ts`
       'graphql-tag': path.join(__dirname, '../../fix-gql.js'),