opensource/cloudbeaver
3
0
Fork 0
mirror of https://github.com/dbeaver/cloudbeaver.git synced 2026-10-13 07:47:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #170 from dbeaver/fix/dialogs-error

Browse Source 
fix(core-connections): moved connection errors from form to snackbar
This commit is contained in:
Alexey
2020-10-05 19:26:33 +03:00
committed by GitHub
parent 9d510ac8af 16160c1c28
commit 07ddda099c
4 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
webapp/packages/core-connections/src/Administration/Connections/ConnectionForm/Controller.ts
+2 -2
View File
@@ -87,7 +87,7 @@ implements IInitializableController, IDestructibleController {
this.notificationService.logInfo({ title: `Connection ${connection.name} created` });
}
} catch (exception) {
this.showError(exception, 'Failed to create connection');
this.notificationService.logException(exception, 'connections_connection_create_fail');
} finally {
this.isSaving = false;
}
@@ -100,7 +100,7 @@ implements IInitializableController, IDestructibleController {
await this.connectionsResource.test(this.getConnectionConfig());
this.notificationService.logInfo({ title: 'Connection is established' });
} catch (exception) {
this.showError(exception, 'Connection test failed');
this.notificationService.logException(exception, 'connections_connection_test_fail');
} finally {
this.isSaving = false;
}
webapp/packages/core-connections/src/locales/en.ts
+3
View File
@@ -22,5 +22,8 @@ export default [
['connections_connection_port', 'Port'],
['connections_connection_template', 'Template'],
['connections_connection_test', 'Test Connection'],
['connections_connection_test_fail', 'Connection test failed'],
['connections_connection_create_fail', 'Failed to create connection'],
['connections_connection_save_fail', 'Failed to save connection'],
['connections_driver_search_placeholder', 'Type driver name...'],
];
webapp/packages/core-connections/src/locales/ru.ts
+3
View File
@@ -21,5 +21,8 @@ export default [
['connections_connection_port', 'Порт'],
['connections_connection_template', 'Шаблон'],
['connections_connection_test', 'Проверить подключение'],
['connections_connection_test_fail', 'Не удалось выполнить тестовое подключение'],
['connections_connection_create_fail', 'Не удалось создать подключение'],
['connections_connection_save_fail', 'Не удалось сохранить подключение'],
['connections_driver_search_placeholder', 'Введите название драйвера...'],
];
webapp/packages/plugin-connection-custom/src/CustomConnection/ConnectionFormDialog/ConnectionFormDialogController.ts
+2 -2
View File
@@ -79,7 +79,7 @@ implements IInitializableController, IDestructibleController {
this.notificationService.logInfo({ title: 'Connection is established' });
} catch (exception) {
this.showError(exception, 'Connection test failed');
this.notificationService.logException(exception, 'connections_connection_test_fail');
} finally {
this.isConnecting = false;
}
@@ -94,7 +94,7 @@ implements IInitializableController, IDestructibleController {
this.notificationService.logInfo({ title: `Connection ${connection.name} created` });
this.onClose();
} catch (exception) {
this.showError(exception, 'Failed to create connection');
this.notificationService.logException(exception, 'connections_connection_create_fail');
} finally {
this.isConnecting = false;
}