add back tasksay

biome.jsonc

@@ -61,6 +61,8 @@
 				"noUselessElse": "info"
 			},
 			"suspicious": {
+				"noSkippedTests": "warn",
+				"noFocusedTests": "error",
 				"noDoubleEquals": "warn",
 				"noImplicitAnyLet": "info",
 				"noThenProperty": "off",

src/core/task/__tests__/TaskSay.test.ts

@@ -0,0 +1,191 @@
+import { Task } from "@core/task"
+import { expect } from "chai"
+import sinon from "sinon"
+
+describe("Task.say", () => {
+	it("skips duplicate partial text when the same completed text was just rendered", async () => {
+		const addToClineMessages = sinon.stub().resolves()
+		const updateClineMessage = sinon.stub().resolves()
+		const postStateToWebview = sinon.stub().resolves()
+
+		const fakeTask: any = {
+			taskState: { abort: false, lastMessageTs: 0 },
+			getCurrentProviderInfo: () => ({
+				providerId: "minimax",
+				model: { id: "MiniMax-M2.1" },
+				mode: "act",
+			}),
+			messageStateHandler: {
+				getClineMessages: () => [
+					{
+						type: "say",
+						say: "text",
+						text: "Hello! How can I help you today?",
+						partial: false,
+						ts: Date.now(),
+					},
+				],
+				addToClineMessages,
+				updateClineMessage,
+			},
+			postStateToWebview,
+		}
+
+		const result = await Task.prototype.say.call(
+			fakeTask,
+			"text",
+			"Hello! How can I help you today?",
+			undefined,
+			undefined,
+			true,
+		)
+
+		expect(result).to.equal(undefined)
+		expect(addToClineMessages.called).to.equal(false)
+		expect(updateClineMessage.called).to.equal(false)
+		expect(postStateToWebview.called).to.equal(false)
+	})
+
+	it("still adds a partial text when content differs", async () => {
+		const addToClineMessages = sinon.stub().resolves()
+		const updateClineMessage = sinon.stub().resolves()
+		const postStateToWebview = sinon.stub().resolves()
+
+		const fakeTask: any = {
+			taskState: { abort: false, lastMessageTs: 0 },
+			getCurrentProviderInfo: () => ({
+				providerId: "minimax",
+				model: { id: "MiniMax-M2.1" },
+				mode: "act",
+			}),
+			messageStateHandler: {
+				getClineMessages: () => [
+					{
+						type: "say",
+						say: "text",
+						text: "Hello! How can I help you today?",
+						partial: false,
+						ts: Date.now(),
+					},
+				],
+				addToClineMessages,
+				updateClineMessage,
+			},
+			postStateToWebview,
+		}
+
+		await Task.prototype.say.call(
+			fakeTask,
+			"text",
+			"Hello! How can I help you today? More details...",
+			undefined,
+			undefined,
+			true,
+		)
+
+		expect(addToClineMessages.calledOnce).to.equal(true)
+		expect(updateClineMessage.called).to.equal(false)
+		expect(postStateToWebview.calledOnce).to.equal(true)
+	})
+
+	it("ignores stale partial reasoning after a completed reasoning message", async () => {
+		const addToClineMessages = sinon.stub().resolves()
+		const updateClineMessage = sinon.stub().resolves()
+		const postStateToWebview = sinon.stub().resolves()
+
+		const fakeTask: any = {
+			taskState: { abort: false, lastMessageTs: 0 },
+			getCurrentProviderInfo: () => ({
+				providerId: "minimax",
+				model: { id: "MiniMax-M2.1" },
+				mode: "act",
+			}),
+			messageStateHandler: {
+				getClineMessages: () => [
+					{
+						type: "say",
+						say: "reasoning",
+						text: "Completed reasoning",
+						partial: false,
+						ts: Date.now(),
+					},
+				],
+				addToClineMessages,
+				updateClineMessage,
+			},
+			postStateToWebview,
+		}
+
+		const result = await Task.prototype.say.call(
+			fakeTask,
+			"reasoning",
+			"Late stale reasoning chunk",
+			undefined,
+			undefined,
+			true,
+		)
+
+		expect(result).to.equal(undefined)
+		expect(addToClineMessages.called).to.equal(false)
+		expect(updateClineMessage.called).to.equal(false)
+		expect(postStateToWebview.called).to.equal(false)
+	})
+
+	it("completes an earlier partial text even when a different say type was added after it", async () => {
+		const addToClineMessages = sinon.stub().resolves()
+		const updateClineMessage = sinon.stub().resolves()
+		const postStateToWebview = sinon.stub().resolves()
+		const partialTextTs = Date.now()
+
+		const fakeTask: any = {
+			taskState: { abort: false, lastMessageTs: 0 },
+			getCurrentProviderInfo: () => ({
+				providerId: "minimax",
+				model: { id: "MiniMax-M2.1" },
+				mode: "act",
+			}),
+			messageStateHandler: {
+				getClineMessages: () => [
+					{
+						type: "say",
+						say: "text",
+						text: "Now let me read a few source files to understand the code structure better:",
+						partial: true,
+						ts: partialTextTs,
+					},
+					{
+						type: "say",
+						say: "reasoning",
+						text: "Now I have a good understanding.",
+						partial: true,
+						ts: partialTextTs + 1,
+					},
+				],
+				addToClineMessages,
+				updateClineMessage,
+			},
+			postStateToWebview,
+		}
+
+		const result = await Task.prototype.say.call(
+			fakeTask,
+			"text",
+			"Now let me read a few source files to understand the code structure better: Let me also analyze the dependencies between different modules.",
+			undefined,
+			undefined,
+			false,
+		)
+
+		expect(result).to.equal(undefined)
+		expect(updateClineMessage.calledOnce).to.equal(true)
+		expect(updateClineMessage.firstCall.args[0]).to.equal(0)
+		expect(updateClineMessage.firstCall.args[1]).to.deep.equal({
+			text: "Now let me read a few source files to understand the code structure better: Let me also analyze the dependencies between different modules.",
+			images: undefined,
+			files: undefined,
+			partial: false,
+		})
+		expect(addToClineMessages.called).to.equal(false)
+		expect(postStateToWebview.called).to.equal(false)
+	})
+})