changeset

.changeset/real-clouds-act.md

@@ -0,0 +1,5 @@
+---
+"claude-dev": patch
+---
+
+fix menu for setting terminal timeout

proto/state.proto

@@ -11,7 +11,6 @@ service StateService {
   rpc toggleFavoriteModel(StringRequest) returns (Empty);
   rpc resetState(EmptyRequest) returns (Empty);
   rpc togglePlanActMode(TogglePlanActModeRequest) returns (Empty);
-  rpc updateTerminalConnectionTimeout(Int64Request) returns (Int64);
   rpc updateAutoApprovalSettings(AutoApprovalSettingsRequest) returns (Empty);
   rpc updateSettings(UpdateSettingsRequest) returns (Empty);
 }

src/core/controller/state/updateTerminalConnectionTimeout.ts

@@ -1,27 +0,0 @@
-import { Controller } from ".."
-import { Int64, Int64Request } from "../../../shared/proto/common"
-import { updateGlobalState } from "../../storage/state"
-
-/**
- * Updates the terminal connection timeout setting
- * @param controller The controller instance
- * @param request The request containing the timeout value in milliseconds
- * @returns The updated timeout value
- */
-export async function updateTerminalConnectionTimeout(controller: Controller, request: Int64Request): Promise<Int64> {
-	try {
-		const timeout = request.value
-
-		if (typeof timeout === "number" && !isNaN(timeout) && timeout > 0) {
-			// Update the global state directly
-			await updateGlobalState(controller.context, "shellIntegrationTimeout", timeout)
-			return Int64.create({ value: timeout })
-		} else {
-			console.warn(`Invalid shell integration timeout value received: ${timeout}. Expected a positive number.`)
-			throw new Error("Invalid timeout value. Expected a positive number.")
-		}
-	} catch (error) {
-		console.error(`Failed to update terminal connection timeout: ${error}`)
-		throw error
-	}
-}

webview-ui/src/components/settings/TerminalSettingsSection.tsx

@@ -1,8 +1,6 @@
 import React, { useState } from "react"
 import { VSCodeTextField, VSCodeCheckbox } from "@vscode/webview-ui-toolkit/react"
 import { useExtensionState } from "@/context/ExtensionStateContext"
-import { StateServiceClient } from "@/services/grpc-client"
-import { Int64, Int64Request } from "@shared/proto/common"
 
 export const TerminalSettingsSection: React.FC = () => {
 	const { shellIntegrationTimeout, setShellIntegrationTimeout, terminalReuseEnabled, setTerminalReuseEnabled } =
@@ -27,18 +25,6 @@ export const TerminalSettingsSection: React.FC = () => {
 
 		// Update local state
 		setShellIntegrationTimeout(timeout)
-
-		// Send to extension using gRPC
-		StateServiceClient.updateTerminalConnectionTimeout({
-			value: timeout,
-		} as Int64Request)
-			.then((response: Int64) => {
-				setShellIntegrationTimeout(response.value)
-				setInputValue((response.value / 1000).toString())
-			})
-			.catch((error) => {
-				console.error("Failed to update terminal connection timeout:", error)
-			})
 	}
 
 	const handleInputBlur = () => {