opensource/cline
3
0
Fork 0
mirror of https://github.com/cline/cline.git synced 2026-10-24 23:34:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(desktop): open triggered runs after overlapping refresh (#15293)

Browse Source
This commit is contained in:
John Choi
2026-10-23 12:49:40 -07:00
committed by John Choi
parent acbce5801b
commit 3f916e337f
2 changed files with 38 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/examples/desktop-app/webview/components/views/settings/routine-view.test.tsx
+37
View File
@@ -98,6 +98,43 @@ async function mount() {
}
describe("schedule execution updates", () => {
it.each([
false,
true,
])("opens the triggered session after a slow refresh (superseded: %s)", async (superseded) => {
const onOpenSession = vi.fn();
await act(async () =>
root.render(<RoutineSchedulesContent onOpenSession={onOpenSession} />),
);
await act(async () => vi.advanceTimersByTimeAsync(0));
const delayed = Promise.withResolvers<ReturnType<typeof overview>>();
invoke
.mockResolvedValueOnce({ execution: { executionId: "execution-1" } })
.mockReturnValueOnce(delayed.promise)
.mockResolvedValue(overview("success"));
await act(async () =>
container
.querySelector<HTMLButtonElement>(
'button[aria-label="Run Daily PR summary now"]',
)
?.click(),
);
expect(invoke).toHaveBeenCalledWith("trigger_routine_schedule", {
schedule_id: schedule.scheduleId,
});
if (superseded)
await act(async () => handlers.get("schedule.execution_completed")?.());
await act(async () => vi.advanceTimersByTimeAsync(16_000));
const response = {
...overview("running"),
lastExecutions: [
{ ...overview("running").lastExecutions[0], sessionId: "session-new" },
],
};
await act(async () => delayed.resolve(response));
expect(onOpenSession).toHaveBeenCalledExactlyOnceWith("session-new");
expect(container.textContent).toContain(superseded ? "success" : "running");
});
it("shows a failure received after loading Pending, even without a session", async () => {
await mount();
expect(container.textContent).toContain("pending");
apps/examples/desktop-app/webview/components/views/settings/routine-view.tsx
+1 -1
View File
@@ -744,7 +744,7 @@ export function RoutineSchedulesContent({
!mountedRef.current ||
requestId !== overviewRequestSequence.current
)
return;
return response;
const schedules = response.schedules;
const activeExecutions = response.activeExecutions;
const upcomingRuns = response.upcomingRuns;