opensource/RSSHub
3
0
Fork 0
mirror of https://github.com/DIYgod/RSSHub.git synced 2026-09-01 14:57:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(test): insufficiently robust puppeteer test (#9974)

Browse Source 
Signed-off-by: Rongrong <i@rong.moe>
This commit is contained in:
Rongrong
2022-06-17 21:55:33 +08:00
committed by GitHub
parent 1ec5d2ae92
commit 1fcb5379df
1 changed files with 24 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/utils/puppeteer.js
+24 -5
View File
@@ -2,14 +2,24 @@ let puppeteer;
const wait = require('../../lib/utils/wait');
const cheerio = require('cheerio');
let browser = null;
afterEach(() => {
if (browser) {
// double insurance to close unclosed browser immediately after each test
// if a test closure fails before it can close the browser, the browser process will probably be unclosed,
// especially when the test unit is run through `npm run jest puppeteer`
browser.close();
browser = null;
}
jest.resetModules();
});
describe('puppeteer', () => {
it('puppeteer run', async () => {
puppeteer = require('../../lib/utils/puppeteer');
const browser = await puppeteer();
browser = await puppeteer();
const startTime = Date.now();
const page = await browser.newPage();
await page.goto('https://www.google.com', {
waitUntil: 'domcontentloaded',
@@ -20,12 +30,17 @@ describe('puppeteer', () => {
expect(html.length).toBeGreaterThan(0);
expect((await browser.process()).signalCode).toBe(null);
await wait(31 * 1000);
const sleepTime = 31 * 1000 - (Date.now() - startTime); // prevent long loading time from failing the test
if (sleepTime > 0) {
await wait(sleepTime);
}
expect((await browser.process()).signalCode).toBe('SIGKILL');
}, 40000);
browser = null;
}, 45000);
it('puppeteer without stealth', async () => {
puppeteer = require('../../lib/utils/puppeteer');
const browser = await puppeteer({ stealth: false });
browser = await puppeteer({ stealth: false });
const page = await browser.newPage();
await page.goto('https://bot.sannysoft.com', {
waitUntil: 'networkidle0',
@@ -34,6 +49,7 @@ describe('puppeteer', () => {
const html = await page.evaluate(() => document.body.innerHTML);
const $ = cheerio.load(html);
browser.close();
browser = null;
const webDriverTest = $('tbody tr').eq(2).find('td').eq(1).text().trim();
const chromeTest = $('tbody tr').eq(4).find('td').eq(1).text().trim();
@@ -42,9 +58,10 @@ describe('puppeteer', () => {
expect(['present (failed)', '']).toContain(webDriverTest);
expect(['missing (failed)', '']).toContain(chromeTest);
}, 10000);
it('puppeteer with stealth', async () => {
puppeteer = require('../../lib/utils/puppeteer');
const browser = await puppeteer({ stealth: true });
browser = await puppeteer({ stealth: true });
const page = await browser.newPage();
await page.goto('https://bot.sannysoft.com', {
waitUntil: 'networkidle0',
@@ -53,6 +70,8 @@ describe('puppeteer', () => {
const html = await page.evaluate(() => document.body.innerHTML);
const $ = cheerio.load(html);
browser.close();
browser = null;
const webDriverTest = $('tbody tr').eq(2).find('td').eq(1).text().trim();
const chromeTest = $('tbody tr').eq(4).find('td').eq(1).text().trim();
// these are something we really care about