mirror of
https://github.com/saltbo/zpan.git
synced 2026-08-29 00:01:42 +08:00
f701f4139a
Clears all 23 open CodeQL alerts:
- actions/missing-workflow-permissions (19, medium): add a top-level
least-privilege `permissions: contents: read` to ci.yml and the 7
deploy workflows. The one CI job that needs `packages: write` already
declares its own block; all deploys authenticate via static secrets
(no OIDC / id-token, no repo writes), so read is sufficient.
- js/insecure-randomness (1, high): `genPassword()` built share
passwords with Math.random(); switch to crypto.getRandomValues() over
the same unambiguous alphabet (length/charset/uniqueness preserved).
- js/incomplete-url-substring-sanitization (2, high): two test fetch
stubs routed on `String(url).includes('api.github.com')`; tighten to
`new URL(url).hostname === 'api.github.com'` — precise and no longer
flagged.
- js/stack-trace-exposure (1, medium): the E2E S3 mock echoed
error.message in 500 responses; log server-side and return a generic
body instead.
Verified: typecheck green; share-dialog/changelog/system.integration
tests pass.
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
127 lines
4.4 KiB
YAML
127 lines
4.4 KiB
YAML
name: Deploy to Netlify
|
|
|
|
# Triggered by the top-level Deploy dispatcher (.github/workflows/deploy.yml)
|
|
# when Netlify + Turso secrets are configured. Manual runs via the Actions UI
|
|
# also supported.
|
|
on:
|
|
workflow_call:
|
|
workflow_dispatch:
|
|
inputs:
|
|
version:
|
|
description: 'Release tag to deploy (e.g. v2.5.0). Leave empty for latest.'
|
|
required: false
|
|
|
|
# Prevent overlapping deployments.
|
|
concurrency:
|
|
group: deploy-netlify
|
|
cancel-in-progress: false
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
jobs:
|
|
deploy:
|
|
name: Deploy
|
|
runs-on: ubuntu-latest
|
|
env:
|
|
NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
|
|
NETLIFY_SITE_ID: ${{ secrets.NETLIFY_SITE_ID }}
|
|
|
|
steps:
|
|
- name: Check required secrets
|
|
env:
|
|
HAS_TURSO_URL: ${{ secrets.TURSO_DATABASE_URL != '' }}
|
|
HAS_TURSO_TOKEN: ${{ secrets.TURSO_AUTH_TOKEN != '' }}
|
|
HAS_NETLIFY_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN != '' }}
|
|
HAS_NETLIFY_SITE: ${{ secrets.NETLIFY_SITE_ID != '' }}
|
|
run: |
|
|
MISSING=""
|
|
[ "$HAS_TURSO_URL" != "true" ] && MISSING="$MISSING TURSO_DATABASE_URL"
|
|
[ "$HAS_TURSO_TOKEN" != "true" ] && MISSING="$MISSING TURSO_AUTH_TOKEN"
|
|
[ "$HAS_NETLIFY_TOKEN" != "true" ] && MISSING="$MISSING NETLIFY_AUTH_TOKEN"
|
|
[ "$HAS_NETLIFY_SITE" != "true" ] && MISSING="$MISSING NETLIFY_SITE_ID"
|
|
if [ -n "$MISSING" ]; then
|
|
echo "::error::Missing required secrets:$MISSING"
|
|
echo "Go to Settings → Secrets and variables → Actions to add them."
|
|
exit 1
|
|
fi
|
|
|
|
- name: Resolve release tag
|
|
id: release
|
|
env:
|
|
GH_TOKEN: ${{ github.token }}
|
|
INPUT_VERSION: ${{ inputs.version }}
|
|
run: |
|
|
if [ -n "$INPUT_VERSION" ]; then
|
|
TAG="$INPUT_VERSION"
|
|
else
|
|
TAG=$(gh api repos/saltbo/zpan/releases/latest --jq '.tag_name')
|
|
fi
|
|
if [ -z "$TAG" ]; then
|
|
echo "::error::No release found in saltbo/zpan"
|
|
exit 1
|
|
fi
|
|
echo "version=$TAG" >> "$GITHUB_OUTPUT"
|
|
echo "### 🚀 Deploying $TAG to Netlify" >> "$GITHUB_STEP_SUMMARY"
|
|
|
|
- uses: actions/checkout@v4
|
|
with:
|
|
repository: saltbo/zpan
|
|
ref: ${{ steps.release.outputs.version }}
|
|
|
|
- uses: pnpm/action-setup@v4
|
|
- uses: actions/setup-node@v4
|
|
with:
|
|
node-version: 24
|
|
cache: pnpm
|
|
|
|
- run: pnpm install --frozen-lockfile
|
|
|
|
- name: Apply Turso migrations
|
|
env:
|
|
TURSO_DATABASE_URL: ${{ secrets.TURSO_DATABASE_URL }}
|
|
TURSO_AUTH_TOKEN: ${{ secrets.TURSO_AUTH_TOKEN }}
|
|
run: pnpm exec drizzle-kit migrate
|
|
|
|
- name: Ensure BETTER_AUTH_SECRET is set (first deploy only)
|
|
env:
|
|
USER_SECRET: ${{ secrets.BETTER_AUTH_SECRET }}
|
|
run: |
|
|
EXISTING=$(pnpm exec netlify env:get BETTER_AUTH_SECRET 2>&1 || true)
|
|
if [ -n "$USER_SECRET" ]; then
|
|
pnpm exec netlify env:set BETTER_AUTH_SECRET "$USER_SECRET" --context production
|
|
echo "Set BETTER_AUTH_SECRET from GitHub secret"
|
|
elif [ -z "$EXISTING" ]; then
|
|
pnpm exec netlify env:set BETTER_AUTH_SECRET "$(openssl rand -base64 32)" --context production
|
|
echo "Auto-generated BETTER_AUTH_SECRET"
|
|
else
|
|
echo "BETTER_AUTH_SECRET already set, skipping"
|
|
fi
|
|
|
|
- name: Build
|
|
run: |
|
|
pnpm build
|
|
pnpm build:netlify
|
|
|
|
- name: Deploy
|
|
id: deploy
|
|
env:
|
|
TURSO_DATABASE_URL: ${{ secrets.TURSO_DATABASE_URL }}
|
|
TURSO_AUTH_TOKEN: ${{ secrets.TURSO_AUTH_TOKEN }}
|
|
run: |
|
|
OUTPUT=$(pnpm exec netlify deploy \
|
|
--prod \
|
|
--dir=dist \
|
|
--functions=netlify/functions \
|
|
--json 2>&1)
|
|
SITE_URL=$(echo "$OUTPUT" | jq -r '.url // .deploy_url')
|
|
echo "url=$SITE_URL" >> "$GITHUB_OUTPUT"
|
|
|
|
- name: Write deploy summary
|
|
run: |
|
|
echo "**Site URL:** ${{ steps.deploy.outputs.url }}" >> "$GITHUB_STEP_SUMMARY"
|
|
echo "" >> "$GITHUB_STEP_SUMMARY"
|
|
echo "Next steps:" >> "$GITHUB_STEP_SUMMARY"
|
|
echo "1. Open the site URL and sign up as the first admin" >> "$GITHUB_STEP_SUMMARY"
|
|
echo "2. Go to Admin → Storages → Add storage and configure your S3 bucket" >> "$GITHUB_STEP_SUMMARY"
|