diff --git a/mockdata/src/sheets/demo/default-workbook-data-demo.ts b/mockdata/src/sheets/demo/default-workbook-data-demo.ts index 4a06119ba5..08978083d2 100644 --- a/mockdata/src/sheets/demo/default-workbook-data-demo.ts +++ b/mockdata/src/sheets/demo/default-workbook-data-demo.ts @@ -24118,20 +24118,20 @@ export const DEFAULT_WORKBOOK_DATA_DEMO: IWorkbookData = { { name: 'SHEET_UNIVER_THREAD_COMMENT_PLUGIN', data: JSON.stringify({ - 'sheet-0011': [{ text: { textRuns: [], paragraphs: [{ startIndex: 3, paragraphStyle: {} }], sectionBreaks: [{ startIndex: 4 }], dataStream: '123\\n\\r', customRanges: [] }, dT: '2024/05/17 21:16', id: 'jwV0QtHwUbhG3o--iy1qa', ref: 'H9', personId: 'mockId', unitId: 'workbook-01', subUnitId: 'sheet-0011' }], + 'sheet-0011': [{ text: { textRuns: [], paragraphs: [{ startIndex: 3, paragraphStyle: {} }], sectionBreaks: [{ startIndex: 4 }], dataStream: '123\r\n', customRanges: [] }, dT: '2024/05/17 21:16', id: 'jwV0QtHwUbhG3o--iy1qa', ref: 'H9', personId: 'Owner_qxVnhPbQ', unitId: 'workbook-01', subUnitId: 'sheet-0011' }], 'dv-test': [ { text: { textRuns: [], paragraphs: [{ startIndex: 3, paragraphStyle: {} }], sectionBreaks: [{ startIndex: 4 }], - dataStream: '1\\n\\r', + dataStream: '1\r\n', customRanges: [], }, dT: '2024/05/17 21:16', id: '12', ref: 'C6', - personId: 'mockId', + personId: '123', unitId: 'workbook-01', subUnitId: 'dv-test', }, @@ -24140,13 +24140,13 @@ export const DEFAULT_WORKBOOK_DATA_DEMO: IWorkbookData = { textRuns: [], paragraphs: [{ startIndex: 3, paragraphStyle: {} }], sectionBreaks: [{ startIndex: 4 }], - dataStream: '1\\n\\r', + dataStream: '1\r\n', customRanges: [], }, dT: '2024/05/17 21:16', id: '1', ref: 'B6', - personId: 'mockId', + personId: 'Owner_qxVnhPbQ', unitId: 'workbook-01', subUnitId: 'dv-test', }, @@ -24155,13 +24155,13 @@ export const DEFAULT_WORKBOOK_DATA_DEMO: IWorkbookData = { textRuns: [], paragraphs: [{ startIndex: 3, paragraphStyle: {} }], sectionBreaks: [{ startIndex: 4 }], - dataStream: '2\\n\\r', + dataStream: '2\r\n', customRanges: [], }, dT: '2024/05/17 21:16', id: '2', ref: 'B7', - personId: 'mockId', + personId: 'Owner_qxVnhPbQ', unitId: 'workbook-01', subUnitId: 'dv-test', }, @@ -24170,13 +24170,13 @@ export const DEFAULT_WORKBOOK_DATA_DEMO: IWorkbookData = { textRuns: [], paragraphs: [{ startIndex: 3, paragraphStyle: {} }], sectionBreaks: [{ startIndex: 4 }], - dataStream: '3\\n\\r', + dataStream: '3\r\n', customRanges: [], }, dT: '2024/05/17 21:16', id: '3', ref: 'B8', - personId: 'mockId', + personId: 'Owner_qxVnhPbQ', unitId: 'workbook-01', subUnitId: 'dv-test', }, @@ -24185,13 +24185,13 @@ export const DEFAULT_WORKBOOK_DATA_DEMO: IWorkbookData = { textRuns: [], paragraphs: [{ startIndex: 3, paragraphStyle: {} }], sectionBreaks: [{ startIndex: 4 }], - dataStream: '4\\n\\r', + dataStream: '4\r\n', customRanges: [], }, dT: '2024/05/17 21:16', id: '4', ref: 'B9', - personId: 'mockId', + personId: 'Owner_qxVnhPbQ', unitId: 'workbook-01', subUnitId: 'dv-test', }, diff --git a/packages/docs-ui/src/commands/commands/replace-content.command.ts b/packages/docs-ui/src/commands/commands/replace-content.command.ts index e4ad2ea696..f0010cf495 100644 --- a/packages/docs-ui/src/commands/commands/replace-content.command.ts +++ b/packages/docs-ui/src/commands/commands/replace-content.command.ts @@ -38,7 +38,6 @@ export const ReplaceSnapshotCommand: ICommand = { const univerInstanceService = accessor.get(IUniverInstanceService); const commandService = accessor.get(ICommandService); const docSelectionManagerService = accessor.get(DocSelectionManagerService); - const docDataModel = univerInstanceService.getUnit(unitId, UniverInstanceType.UNIVER_DOC); const prevSnapshot = docDataModel?.getSelfOrHeaderFooterModel(segmentId).getSnapshot(); diff --git a/packages/docs-ui/src/services/editor/editor.ts b/packages/docs-ui/src/services/editor/editor.ts index 5c71e91633..9670588ffd 100644 --- a/packages/docs-ui/src/services/editor/editor.ts +++ b/packages/docs-ui/src/services/editor/editor.ts @@ -313,10 +313,8 @@ export class Editor extends Disposable implements IEditor { // Set the new document data. setDocumentData(data: IDocumentData, textRanges: Nullable) { - const { id } = data; - this._commandService.syncExecuteCommand(ReplaceSnapshotCommand.id, { - unitId: id, + unitId: this.getEditorId(), snapshot: data, textRanges, }); diff --git a/packages/thread-comment-ui/src/locale/en-US.ts b/packages/thread-comment-ui/src/locale/en-US.ts index 2170d2c007..0c70b8888d 100644 --- a/packages/thread-comment-ui/src/locale/en-US.ts +++ b/packages/thread-comment-ui/src/locale/en-US.ts @@ -24,6 +24,7 @@ const enUS: typeof zhCN = { filterEmpty: 'No match result', reset: 'Reset Filter', addComment: 'Add Comment', + solved: 'Solved', }, editor: { placeholder: 'Reply or add others with @', diff --git a/packages/thread-comment-ui/src/locale/fa-IR.ts b/packages/thread-comment-ui/src/locale/fa-IR.ts index 6f3202e3f8..17c8ad4d26 100644 --- a/packages/thread-comment-ui/src/locale/fa-IR.ts +++ b/packages/thread-comment-ui/src/locale/fa-IR.ts @@ -24,6 +24,7 @@ const locale: typeof zhCN = { filterEmpty: 'نتیجه ای یافت نشد', reset: 'بازنشانی فیلتر', addComment: 'افزودن نظر', + solved: 'حل شده', }, editor: { placeholder: 'پاسخ یا اضافه کردن دیگران با @', diff --git a/packages/thread-comment-ui/src/locale/fr-FR.ts b/packages/thread-comment-ui/src/locale/fr-FR.ts index 5b5a630ef4..8fac01f0a6 100644 --- a/packages/thread-comment-ui/src/locale/fr-FR.ts +++ b/packages/thread-comment-ui/src/locale/fr-FR.ts @@ -24,6 +24,7 @@ const enUS: typeof zhCN = { filterEmpty: 'Aucun résultat correspondant', reset: 'Réinitialiser le filtre', addComment: 'Ajouter un commentaire', + solved: 'Résolu', }, editor: { placeholder: 'Répondre ou ajouter d\'autres avec @', diff --git a/packages/thread-comment-ui/src/locale/ru-RU.ts b/packages/thread-comment-ui/src/locale/ru-RU.ts index 5fc87dad89..4fd114c411 100644 --- a/packages/thread-comment-ui/src/locale/ru-RU.ts +++ b/packages/thread-comment-ui/src/locale/ru-RU.ts @@ -22,6 +22,7 @@ export default { filterEmpty: 'No match result', reset: 'Reset Filter', addComment: 'Add Comment', + solved: 'Solved', }, editor: { placeholder: 'Reply or add others with @', diff --git a/packages/thread-comment-ui/src/locale/vi-VN.ts b/packages/thread-comment-ui/src/locale/vi-VN.ts index 22142b4b46..7e6537e633 100644 --- a/packages/thread-comment-ui/src/locale/vi-VN.ts +++ b/packages/thread-comment-ui/src/locale/vi-VN.ts @@ -24,6 +24,7 @@ const enUS: typeof zhCN = { filterEmpty: 'Không có kết quả phù hợp', reset: 'Đặt lại', addComment: 'Thêm bình luận', + solved: 'Đã giải quyết', }, editor: { placeholder: 'Phản hồi', diff --git a/packages/thread-comment-ui/src/locale/zh-CN.ts b/packages/thread-comment-ui/src/locale/zh-CN.ts index a0880350ec..1072c57c18 100644 --- a/packages/thread-comment-ui/src/locale/zh-CN.ts +++ b/packages/thread-comment-ui/src/locale/zh-CN.ts @@ -22,6 +22,7 @@ export default { filterEmpty: '没有匹配的结果', reset: '重置', addComment: '添加评论', + solved: '已解决', }, editor: { placeholder: '回复', diff --git a/packages/thread-comment-ui/src/locale/zh-TW.ts b/packages/thread-comment-ui/src/locale/zh-TW.ts index 69e0bf2b9d..2082ea530a 100644 --- a/packages/thread-comment-ui/src/locale/zh-TW.ts +++ b/packages/thread-comment-ui/src/locale/zh-TW.ts @@ -24,6 +24,7 @@ const enUS: typeof zhCN = { filterEmpty: '沒有符合的結果', reset: '重置', addComment: '新增評論', + solved: '已解決', }, editor: { placeholder: '回覆', diff --git a/packages/thread-comment-ui/src/views/thread-comment-editor/index.tsx b/packages/thread-comment-ui/src/views/thread-comment-editor/index.tsx index 3ea73a3a5e..0f928871da 100644 --- a/packages/thread-comment-ui/src/views/thread-comment-editor/index.tsx +++ b/packages/thread-comment-ui/src/views/thread-comment-editor/index.tsx @@ -14,11 +14,11 @@ * limitations under the License. */ -import type { IDocumentBody, IDocumentData } from '@univerjs/core'; +import type { IDocumentBody, IDocumentData, IUser } from '@univerjs/core'; import type { Editor, IKeyboardEventConfig } from '@univerjs/docs-ui'; import type { IThreadComment } from '@univerjs/thread-comment'; import { BuildTextUtils, DOCS_NORMAL_EDITOR_UNIT_ID_KEY, ICommandService, LocaleService, Tools, UniverInstanceType } from '@univerjs/core'; -import { Button } from '@univerjs/design'; +import { Button, clsx } from '@univerjs/design'; import { BreakLineCommand, IEditorService, RichTextEditor } from '@univerjs/docs-ui'; import { KeyCode, useDependency } from '@univerjs/ui'; import React, { forwardRef, useEffect, useImperativeHandle, useMemo, useRef, useState } from 'react'; @@ -82,8 +82,16 @@ export const ThreadCommentEditor = forwardRef ({ reply(text) { - editor.current?.focus(); - editor.current?.setDocumentData(getSnapshot(text)); + if (!editor.current) { + return; + } + editorService.focus(editor.current!.getEditorId() ?? ''); + const documentData = getSnapshot(text); + editor.current?.setDocumentData(documentData, [{ + startOffset: documentData.body!.dataStream.length - 2, + endOffset: documentData.body!.dataStream.length - 2, + collapsed: true, + }]); }, })); @@ -123,7 +131,7 @@ export const ThreadCommentEditor = forwardRef {editing ? ( -
+