diff --git a/common/shared/eslint/index.js b/common/shared/eslint/index.js index 5d99eef80e..43f5b12f37 100644 --- a/common/shared/eslint/index.js +++ b/common/shared/eslint/index.js @@ -4,7 +4,7 @@ exports.baseRules = { 'eol-last': ['error', 'always'], 'import/no-self-import': 'error', 'ts/no-explicit-any': 'warn', - 'style/no-multiple-empty-lines': ['error', { max: 2, maxEOF: 1 }], + 'style/no-multiple-empty-lines': ['error', { max: 1, maxEOF: 1 }], 'style/brace-style': ['warn', '1tbs', { allowSingleLine: true }], 'style/comma-dangle': ['error', { arrays: 'always-multiline', diff --git a/examples/src/data/docs/default-document-data-dreamer.ts b/examples/src/data/docs/default-document-data-dreamer.ts index 03622077ba..dfd86ed969 100644 --- a/examples/src/data/docs/default-document-data-dreamer.ts +++ b/examples/src/data/docs/default-document-data-dreamer.ts @@ -14,7 +14,6 @@ * limitations under the License. */ - import type { IDocumentData } from '@univerjs/core'; import { BooleanNumber, diff --git a/examples/src/plugins/debugger/controllers/menu.ts b/examples/src/plugins/debugger/controllers/menu.ts index 14849ee7d9..c8e80e10de 100644 --- a/examples/src/plugins/debugger/controllers/menu.ts +++ b/examples/src/plugins/debugger/controllers/menu.ts @@ -175,7 +175,6 @@ export function SidebarMenuItemFactory(accessor: IAccessor): IMenuSelectorItem { }; } - export function SetEditableMenuItemFactory(accessor: IAccessor): IMenuSelectorItem { return { id: SetEditable.id, diff --git a/examples/src/sheets/locales.ts b/examples/src/sheets/locales.ts index 9f43626e41..72b9b4e1a5 100644 --- a/examples/src/sheets/locales.ts +++ b/examples/src/sheets/locales.ts @@ -27,7 +27,6 @@ import { enUS as UniverSheetsZenEditorEnUS, ruRU as UniverSheetsZenEditorRuRU } import { enUS as UniverUIEnUS, ruRU as UniverUIRuRU } from '@univerjs/ui'; import { enUS as UniverSheetsFilterUIEnUS, ruRU as UniverSheetsFilterUIRuRU } from '@univerjs/sheets-filter-ui'; - export const locales = { [LocaleType.EN_US]: Tools.deepMerge( UniverSheetsEnUS, diff --git a/examples/src/sheets/main.ts b/examples/src/sheets/main.ts index a66b35a453..6b4c85b870 100644 --- a/examples/src/sheets/main.ts +++ b/examples/src/sheets/main.ts @@ -108,7 +108,6 @@ if (!IS_E2E) { // univer.createUnit(UniverInstanceType.UNIVER_SHEET, DEFAULT_WORKBOOK_DATA_DEMO); // }, 7000); - // debugger plugin univer.registerPlugin(DebuggerPlugin); diff --git a/packages/core/src/services/plugin/plugin-holder.ts b/packages/core/src/services/plugin/plugin-holder.ts index 590c75b751..1424347174 100644 --- a/packages/core/src/services/plugin/plugin-holder.ts +++ b/packages/core/src/services/plugin/plugin-holder.ts @@ -83,7 +83,6 @@ export class PluginHolder extends Disposable { .subscribe((stage) => { this._pluginsRunLifecycle(plugins, stage); })); } - protected _pluginsRunLifecycle(plugins: Plugin[], lifecycle: LifecycleStages): void { plugins.forEach((p) => { switch (lifecycle) { diff --git a/packages/core/src/services/resource-loader/resource-loader.service.ts b/packages/core/src/services/resource-loader/resource-loader.service.ts index 08aaf7a7eb..85f17f645f 100644 --- a/packages/core/src/services/resource-loader/resource-loader.service.ts +++ b/packages/core/src/services/resource-loader/resource-loader.service.ts @@ -24,7 +24,6 @@ import { Disposable, toDisposable } from '../../shared/lifecycle'; import { UniverInstanceType } from '../../common/unit'; import type { IResourceLoaderService } from './type'; - export class ResourceLoaderService extends Disposable implements IResourceLoaderService { constructor( @Inject(IResourceManagerService) private readonly _resourceManagerService: IResourceManagerService, diff --git a/packages/core/src/services/user-manager/user-manager.service.ts b/packages/core/src/services/user-manager/user-manager.service.ts index a8d132a8a7..fe8976e2ba 100644 --- a/packages/core/src/services/user-manager/user-manager.service.ts +++ b/packages/core/src/services/user-manager/user-manager.service.ts @@ -17,7 +17,6 @@ import type { IUser } from '@univerjs/protocol'; import { Subject } from 'rxjs'; - export class UserManagerService { private _model = new Map(); private _userChange$ = new Subject<{ type: 'add' | 'delete'; user: IUser } | { type: 'clear' }>(); diff --git a/packages/core/src/shared/after-init-apply.ts b/packages/core/src/shared/after-init-apply.ts index 74f895ec8e..6b3b7d055d 100644 --- a/packages/core/src/shared/after-init-apply.ts +++ b/packages/core/src/shared/after-init-apply.ts @@ -20,7 +20,6 @@ import type { ICommandService } from '../services/command/command.service'; import { CommandType } from '../services/command/command.service'; import { fromCallback } from './rxjs'; - export const afterInitApply = (commandService: ICommandService) => { return new Promise((res) => { merge( diff --git a/packages/core/src/shared/index.ts b/packages/core/src/shared/index.ts index 3c6f5cf21d..ae46a1e1b1 100644 --- a/packages/core/src/shared/index.ts +++ b/packages/core/src/shared/index.ts @@ -14,7 +14,6 @@ * limitations under the License. */ - export * from './array-search'; export * from './blob'; export * from './color/color'; diff --git a/packages/core/src/shared/range.ts b/packages/core/src/shared/range.ts index dd4d6ca03f..1a4ce726a4 100644 --- a/packages/core/src/shared/range.ts +++ b/packages/core/src/shared/range.ts @@ -39,7 +39,6 @@ export function moveRangeByOffset(range: IRange, refOffsetX: number, refOffsetY: newRange = { ...newRange, startColumn: newRange.startColumn + refOffsetX }; } - if (endAbsoluteRefType === AbsoluteRefType.NONE) { newRange = { ...newRange, endRow: newRange.endRow + refOffsetY, endColumn: newRange.endColumn + refOffsetX }; } else if (endAbsoluteRefType === AbsoluteRefType.COLUMN) { diff --git a/packages/core/src/sheets/worksheet.ts b/packages/core/src/sheets/worksheet.ts index 5819799f64..7a5ce040ed 100644 --- a/packages/core/src/sheets/worksheet.ts +++ b/packages/core/src/sheets/worksheet.ts @@ -14,7 +14,6 @@ * limitations under the License. */ - import type { Nullable } from '../shared'; import { ObjectMatrix, Rectangle, Tools } from '../shared'; import { createRowColIter } from '../shared/row-col-iter'; diff --git a/packages/core/src/univer.ts b/packages/core/src/univer.ts index cac072aecc..9ab61a18f4 100644 --- a/packages/core/src/univer.ts +++ b/packages/core/src/univer.ts @@ -155,7 +155,6 @@ export class Univer { } } - /** Register a plugin into univer. */ registerPlugin>(plugin: T, config?: ConstructorParameters[0]): void { this._pluginService.registerPlugin(plugin, config); diff --git a/packages/data-validation/src/models/data-validation-manager.ts b/packages/data-validation/src/models/data-validation-manager.ts index 1618601049..8042a45106 100644 --- a/packages/data-validation/src/models/data-validation-manager.ts +++ b/packages/data-validation/src/models/data-validation-manager.ts @@ -103,7 +103,6 @@ export class DataValidationManager extends Dispos const rule = { ...oldRule }; - switch (payload.type) { case UpdateRuleType.RANGE: { rule.ranges = payload.payload; diff --git a/packages/docs-ui/src/views/doc-canvas-view.ts b/packages/docs-ui/src/views/doc-canvas-view.ts index 46975d82be..fed67edaf5 100644 --- a/packages/docs-ui/src/views/doc-canvas-view.ts +++ b/packages/docs-ui/src/views/doc-canvas-view.ts @@ -84,7 +84,6 @@ export class DocCanvasView extends RxDisposable { } } - private _addNewRender() { const documentModel = this._currentDocumentModel; diff --git a/packages/engine-formula/src/engine/analysis/__tests__/lexer.spec.ts b/packages/engine-formula/src/engine/analysis/__tests__/lexer.spec.ts index a27e4eb502..57349d66e4 100644 --- a/packages/engine-formula/src/engine/analysis/__tests__/lexer.spec.ts +++ b/packages/engine-formula/src/engine/analysis/__tests__/lexer.spec.ts @@ -71,7 +71,6 @@ describe('lexer test', () => { let formulaCurrentConfigService: IFormulaCurrentConfigService; let lexerTreeBuilder: LexerTreeBuilder; - beforeEach(() => { const testBed = createCommandTestBed(TEST_WORKBOOK_DATA); univer = testBed.univer; @@ -82,7 +81,6 @@ describe('lexer test', () => { formulaCurrentConfigService = get(IFormulaCurrentConfigService); lexerTreeBuilder = get(LexerTreeBuilder); - formulaCurrentConfigService.setExecuteUnitId('test'); formulaCurrentConfigService.setExecuteSubUnitId('sheet1'); diff --git a/packages/engine-formula/src/engine/analysis/lexer-tree-builder.ts b/packages/engine-formula/src/engine/analysis/lexer-tree-builder.ts index 4abaadffe0..82e29d9ad0 100644 --- a/packages/engine-formula/src/engine/analysis/lexer-tree-builder.ts +++ b/packages/engine-formula/src/engine/analysis/lexer-tree-builder.ts @@ -460,7 +460,6 @@ export class LexerTreeBuilder extends Disposable { ); } - private _getCurrentParamIndex(formulaString: string, index: number) { return this._nodeMaker(formulaString, undefined, index); } diff --git a/packages/engine-formula/src/engine/dependency/formula-dependency.ts b/packages/engine-formula/src/engine/dependency/formula-dependency.ts index 03f9e564e6..bcf3075828 100644 --- a/packages/engine-formula/src/engine/dependency/formula-dependency.ts +++ b/packages/engine-formula/src/engine/dependency/formula-dependency.ts @@ -161,14 +161,12 @@ export class FormulaDependencyGenerator extends Disposable { this._formulaASTCache.clear(); } - this._registerFormulas(formulaDataKeys, formulaData, unitData, treeList); this._registerOtherFormulas(otherFormulaData, otherFormulaDataKeys, treeList); this._registerFeatureFormulas(treeList); - const dependencyTreeCache = new FormulaDependencyTreeCache(); for (let i = 0, len = treeList.length; i < len; i++) { @@ -658,7 +656,6 @@ export class FormulaDependencyGenerator extends Disposable { return true; } - if (this._includeOtherFormula(tree) === true) { return true; } diff --git a/packages/engine-formula/src/engine/utils/numfmt-kit.ts b/packages/engine-formula/src/engine/utils/numfmt-kit.ts index de17180e7f..216fb9a39b 100644 --- a/packages/engine-formula/src/engine/utils/numfmt-kit.ts +++ b/packages/engine-formula/src/engine/utils/numfmt-kit.ts @@ -212,7 +212,6 @@ function isAccounting(pattern: string) { return !!currencySymbols.find((code) => pattern.includes(code)) && pattern.startsWith('_('); }; - /** * The number format of the formula inherits the number format of the referenced cell, usually taking the format of the cell at the front position, but some formats have higher priority, there are some special cases. * diff --git a/packages/engine-formula/src/engine/utils/reference.ts b/packages/engine-formula/src/engine/utils/reference.ts index b225c31f66..74c023d129 100644 --- a/packages/engine-formula/src/engine/utils/reference.ts +++ b/packages/engine-formula/src/engine/utils/reference.ts @@ -38,13 +38,11 @@ export function getAbsoluteRefTypeWithSingleString(singleRefString: string) { let isRowAbsolute = remainChar.indexOf('$') > -1; - if (Tools.isStringNumber(remainChar) && isColumnAbsolute && !isRowAbsolute) { isColumnAbsolute = false; isRowAbsolute = true; } - if (isColumnAbsolute && isRowAbsolute) { return AbsoluteRefType.ALL; } @@ -354,7 +352,6 @@ export function isReferenceStrings(refString: string) { }); } - /** * Determine whether the sheet name needs to be wrapped in quotes * Excel will quote the worksheet name if any of the following is true: diff --git a/packages/engine-formula/src/functions/information/isodd/__tests__/isodd.spec.ts b/packages/engine-formula/src/functions/information/isodd/__tests__/isodd.spec.ts index 514cb0ac13..e78f08d5ab 100644 --- a/packages/engine-formula/src/functions/information/isodd/__tests__/isodd.spec.ts +++ b/packages/engine-formula/src/functions/information/isodd/__tests__/isodd.spec.ts @@ -22,7 +22,6 @@ import { ErrorType } from '../../../../basics/error-type'; import { ArrayValueObject } from '../../../../engine/value-object/array-value-object'; import { Isodd } from '../isodd'; - describe('Test isodd function', () => { const testFunction = new Isodd(FUNCTION_NAMES_INFORMATION.ISODD); diff --git a/packages/engine-formula/src/index.ts b/packages/engine-formula/src/index.ts index 4846f704e9..aae9301135 100644 --- a/packages/engine-formula/src/index.ts +++ b/packages/engine-formula/src/index.ts @@ -14,7 +14,6 @@ * limitations under the License. */ - export type { IArrayFormulaRangeType, IArrayFormulaUnitCellType, diff --git a/packages/engine-formula/src/plugin.ts b/packages/engine-formula/src/plugin.ts index d84844a819..16b21d5a54 100644 --- a/packages/engine-formula/src/plugin.ts +++ b/packages/engine-formula/src/plugin.ts @@ -95,7 +95,6 @@ export class UniverFormulaEnginePlugin extends Plugin { // Engine [LexerTreeBuilder], - //Controllers [ FormulaController, diff --git a/packages/engine-render/src/components/docs/doc-component.ts b/packages/engine-render/src/components/docs/doc-component.ts index 8a1f0d0b0a..76307b4886 100644 --- a/packages/engine-render/src/components/docs/doc-component.ts +++ b/packages/engine-render/src/components/docs/doc-component.ts @@ -14,7 +14,6 @@ * limitations under the License. */ - import { RENDER_CLASS_TYPE } from '../../basics/const'; import type { IDocumentSkeletonGlyph, IDocumentSkeletonLine, IDocumentSkeletonPage } from '../../basics/i-document-skeleton-cached'; import { PageLayoutType } from '../../basics/i-document-skeleton-cached'; diff --git a/packages/engine-render/src/components/docs/document.ts b/packages/engine-render/src/components/docs/document.ts index 9ac3892537..3b29cc9995 100644 --- a/packages/engine-render/src/components/docs/document.ts +++ b/packages/engine-render/src/components/docs/document.ts @@ -14,7 +14,6 @@ * limitations under the License. */ - import './extensions'; import type { Nullable, Observer } from '@univerjs/core'; @@ -165,7 +164,6 @@ export class Documents extends DocComponent { return (this.getScene() as Scene).getEngine(); } - override draw(ctx: UniverRenderingContext, bounds?: IViewportBound) { const skeletonData = this.getSkeleton()?.getSkeletonData(); @@ -424,7 +422,6 @@ export class Documents extends DocComponent { alignOffset ); - const extensionOffset: IExtensionConfig = { originTranslate, spanStartPoint, diff --git a/packages/engine-render/src/components/docs/layout/block/paragraph/layout-ruler.ts b/packages/engine-render/src/components/docs/layout/block/paragraph/layout-ruler.ts index 31a448d248..f9222cc28b 100644 --- a/packages/engine-render/src/components/docs/layout/block/paragraph/layout-ruler.ts +++ b/packages/engine-render/src/components/docs/layout/block/paragraph/layout-ruler.ts @@ -1020,7 +1020,6 @@ function __getDrawingPosition( return drawings; } - // 更新 paragraphAffectSkeDrawings 的绝对位置,相对于段落的第一行布局 function __updateDrawingPosition( column: IDocumentSkeletonColumn, diff --git a/packages/engine-render/src/components/docs/layout/block/paragraph/shaping.ts b/packages/engine-render/src/components/docs/layout/block/paragraph/shaping.ts index 697a2c6fc6..2cf739e886 100644 --- a/packages/engine-render/src/components/docs/layout/block/paragraph/shaping.ts +++ b/packages/engine-render/src/components/docs/layout/block/paragraph/shaping.ts @@ -103,7 +103,6 @@ export interface IShapedText { breakPointType: BreakPointType; } - export function shaping( ctx: ILayoutContext, content: string, diff --git a/packages/engine-render/src/components/docs/layout/doc-skeleton.ts b/packages/engine-render/src/components/docs/layout/doc-skeleton.ts index 446f115bbf..2f900eea27 100644 --- a/packages/engine-render/src/components/docs/layout/doc-skeleton.ts +++ b/packages/engine-render/src/components/docs/layout/doc-skeleton.ts @@ -257,7 +257,6 @@ export class DocumentSkeleton extends Skeleton { return glyphGroup[glyph]; } - findNodeByCoord( coord: Vector2, pageLayoutType: PageLayoutType, diff --git a/packages/engine-render/src/components/docs/layout/hyphenation/hyphen.ts b/packages/engine-render/src/components/docs/layout/hyphenation/hyphen.ts index 528fbdbf74..85a9e94653 100644 --- a/packages/engine-render/src/components/docs/layout/hyphenation/hyphen.ts +++ b/packages/engine-render/src/components/docs/layout/hyphenation/hyphen.ts @@ -73,7 +73,6 @@ export class Hyphen implements IDisposable { let pattern = await import(`./patterns/${lang}.ts`); pattern = pattern[snackToPascal(lang)]; - this._patterns.set(lang, parsePattern(pattern)); this._loadExceptionsToCache(lang, pattern); } @@ -100,7 +99,6 @@ export class Hyphen implements IDisposable { const { levelsTable, pattern } = this._patterns.get(lang)!; - const levels = new Array(word.length + 1).fill(0); const loweredText = (`.${word.toLocaleLowerCase()}.`).split(''); const [nextSlice, isFirstCharacter] = createStringSlicer(loweredText); @@ -167,7 +165,6 @@ export class Hyphen implements IDisposable { let hyphenatedText = ''; - for (let i = 0; i < levels.length; i++) { hyphenatedText += (levels[i] % 2 === 1 ? '-' : '') + word.charAt(i); } diff --git a/packages/engine-render/src/components/docs/layout/shaping-engine/text-shaping.ts b/packages/engine-render/src/components/docs/layout/shaping-engine/text-shaping.ts index 3dfdbca76f..fa45d0a0de 100644 --- a/packages/engine-render/src/components/docs/layout/shaping-engine/text-shaping.ts +++ b/packages/engine-render/src/components/docs/layout/shaping-engine/text-shaping.ts @@ -45,7 +45,6 @@ export interface IOpenTypeGlyphInfo { const fontCache = new Map(); const glyphCache: Map = new Map(); - function shapeChunk( content: string, charPosition: number, diff --git a/packages/engine-render/src/components/docs/layout/tools.ts b/packages/engine-render/src/components/docs/layout/tools.ts index df2cc3f10f..896c33871e 100644 --- a/packages/engine-render/src/components/docs/layout/tools.ts +++ b/packages/engine-render/src/components/docs/layout/tools.ts @@ -499,7 +499,6 @@ export function columnIterator( } } - export function getPositionHorizon( positionH: IObjectPositionH, column: IDocumentSkeletonColumn, @@ -594,7 +593,6 @@ export function getPositionHorizon( } } - export function getPositionVertical( positionV: IObjectPositionV, page: IDocumentSkeletonPage, diff --git a/packages/engine-render/src/components/sheets/sheet-skeleton.ts b/packages/engine-render/src/components/sheets/sheet-skeleton.ts index 9f19f5cfcb..c13cf6623e 100644 --- a/packages/engine-render/src/components/sheets/sheet-skeleton.ts +++ b/packages/engine-render/src/components/sheets/sheet-skeleton.ts @@ -882,7 +882,6 @@ export class SpreadsheetSkeleton extends Skeleton { return column; } - /** * * @param offsetY scaled offset y diff --git a/packages/engine-render/src/render-manager/render-manager.service.ts b/packages/engine-render/src/render-manager/render-manager.service.ts index 3b122f3590..ef4d562a67 100644 --- a/packages/engine-render/src/render-manager/render-manager.service.ts +++ b/packages/engine-render/src/render-manager/render-manager.service.ts @@ -52,7 +52,6 @@ const DEFAULT_SCENE_SIZE = { width: 1500, height: 1000 }; const SCENE_NAMESPACE = '_UNIVER_SCENE_'; - export class RenderManagerService extends Disposable implements IRenderManagerService { private _defaultEngine!: Engine; diff --git a/packages/engine-render/src/shape/shape.ts b/packages/engine-render/src/shape/shape.ts index 9c92fa7ad8..a232f112de 100644 --- a/packages/engine-render/src/shape/shape.ts +++ b/packages/engine-render/src/shape/shape.ts @@ -304,7 +304,6 @@ export abstract class Shape extends BaseObject { ctx.strokeStyle = stroke!; } - override render(mainCtx: UniverRenderingContext, bounds?: IViewportBound) { if (!this.visible) { this.makeDirty(false); diff --git a/packages/facade/src/apis/__tests__/create-test-bed.ts b/packages/facade/src/apis/__tests__/create-test-bed.ts index 5107b36bda..78854ade5b 100644 --- a/packages/facade/src/apis/__tests__/create-test-bed.ts +++ b/packages/facade/src/apis/__tests__/create-test-bed.ts @@ -105,7 +105,6 @@ export interface ITestBed { injector: Injector; } - export function createFacadeTestBed(workbookData?: IWorkbookData, dependencies?: Dependency[]): ITestBed { const univer = new Univer(); const injector = univer.__getInjector(); diff --git a/packages/facade/src/apis/sheets/f-workbook.ts b/packages/facade/src/apis/sheets/f-workbook.ts index 551adc65d3..f502e78a81 100644 --- a/packages/facade/src/apis/sheets/f-workbook.ts +++ b/packages/facade/src/apis/sheets/f-workbook.ts @@ -143,7 +143,6 @@ export class FWorkbook { return this._injector.createInstance(FWorksheet, this._workbook, worksheet); } - /** * Sets the given worksheet to be the active worksheet in the workbook. * @param sheet The worksheet to set as the active worksheet. diff --git a/packages/image/src/controllers/image.load.controller.ts b/packages/image/src/controllers/image.load.controller.ts index 5d5e946811..f29ebb7589 100644 --- a/packages/image/src/controllers/image.load.controller.ts +++ b/packages/image/src/controllers/image.load.controller.ts @@ -70,7 +70,6 @@ export class ImageLoadController extends Disposable { ); } - private _floatingObjectListener() { this.disposeWithMe( toDisposable( diff --git a/packages/sheets-conditional-formatting/src/services/calculate-unit/utils.ts b/packages/sheets-conditional-formatting/src/services/calculate-unit/utils.ts index 14b54e13e4..a187dc2734 100644 --- a/packages/sheets-conditional-formatting/src/services/calculate-unit/utils.ts +++ b/packages/sheets-conditional-formatting/src/services/calculate-unit/utils.ts @@ -288,7 +288,6 @@ export const getColorScaleFromValue = (colorList: { color: ColorKit; value: numb } }; - export const filterRange = (ranges: IRange[], maxRow: number, maxCol: number): IRange[] => { return ranges.map((range) => { if (range.startColumn > maxCol || range.startRow > maxRow) { diff --git a/packages/sheets-data-validation/src/controllers/dv-render.controller.ts b/packages/sheets-data-validation/src/controllers/dv-render.controller.ts index e86e76417f..e08ed27d46 100644 --- a/packages/sheets-data-validation/src/controllers/dv-render.controller.ts +++ b/packages/sheets-data-validation/src/controllers/dv-render.controller.ts @@ -14,7 +14,6 @@ * limitations under the License. */ - import type { ICellDataForSheetInterceptor, ICellRenderContext, Workbook } from '@univerjs/core'; import { DataValidationRenderMode, DataValidationStatus, DataValidationType, ICommandService, IUniverInstanceService, LifecycleStages, OnLifecycle, RxDisposable, sequenceExecute, UniverInstanceType, WrapStrategy } from '@univerjs/core'; import { DataValidationModel, DataValidatorRegistryService } from '@univerjs/data-validation'; diff --git a/packages/sheets-data-validation/src/controllers/dv.controller.ts b/packages/sheets-data-validation/src/controllers/dv.controller.ts index e15c278ed3..18923080a7 100644 --- a/packages/sheets-data-validation/src/controllers/dv.controller.ts +++ b/packages/sheets-data-validation/src/controllers/dv.controller.ts @@ -98,7 +98,6 @@ export class DataValidationController extends RxDisposable { this.disposeWithMe(disposableCollection); } - private _initCommandInterceptor() { this._sheetInterceptorService.interceptCommand({ getMutations: (commandInfo) => { diff --git a/packages/sheets-data-validation/src/models/sheet-data-validation-manager.ts b/packages/sheets-data-validation/src/models/sheet-data-validation-manager.ts index 12efdfd3b1..337d32c9b7 100644 --- a/packages/sheets-data-validation/src/models/sheet-data-validation-manager.ts +++ b/packages/sheets-data-validation/src/models/sheet-data-validation-manager.ts @@ -70,7 +70,6 @@ export class SheetDataValidationManager extends DataValidationManager debounce( 275 ); - export function DataValidationDetail() { const [key, setKey] = useState(0); const dataValidationPanelService = useDependency(DataValidationPanelService); diff --git a/packages/sheets-data-validation/src/views/formula-input/list-formula-input.tsx b/packages/sheets-data-validation/src/views/formula-input/list-formula-input.tsx index 59518a6204..19252735e3 100644 --- a/packages/sheets-data-validation/src/views/formula-input/list-formula-input.tsx +++ b/packages/sheets-data-validation/src/views/formula-input/list-formula-input.tsx @@ -141,7 +141,6 @@ const Template = (props: { item: IDropdownItem; commonProps: any; style?: React. ); }; - export function ListFormulaInput(props: IFormulaInputProps) { const { value, onChange: _onChange = () => { /* empty */ }, unitId, subUnitId, validResult, showError, ruleId } = props; const { formula1 = '', formula2 = '' } = value || {}; @@ -287,7 +286,6 @@ export function ListFormulaInput(props: IFormulaInputProps) { return; } - onChange?.({ formula1: isFormulaString(str) ? str : '', formula2, diff --git a/packages/sheets-data-validation/src/widgets/checkbox-widget.ts b/packages/sheets-data-validation/src/widgets/checkbox-widget.ts index 74394d8476..51a95183db 100644 --- a/packages/sheets-data-validation/src/widgets/checkbox-widget.ts +++ b/packages/sheets-data-validation/src/widgets/checkbox-widget.ts @@ -166,7 +166,6 @@ export class CheckboxRender implements IBaseDataValidationWidget { return false; } - async onPointerDown(info: ICellRenderContext, evt: IPointerEvent | IMouseEvent) { if (evt.button === 2) { return; diff --git a/packages/sheets-data-validation/src/widgets/dropdown-widget.ts b/packages/sheets-data-validation/src/widgets/dropdown-widget.ts index 52e972f3b9..1e657c6892 100644 --- a/packages/sheets-data-validation/src/widgets/dropdown-widget.ts +++ b/packages/sheets-data-validation/src/widgets/dropdown-widget.ts @@ -205,7 +205,6 @@ export class DropdownWidget implements IBaseDataValidationWidget { const map = this._ensureMap(subUnitId); const key = this._generateKey(row, col); - const list = validator.getListWithColor(rule); const value = getCellValueOrigin(data); const valueStr = `${value ?? ''}`; diff --git a/packages/sheets-filter-ui/src/commands/__tests__/sheets-filter.operation.spec.ts b/packages/sheets-filter-ui/src/commands/__tests__/sheets-filter.operation.spec.ts index 0ae7be731a..53b88fb929 100644 --- a/packages/sheets-filter-ui/src/commands/__tests__/sheets-filter.operation.spec.ts +++ b/packages/sheets-filter-ui/src/commands/__tests__/sheets-filter.operation.spec.ts @@ -34,7 +34,6 @@ const SetCellEditVisibleOperation: IOperation }, }; - function testWorkbookDataFactory(): IWorkbookData { return { id: 'test', diff --git a/packages/sheets-filter-ui/src/services/__tests__/sheets-filter-panel.service.spec.ts b/packages/sheets-filter-ui/src/services/__tests__/sheets-filter-panel.service.spec.ts index 62dcd0bfb6..af9312a01f 100644 --- a/packages/sheets-filter-ui/src/services/__tests__/sheets-filter-panel.service.spec.ts +++ b/packages/sheets-filter-ui/src/services/__tests__/sheets-filter-panel.service.spec.ts @@ -31,7 +31,6 @@ import { FilterConditionItems } from '../../models/conditions'; import { ExtendCustomFilterOperator } from '../../models/extended-operators'; import { SetSheetsFilterCriteriaCommand } from '../../commands/sheets-filter.command'; - const SetCellEditVisibleOperation: IOperation = { id: 'sheet.operation.set-cell-edit-visible', type: CommandType.OPERATION, @@ -40,7 +39,6 @@ const SetCellEditVisibleOperation: IOperation }, }; - function createSheetsFilterPanelServiceTestBed(workbookData: IWorkbookData) { const univer = new Univer(); const injector = univer.__getInjector(); diff --git a/packages/sheets-filter/src/controllers/sheets-fiter.controller.ts b/packages/sheets-filter/src/controllers/sheets-fiter.controller.ts index d5db0490bc..e7ab380d1c 100644 --- a/packages/sheets-filter/src/controllers/sheets-fiter.controller.ts +++ b/packages/sheets-filter/src/controllers/sheets-fiter.controller.ts @@ -26,7 +26,6 @@ import { ReCalcSheetsFilterMutation, RemoveSheetsFilterMutation, SetSheetsFilter import type { FilterColumn } from '../models/filter-model'; import { mergeSetFilterCriteria } from '../utils'; - @OnLifecycle(LifecycleStages.Ready, SheetsFilterController) export class SheetsFilterController extends Disposable { constructor( @@ -544,7 +543,6 @@ export class SheetsFilterController extends Disposable { const setNewFilterRange = { id: SetSheetsFilterRangeMutation.id, params: { unitId, subUnitId, range: newFilterRange } as ISetSheetsFilterRangeMutationParams }; const setOldFilterRange = { id: SetSheetsFilterRangeMutation.id, params: { unitId, subUnitId, range: filterRange } as ISetSheetsFilterRangeMutationParams }; - redos.push(removeFilter, setNewFilterRange); undos.push(removeFilter, setOldFilterRange); diff --git a/packages/sheets-formula/src/controllers/active-dirty.controller.ts b/packages/sheets-formula/src/controllers/active-dirty.controller.ts index 89bf61a435..5ff4b96ac9 100644 --- a/packages/sheets-formula/src/controllers/active-dirty.controller.ts +++ b/packages/sheets-formula/src/controllers/active-dirty.controller.ts @@ -176,7 +176,6 @@ export class ActiveDirtyController extends Disposable { }); } - private _initialSheet() { this._activeDirtyManagerService.register(RemoveSheetMutation.id, { commandId: RemoveSheetMutation.id, diff --git a/packages/sheets-formula/src/controllers/prompt.controller.ts b/packages/sheets-formula/src/controllers/prompt.controller.ts index d50ba5334a..722664b978 100644 --- a/packages/sheets-formula/src/controllers/prompt.controller.ts +++ b/packages/sheets-formula/src/controllers/prompt.controller.ts @@ -1885,7 +1885,6 @@ export class PromptController extends Disposable { ); } - private _moveInEditor(keycode: Nullable) { if (keycode == null) { return; diff --git a/packages/sheets-formula/src/controllers/trigger-calculation.controller.ts b/packages/sheets-formula/src/controllers/trigger-calculation.controller.ts index a9b35a8642..2af4e97ec9 100644 --- a/packages/sheets-formula/src/controllers/trigger-calculation.controller.ts +++ b/packages/sheets-formula/src/controllers/trigger-calculation.controller.ts @@ -278,7 +278,6 @@ export class TriggerCalculationController extends Disposable { debouncedPushTask(completedArrayFormulasCount); } - // if (totalArrayFormulasToCalculate > 0) { // console.warn( // `Stage ${stage} Array formula.There are ${totalArrayFormulasToCalculate} functions to be executed, ${completedArrayFormulasCount} complete.` @@ -331,7 +330,6 @@ export class TriggerCalculationController extends Disposable { this._formulaCalculationDoneCount = 0; } - console.warn(`execution result${result}`); } }) diff --git a/packages/sheets-formula/src/controllers/utils/__tests__/offset-formula-data.spec.ts b/packages/sheets-formula/src/controllers/utils/__tests__/offset-formula-data.spec.ts index 497e6ae93a..79769873c6 100644 --- a/packages/sheets-formula/src/controllers/utils/__tests__/offset-formula-data.spec.ts +++ b/packages/sheets-formula/src/controllers/utils/__tests__/offset-formula-data.spec.ts @@ -14,7 +14,6 @@ * limitations under the License. */ - import { describe, expect, it } from 'vitest'; import { removeFormulaData } from '../offset-formula-data'; @@ -122,7 +121,6 @@ describe('Utils offset formula data test', () => { }); }); - it('remove blank object', () => { const unitId = 'workbook-01'; const formulaData = {}; diff --git a/packages/sheets-ui/src/commands/commands/insert-range-move-down-confirm.command.ts b/packages/sheets-ui/src/commands/commands/insert-range-move-down-confirm.command.ts index c7bba16769..84309b1ab1 100644 --- a/packages/sheets-ui/src/commands/commands/insert-range-move-down-confirm.command.ts +++ b/packages/sheets-ui/src/commands/commands/insert-range-move-down-confirm.command.ts @@ -69,7 +69,6 @@ export const InsertRangeMoveDownConfirmCommand: ICommand = { return commandService.executeCommand(InsertRangeMoveDownCommand.id); } - const result = await confirmService.confirm({ id: InsertRangeMoveDownConfirmCommand.id, title: { title: localeService.t('merge.confirm.waring') }, diff --git a/packages/sheets-ui/src/controllers/auto-fill.controller.ts b/packages/sheets-ui/src/controllers/auto-fill.controller.ts index ffbd21f636..6d4926d603 100644 --- a/packages/sheets-ui/src/controllers/auto-fill.controller.ts +++ b/packages/sheets-ui/src/controllers/auto-fill.controller.ts @@ -169,7 +169,6 @@ export class AutoFillController extends Disposable { this._autoFillService.setShowMenu(false); } - private _onSelectionControlFillChanged() { const disposableCollection = new DisposableCollection(); const addListener = (disposableCollection: DisposableCollection) => { diff --git a/packages/sheets-ui/src/controllers/cell-custom-render.controller.ts b/packages/sheets-ui/src/controllers/cell-custom-render.controller.ts index 2aaf0b5309..c75c5a372a 100644 --- a/packages/sheets-ui/src/controllers/cell-custom-render.controller.ts +++ b/packages/sheets-ui/src/controllers/cell-custom-render.controller.ts @@ -22,7 +22,6 @@ import { Inject } from '@wendellhu/redi'; import type { ISheetSkeletonManagerParam } from '../services/sheet-skeleton-manager.service'; import { SheetSkeletonManagerService } from '../services/sheet-skeleton-manager.service'; - /** * @todo RenderUnit */ @@ -43,7 +42,6 @@ export class CellCustomRenderController extends Disposable implements IRenderCon this._initEventBinding(); } - // eslint-disable-next-line max-lines-per-function private _initEventBinding() { const disposableCollection = new DisposableCollection(); diff --git a/packages/sheets-ui/src/controllers/force-string-render.controller.ts b/packages/sheets-ui/src/controllers/force-string-render.controller.ts index 4c730c1009..9ea3643522 100644 --- a/packages/sheets-ui/src/controllers/force-string-render.controller.ts +++ b/packages/sheets-ui/src/controllers/force-string-render.controller.ts @@ -14,7 +14,6 @@ * limitations under the License. */ - import { CellValueType, isRealNum, LifecycleStages, OnLifecycle, RxDisposable } from '@univerjs/core'; import type { Workbook } from '@univerjs/core'; import { Inject } from '@wendellhu/redi'; diff --git a/packages/sheets-ui/src/controllers/format-painter/format-painter.controller.ts b/packages/sheets-ui/src/controllers/format-painter/format-painter.controller.ts index 59be8c2d3e..db60175b65 100644 --- a/packages/sheets-ui/src/controllers/format-painter/format-painter.controller.ts +++ b/packages/sheets-ui/src/controllers/format-painter/format-painter.controller.ts @@ -50,7 +50,6 @@ export class FormatPainterController extends Disposable { this._commandExecutedListener(); } - private _commandExecutedListener() { this.disposeWithMe( toDisposable( diff --git a/packages/sheets-ui/src/controllers/menu/menu.ts b/packages/sheets-ui/src/controllers/menu/menu.ts index 65a9f620d8..e09592c328 100644 --- a/packages/sheets-ui/src/controllers/menu/menu.ts +++ b/packages/sheets-ui/src/controllers/menu/menu.ts @@ -1103,7 +1103,6 @@ export function ShowRowMenuItemFactory(accessor: IAccessor): IMenuButtonItem { }); } - const disposable = commandService.onCommandExecuted((command) => { if (affectedCommands.findIndex((c) => c === command.id) !== -1) subscriber.next(!hasHiddenRowsInSelections()); }); diff --git a/packages/sheets-ui/src/controllers/render-controllers/header-menu.render-controller.ts b/packages/sheets-ui/src/controllers/render-controllers/header-menu.render-controller.ts index 39a89c15d9..4526fbe0d8 100644 --- a/packages/sheets-ui/src/controllers/render-controllers/header-menu.render-controller.ts +++ b/packages/sheets-ui/src/controllers/render-controllers/header-menu.render-controller.ts @@ -76,7 +76,6 @@ export class HeaderMenuRenderController extends Disposable implements IRenderCon const spreadsheetColumnHeader = this._context.components.get(SHEET_VIEW_KEY.COLUMN) as SpreadsheetColumnHeader; const spreadsheetRowHeader = this._context.components.get(SHEET_VIEW_KEY.ROW) as SpreadsheetHeader; - this._observers.forEach((observer) => { spreadsheetRowHeader.onPointerEnterObserver.remove(observer); spreadsheetRowHeader.onPointerMoveObserver.remove(observer); @@ -110,7 +109,6 @@ export class HeaderMenuRenderController extends Disposable implements IRenderCon const spreadsheetColumnHeader = this._context.components.get(SHEET_VIEW_KEY.COLUMN) as SpreadsheetColumnHeader; const spreadsheetRowHeader = this._context.components.get(SHEET_VIEW_KEY.ROW) as SpreadsheetHeader; - const eventBindingObject = initialType === HEADER_HOVER_TYPE.ROW ? spreadsheetRowHeader : spreadsheetColumnHeader; diff --git a/packages/sheets-ui/src/controllers/render-controllers/header-resize.render-controller.ts b/packages/sheets-ui/src/controllers/render-controllers/header-resize.render-controller.ts index baed180401..b998850d11 100644 --- a/packages/sheets-ui/src/controllers/render-controllers/header-resize.render-controller.ts +++ b/packages/sheets-ui/src/controllers/render-controllers/header-resize.render-controller.ts @@ -59,7 +59,6 @@ enum HEADER_RESIZE_TYPE { COLUMN, } - export class HeaderResizeRenderController extends Disposable implements IRenderController { private _currentRow: number = 0; @@ -259,7 +258,6 @@ export class HeaderResizeRenderController extends Disposable implements IRenderC return; } - this.disposeWithMe( toDisposable( eventBindingObject.onPointerEnterObserver.add(() => { @@ -443,7 +441,6 @@ export class HeaderResizeRenderController extends Disposable implements IRenderC this._upObserver = scene.onPointerUpObserver.add((upEvt: IPointerEvent | IMouseEvent) => { const scene = this._context.scene; - this._clearObserverEvent(); this._resizeHelperShape?.dispose(); this._resizeHelperShape = null; diff --git a/packages/sheets-ui/src/controllers/render-controllers/selection.render-controller.ts b/packages/sheets-ui/src/controllers/render-controllers/selection.render-controller.ts index 21a4100abf..c12d931687 100644 --- a/packages/sheets-ui/src/controllers/render-controllers/selection.render-controller.ts +++ b/packages/sheets-ui/src/controllers/render-controllers/selection.render-controller.ts @@ -117,7 +117,6 @@ export class SelectionRenderController extends Disposable implements IRenderCont formulaOrRefString = formulaOrRefString.substring(1); } - const result = isReferenceStrings(formulaOrRefString); if (!result) { @@ -126,7 +125,6 @@ export class SelectionRenderController extends Disposable implements IRenderCont const selections = await this._getSelections(workbook, unitId, formulaOrRefString); - this._selectionManagerService.replace(selections); this._commandService.executeCommand(ScrollToCellOperation.id, selections[0].range); diff --git a/packages/sheets-ui/src/controllers/render-controllers/zoom.render-controller.ts b/packages/sheets-ui/src/controllers/render-controllers/zoom.render-controller.ts index 56af895471..9b307b9062 100644 --- a/packages/sheets-ui/src/controllers/render-controllers/zoom.render-controller.ts +++ b/packages/sheets-ui/src/controllers/render-controllers/zoom.render-controller.ts @@ -95,7 +95,6 @@ export class SheetsZoomRenderController extends Disposable implements IRenderCon })); } - private _updateViewZoom(zoomRatio: number) { const sheetObject = this._getSheetObject(); sheetObject?.scene.scale(zoomRatio, zoomRatio); diff --git a/packages/sheets-ui/src/services/auto-fill/auto-fill.service.ts b/packages/sheets-ui/src/services/auto-fill/auto-fill.service.ts index f7029d981c..b7ed2cc2a9 100644 --- a/packages/sheets-ui/src/services/auto-fill/auto-fill.service.ts +++ b/packages/sheets-ui/src/services/auto-fill/auto-fill.service.ts @@ -313,7 +313,6 @@ export class AutoFillService extends Disposable implements IAutoFillService { } }); - const result = redos.every((m) => this._commandService.syncExecuteCommand(m.id, m.params)); if (result) { // add to undo redo services diff --git a/packages/sheets-ui/src/services/clipboard/clipboard.service.ts b/packages/sheets-ui/src/services/clipboard/clipboard.service.ts index 9f5c30a8f4..e4b232e2f2 100644 --- a/packages/sheets-ui/src/services/clipboard/clipboard.service.ts +++ b/packages/sheets-ui/src/services/clipboard/clipboard.service.ts @@ -411,7 +411,6 @@ export class SheetClipboardService extends Disposable implements ISheetClipboard return false; } - // 2. get filtered rows in the target pasting area and get the final pasting matrix // we also handle transpose pasting at this step // note: handle transpose before filtering @@ -430,7 +429,6 @@ export class SheetClipboardService extends Disposable implements ISheetClipboard return false; } - const worksheet = this._univerInstanceService .getUniverSheetInstance(pasteTarget.unitId) ?.getSheetBySheetId(pasteTarget.subUnitId); @@ -484,7 +482,6 @@ export class SheetClipboardService extends Disposable implements ISheetClipboard } }); - const pasteTarget = this._getPastedRange( cellMatrix ); @@ -1009,7 +1006,6 @@ export class SheetClipboardService extends Disposable implements ISheetClipboard }; } - /** * Determine whether the cells starting from the upper left corner of the range (merged or non-merged or combined) are consistent with the size of the original data * @param cellMatrix diff --git a/packages/sheets-ui/src/services/clipboard/html-to-usm/converter.ts b/packages/sheets-ui/src/services/clipboard/html-to-usm/converter.ts index 3167cfa4d9..bce1db2073 100644 --- a/packages/sheets-ui/src/services/clipboard/html-to-usm/converter.ts +++ b/packages/sheets-ui/src/services/clipboard/html-to-usm/converter.ts @@ -408,7 +408,6 @@ function parseColGroup(raw: string): IClipboardPropertyItem[] | null { const COLGROUP_TAG_REGEX = /(.*?)<\/colgroup>/; const colgroupMatch = raw.match(COLGROUP_TAG_REGEX); - const COL_TAG_REGEX = //g; let colMatches; if (colgroupMatch?.[2]) { @@ -590,7 +589,6 @@ function extractStyleProperty(styleString?: string, propertyName?: string) { return null; } - function getCellStyle(cell: Element) { let cellStyle = ''; const hasClass = cell.getAttribute('class'); diff --git a/packages/sheets-ui/src/services/clipboard/html-to-usm/parse-node-style.ts b/packages/sheets-ui/src/services/clipboard/html-to-usm/parse-node-style.ts index 5bb7fc01b1..e7744c173b 100644 --- a/packages/sheets-ui/src/services/clipboard/html-to-usm/parse-node-style.ts +++ b/packages/sheets-ui/src/services/clipboard/html-to-usm/parse-node-style.ts @@ -61,7 +61,6 @@ export function extractNodeStyle(node: HTMLElement, predefinedStyles?: CSSStyleD return docStyles; } - // eslint-disable-next-line complexity function parseStyleByProperty(styles: CSSStyleDeclaration, docStyles: ITextStyle) { for (let i = 0; i < styles.length; i++) { diff --git a/packages/sheets-ui/src/services/clipboard/utils.ts b/packages/sheets-ui/src/services/clipboard/utils.ts index 487e62c77f..11334a3224 100644 --- a/packages/sheets-ui/src/services/clipboard/utils.ts +++ b/packages/sheets-ui/src/services/clipboard/utils.ts @@ -153,7 +153,6 @@ export function mergeSetRangeValues(mutations: IMutationInfo[]) { return newMutations; } - export function rangeIntersectWithDiscreteRange(range: IRange, discrete: IDiscreteRange) { const { startRow, endRow, startColumn, endColumn } = range; for (let i = startRow; i <= endRow; i++) { @@ -165,7 +164,6 @@ export function rangeIntersectWithDiscreteRange(range: IRange, discrete: IDiscre } } - export function discreteRangeContainsRange(discrete: IDiscreteRange, range: IRange) { const { startRow, endRow, startColumn, endColumn } = range; for (let i = startRow; i <= endRow; i++) { diff --git a/packages/sheets-ui/src/services/sheet-skeleton-manager.service.ts b/packages/sheets-ui/src/services/sheet-skeleton-manager.service.ts index 73f3f62db7..1feaf426fd 100644 --- a/packages/sheets-ui/src/services/sheet-skeleton-manager.service.ts +++ b/packages/sheets-ui/src/services/sheet-skeleton-manager.service.ts @@ -35,7 +35,6 @@ export interface ISheetSkeletonManagerSearch { commandId?: string; // WTF: why? } - // TODO@wzhudev: this should be moved to a `RenderUnit` as well. /** diff --git a/packages/sheets-ui/src/views/cell-alert/CellAlertPopup.tsx b/packages/sheets-ui/src/views/cell-alert/CellAlertPopup.tsx index b8f1bd3497..b974498a9e 100644 --- a/packages/sheets-ui/src/views/cell-alert/CellAlertPopup.tsx +++ b/packages/sheets-ui/src/views/cell-alert/CellAlertPopup.tsx @@ -36,7 +36,6 @@ export function CellAlert({ popup }: { popup: ICanvasPopup }) { [CellAlertType.WARNING]: , }; - return (
diff --git a/packages/sheets-ui/src/views/defined-name/DefinedNameInput.tsx b/packages/sheets-ui/src/views/defined-name/DefinedNameInput.tsx index 17bf35ddf3..12197b1c0a 100644 --- a/packages/sheets-ui/src/views/defined-name/DefinedNameInput.tsx +++ b/packages/sheets-ui/src/views/defined-name/DefinedNameInput.tsx @@ -89,7 +89,6 @@ export const DefinedNameInput = (props: IDefinedNameInputProps) => { value: SCOPE_WORKBOOK_VALUE, }]; - const isFormula = (token: string) => { return !isReferenceStrings(token); }; @@ -114,7 +113,6 @@ export const DefinedNameInput = (props: IDefinedNameInputProps) => { setValidString(''); }, [state]); - workbook.getSheetOrders().forEach((sheetId) => { const sheet = workbook.getSheetBySheetId(sheetId); options.push({ diff --git a/packages/sheets-ui/src/views/operate-container/AutoFillPopupMenu.tsx b/packages/sheets-ui/src/views/operate-container/AutoFillPopupMenu.tsx index 4b4dd3d8c8..279ccd4444 100644 --- a/packages/sheets-ui/src/views/operate-container/AutoFillPopupMenu.tsx +++ b/packages/sheets-ui/src/views/operate-container/AutoFillPopupMenu.tsx @@ -73,7 +73,6 @@ export const AutoFillPopupMenu: React.FC<{}> = () => { }; const forceUpdate = useUpdate(); - useEffect(() => { const disposable = commandService.onCommandExecuted((command: ICommandInfo, options?: IExecutionOptions) => { if (command.id === SetScrollOperation.id) { diff --git a/packages/sheets/src/commands/commands/remove-row-col.command.ts b/packages/sheets/src/commands/commands/remove-row-col.command.ts index e13e237d1d..eef39f4f9e 100644 --- a/packages/sheets/src/commands/commands/remove-row-col.command.ts +++ b/packages/sheets/src/commands/commands/remove-row-col.command.ts @@ -76,7 +76,6 @@ export const RemoveRowCommand: ICommand = { endColumn: Math.max(worksheet.getMaxColumns() - 1, 0), }; - const filterOutRowsInRemove: number[] = []; for (let i = totalRange.startRow; i <= totalRange.endRow; i++) { if (worksheet.getRowFiltered(i)) { diff --git a/packages/sheets/src/commands/mutations/remove-row-col.mutation.ts b/packages/sheets/src/commands/mutations/remove-row-col.mutation.ts index 961288c9fb..0fcf873634 100644 --- a/packages/sheets/src/commands/mutations/remove-row-col.mutation.ts +++ b/packages/sheets/src/commands/mutations/remove-row-col.mutation.ts @@ -72,7 +72,6 @@ export const RemoveRowMutation: IMutation = { } } - const rowCount = range.endRow - range.startRow + 1; spliceArray(range.startRow, rowCount, rowPrimitive); diff --git a/packages/ui/src/components/editor/TextEditor.tsx b/packages/ui/src/components/editor/TextEditor.tsx index 69566541f3..c12e7eaace 100644 --- a/packages/ui/src/components/editor/TextEditor.tsx +++ b/packages/ui/src/components/editor/TextEditor.tsx @@ -183,7 +183,6 @@ export function TextEditor(props: ITextEditorProps & Omit { const rect = editor.getBoundingClientRect(); setValidationOffset([rect.left, rect.top - 16]); @@ -198,7 +197,6 @@ export function TextEditor(props: ITextEditorProps & Omit { const { overViewport, ...restProps } = props; const menuRef = useRef(null); diff --git a/packages/ui/src/controllers/ui/ui-desktop.controller.tsx b/packages/ui/src/controllers/ui/ui-desktop.controller.tsx index 2bc9638ee7..252649f17c 100644 --- a/packages/ui/src/controllers/ui/ui-desktop.controller.tsx +++ b/packages/ui/src/controllers/ui/ui-desktop.controller.tsx @@ -47,7 +47,6 @@ export interface IDesktopUIController extends IUIController { getComponents(part: DesktopUIPart): Set<() => ComponentType>; } - export class DesktopUIController extends Disposable implements IDesktopUIController { private _componentsByPart: Map ComponentType>> = new Map(); diff --git a/packages/ui/src/services/global-zone/desktop-global-zone.service.ts b/packages/ui/src/services/global-zone/desktop-global-zone.service.ts index 350bdbae51..28bb812762 100644 --- a/packages/ui/src/services/global-zone/desktop-global-zone.service.ts +++ b/packages/ui/src/services/global-zone/desktop-global-zone.service.ts @@ -27,7 +27,6 @@ export class DesktopGlobalZoneService implements IGlobalZoneService { readonly componentKey$ = new Subject(); private _componentKey = ''; - constructor( @Inject(ComponentManager) private readonly _componentManager: ComponentManager diff --git a/packages/ui/src/utils/cell.ts b/packages/ui/src/utils/cell.ts index 3df90e3242..641a3a40dd 100644 --- a/packages/ui/src/utils/cell.ts +++ b/packages/ui/src/utils/cell.ts @@ -404,7 +404,6 @@ export function handleStringToStyle($dom?: HTMLElement, cssStyle: string = '') { } } - if (key === 'border-color') { const colors = handleBorder(value, ')'); if (!styleList.bd) { diff --git a/packages/umd/scripts/index.mjs b/packages/umd/scripts/index.mjs index fc9f0baafe..13be47e3c1 100644 --- a/packages/umd/scripts/index.mjs +++ b/packages/umd/scripts/index.mjs @@ -14,7 +14,6 @@ * limitations under the License. */ - /** * TODO: @jikkai * 1. monaco-editor is not included in the build. User may not able to use uniscript by default.