From 9a8a4bea037da2aaf561998a2398d70f937aca2b Mon Sep 17 00:00:00 2001 From: Univer <68851825+DR-Univer@users.noreply.github.com> Date: Sat, 24 Feb 2024 12:53:26 +0800 Subject: [PATCH] fix(sheet): formula boolean value (#1360) --- packages/engine-formula/src/engine/ast-node/value-node.ts | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/engine-formula/src/engine/ast-node/value-node.ts b/packages/engine-formula/src/engine/ast-node/value-node.ts index 16cbffa0d2..4d4e40644d 100644 --- a/packages/engine-formula/src/engine/ast-node/value-node.ts +++ b/packages/engine-formula/src/engine/ast-node/value-node.ts @@ -43,7 +43,7 @@ export class ValueNodeFactory extends BaseAstNodeFactory { } _checkValueNode(token: string) { - if (isNaN(Number(token))) { + if (Number.isNaN(Number(token))) { const tokenTrim = token.trim(); const startToken = tokenTrim.charAt(0); const endToken = tokenTrim.charAt(tokenTrim.length - 1); @@ -58,8 +58,10 @@ export class ValueNodeFactory extends BaseAstNodeFactory { if (startToken === '{' && endToken === '}') { return this.create(tokenTrim); } - if (tokenTrim === BooleanValue.TRUE || tokenTrim === BooleanValue.FALSE) { - return this.create(tokenTrim); + + const tokenTrimUpper = tokenTrim.toUpperCase(); + if (tokenTrimUpper === BooleanValue.TRUE || tokenTrimUpper === BooleanValue.FALSE) { + return this.create(tokenTrimUpper); } } else { return this.create(token);