Files
teleport/lib/cache/node.go
T
rosstimothy bde53bc267 Clean up cache collections (#54499)
The store now takes a clone function and uses it to clone all
resources within calls to put. This ensures that there are no races
caused by any modifications of the resource by the event stream.
This also allowed the clone function to be removed from the
genericGetter and genericLister as they can now leverage the store
clone function.

All header transforms now populate the kind and version based on
the information in the ResourceHeader instead of hardcoding the
currently known values.

All indexes derived from the resource name are specified
using `Resource.GetName` instead of defining a function in line
that called r.GetName(). The one caveat being this only works
for types that are behind an interface and none of the RFD 153
style resources.

The clone function of all non-gogo proto resources were switched
from utils.CloneProtoMsg to proto.CloneOf. The clone utility is
only required to prevent panics when cloning gogo proto resources.

All remaining local resource caches have been removed.

All unused legacy executors have been removed.
2025-05-13 16:37:21 +00:00

133 lines
3.8 KiB
Go

// Teleport
// Copyright (C) 2025 Gravitational, Inc.
//
// This program is free software: you can redistribute it and/or modify
// it under the terms of the GNU Affero General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// This program is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU Affero General Public License for more details.
//
// You should have received a copy of the GNU Affero General Public License
// along with this program. If not, see <http://www.gnu.org/licenses/>.
package cache
import (
"context"
"github.com/gravitational/trace"
"github.com/gravitational/teleport/api/defaults"
"github.com/gravitational/teleport/api/types"
"github.com/gravitational/teleport/lib/services"
"github.com/gravitational/teleport/lib/utils"
)
type nodeIndex string
const nodeNameIndex nodeIndex = "name"
func newNodeCollection(p services.Presence, w types.WatchKind) (*collection[types.Server, nodeIndex], error) {
if p == nil {
return nil, trace.BadParameter("missing parameter Presence")
}
return &collection[types.Server, nodeIndex]{
store: newStore(
types.Server.DeepCopy,
map[nodeIndex]func(types.Server) string{
nodeNameIndex: types.Server.GetName,
}),
fetcher: func(ctx context.Context, loadSecrets bool) ([]types.Server, error) {
return p.GetNodes(ctx, defaults.Namespace)
},
headerTransform: func(hdr *types.ResourceHeader) types.Server {
return &types.ServerV2{
Kind: hdr.Kind,
Version: hdr.Version,
Metadata: types.Metadata{
Name: hdr.Metadata.Name,
},
}
},
watch: w,
}, nil
}
// GetNode finds and returns a node by name and namespace.
func (c *Cache) GetNode(ctx context.Context, namespace, name string) (types.Server, error) {
ctx, span := c.Tracer.Start(ctx, "cache/GetNode")
defer span.End()
rg, err := acquireReadGuard(c, c.collections.nodes)
if err != nil {
return nil, trace.Wrap(err)
}
defer rg.Release()
if !rg.ReadCache() {
node, err := c.Config.Presence.GetNode(ctx, namespace, name)
return node, trace.Wrap(err)
}
n, err := rg.store.get(nodeNameIndex, name)
if err != nil {
return nil, trace.Wrap(err)
}
return n.DeepCopy(), nil
}
type getNodesCacheKey struct {
namespace string
}
// GetNodes is a part of auth.Cache implementation
func (c *Cache) GetNodes(ctx context.Context, namespace string) ([]types.Server, error) {
ctx, span := c.Tracer.Start(ctx, "cache/GetNodes")
defer span.End()
rg, err := acquireReadGuard(c, c.collections.nodes)
if err != nil {
return nil, trace.Wrap(err)
}
defer rg.Release()
if !rg.ReadCache() {
nodes, err := c.getNodesWithTTLCache(ctx)
if err != nil {
return nil, trace.Wrap(err)
}
return nodes, nil
}
out := make([]types.Server, 0, rg.store.len())
for n := range rg.store.resources(nodeNameIndex, "", "") {
out = append(out, n.DeepCopy())
}
return out, nil
}
// getNodesWithTTLCache implements TTL-based caching for the GetNodes endpoint. All nodes that will be returned from the caching layer
// must be cloned to avoid concurrent modification.
func (c *Cache) getNodesWithTTLCache(ctx context.Context) ([]types.Server, error) {
cachedNodes, err := utils.FnCacheGet(ctx, c.fnCache, getNodesCacheKey{defaults.Namespace}, func(ctx context.Context) ([]types.Server, error) {
nodes, err := c.Config.Presence.GetNodes(ctx, defaults.Namespace)
return nodes, err
})
// Nodes returned from the TTL caching layer
// must be cloned to avoid concurrent modification.
clonedNodes := make([]types.Server, 0, len(cachedNodes))
for _, node := range cachedNodes {
clonedNodes = append(clonedNodes, node.DeepCopy())
}
return clonedNodes, trace.Wrap(err)
}