Files
teleport/lib/cache/database.go
T
rosstimothy bde53bc267 Clean up cache collections (#54499)
The store now takes a clone function and uses it to clone all
resources within calls to put. This ensures that there are no races
caused by any modifications of the resource by the event stream.
This also allowed the clone function to be removed from the
genericGetter and genericLister as they can now leverage the store
clone function.

All header transforms now populate the kind and version based on
the information in the ResourceHeader instead of hardcoding the
currently known values.

All indexes derived from the resource name are specified
using `Resource.GetName` instead of defining a function in line
that called r.GetName(). The one caveat being this only works
for types that are behind an interface and none of the RFD 153
style resources.

The clone function of all non-gogo proto resources were switched
from utils.CloneProtoMsg to proto.CloneOf. The clone utility is
only required to prevent panics when cloning gogo proto resources.

All remaining local resource caches have been removed.

All unused legacy executors have been removed.
2025-05-13 16:37:21 +00:00

300 lines
9.0 KiB
Go

// Teleport
// Copyright (C) 2025 Gravitational, Inc.
//
// This program is free software: you can redistribute it and/or modify
// it under the terms of the GNU Affero General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// This program is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU Affero General Public License for more details.
//
// You should have received a copy of the GNU Affero General Public License
// along with this program. If not, see <http://www.gnu.org/licenses/>.
package cache
import (
"context"
"github.com/gravitational/trace"
"google.golang.org/protobuf/proto"
"github.com/gravitational/teleport/api/client"
clientproto "github.com/gravitational/teleport/api/client/proto"
"github.com/gravitational/teleport/api/defaults"
dbobjectv1 "github.com/gravitational/teleport/api/gen/proto/go/teleport/dbobject/v1"
headerv1 "github.com/gravitational/teleport/api/gen/proto/go/teleport/header/v1"
"github.com/gravitational/teleport/api/types"
"github.com/gravitational/teleport/lib/services"
)
type databaseIndex string
const databaseNameIndex = "name"
func newDatabaseCollection(p services.Databases, w types.WatchKind) (*collection[types.Database, databaseIndex], error) {
if p == nil {
return nil, trace.BadParameter("missing parameter Databases")
}
return &collection[types.Database, databaseIndex]{
store: newStore(
func(d types.Database) types.Database {
return d.Copy()
},
map[databaseIndex]func(types.Database) string{
databaseNameIndex: types.Database.GetName,
}),
fetcher: func(ctx context.Context, loadSecrets bool) ([]types.Database, error) {
return p.GetDatabases(ctx)
},
headerTransform: func(hdr *types.ResourceHeader) types.Database {
return &types.DatabaseV3{
Kind: hdr.Kind,
Version: hdr.Version,
Metadata: types.Metadata{
Name: hdr.Metadata.Name,
},
}
},
watch: w,
}, nil
}
// GetDatabase returns the specified database resource.
func (c *Cache) GetDatabase(ctx context.Context, name string) (types.Database, error) {
ctx, span := c.Tracer.Start(ctx, "cache/GetDatabase")
defer span.End()
rg, err := acquireReadGuard(c, c.collections.dbs)
if err != nil {
return nil, trace.Wrap(err)
}
defer rg.Release()
if !rg.ReadCache() {
dbs, err := c.Config.Databases.GetDatabase(ctx, name)
return dbs, trace.Wrap(err)
}
d, err := rg.store.get(databaseNameIndex, name)
if err != nil {
return nil, trace.Wrap(err)
}
return d.Copy(), nil
}
// GetDatabases returns all database resources.
func (c *Cache) GetDatabases(ctx context.Context) ([]types.Database, error) {
ctx, span := c.Tracer.Start(ctx, "cache/GetDatabases")
defer span.End()
rg, err := acquireReadGuard(c, c.collections.dbs)
if err != nil {
return nil, trace.Wrap(err)
}
defer rg.Release()
if !rg.ReadCache() {
dbs, err := c.Config.Databases.GetDatabases(ctx)
return dbs, trace.Wrap(err)
}
out := make([]types.Database, 0, rg.store.len())
for d := range rg.store.resources(databaseNameIndex, "", "") {
out = append(out, d.Copy())
}
return out, nil
}
type databaseServerIndex string
const databaseServerNameIndex databaseServerIndex = "name"
func newDatabaseServerCollection(p services.Presence, w types.WatchKind) (*collection[types.DatabaseServer, databaseServerIndex], error) {
if p == nil {
return nil, trace.BadParameter("missing parameter Presence")
}
return &collection[types.DatabaseServer, databaseServerIndex]{
store: newStore(
types.DatabaseServer.Copy,
map[databaseServerIndex]func(types.DatabaseServer) string{
databaseServerNameIndex: func(u types.DatabaseServer) string {
return u.GetHostID() + "/" + u.GetName()
},
}),
fetcher: func(ctx context.Context, loadSecrets bool) ([]types.DatabaseServer, error) {
return p.GetDatabaseServers(ctx, defaults.Namespace)
},
headerTransform: func(hdr *types.ResourceHeader) types.DatabaseServer {
return &types.DatabaseServerV3{
Kind: hdr.Kind,
Version: hdr.Version,
Metadata: types.Metadata{
Name: hdr.Metadata.Name,
},
Spec: types.DatabaseServerSpecV3{
HostID: hdr.Metadata.Description,
},
}
},
watch: w,
}, nil
}
// GetDatabaseServers returns all registered database proxy servers.
func (c *Cache) GetDatabaseServers(ctx context.Context, namespace string, opts ...services.MarshalOption) ([]types.DatabaseServer, error) {
ctx, span := c.Tracer.Start(ctx, "cache/GetDatabaseServers")
defer span.End()
rg, err := acquireReadGuard(c, c.collections.dbServers)
if err != nil {
return nil, trace.Wrap(err)
}
defer rg.Release()
if !rg.ReadCache() {
servers, err := c.Config.Presence.GetDatabaseServers(ctx, namespace)
return servers, trace.Wrap(err)
}
out := make([]types.DatabaseServer, 0, rg.store.len())
for ds := range rg.store.resources(databaseServerNameIndex, "", "") {
out = append(out, ds.Copy())
}
return out, nil
}
type databaseServiceIndex string
const databaseServiceNameIndex databaseServiceIndex = "name"
func newDatabaseServiceCollection(p services.Presence, w types.WatchKind) (*collection[types.DatabaseService, databaseServiceIndex], error) {
if p == nil {
return nil, trace.BadParameter("missing parameter Databases")
}
return &collection[types.DatabaseService, databaseServiceIndex]{
store: newStore(
types.DatabaseService.Clone,
map[databaseServiceIndex]func(types.DatabaseService) string{
databaseServiceNameIndex: types.DatabaseService.GetName,
}),
fetcher: func(ctx context.Context, loadSecrets bool) ([]types.DatabaseService, error) {
resources, err := client.GetResourcesWithFilters(ctx, p, clientproto.ListResourcesRequest{ResourceType: types.KindDatabaseService})
if err != nil {
return nil, trace.Wrap(err)
}
dbsvcs := make([]types.DatabaseService, 0, len(resources))
for _, resource := range resources {
dbsvc, ok := resource.(types.DatabaseService)
if !ok {
return nil, trace.BadParameter("unexpected resource %T", resource)
}
dbsvcs = append(dbsvcs, dbsvc)
}
return dbsvcs, nil
},
headerTransform: func(hdr *types.ResourceHeader) types.DatabaseService {
return &types.DatabaseServiceV1{
ResourceHeader: types.ResourceHeader{
Kind: hdr.Kind,
Version: hdr.Version,
Metadata: types.Metadata{
Name: hdr.Metadata.Name,
},
},
}
},
watch: w,
}, nil
}
type databaseObjectIndex string
const databaseObjectNameIndex databaseObjectIndex = "name"
func newDatabaseObjectCollection(upstream services.DatabaseObjects, w types.WatchKind) (*collection[*dbobjectv1.DatabaseObject, databaseObjectIndex], error) {
if upstream == nil {
return nil, trace.BadParameter("missing parameter DatabaseObjects")
}
return &collection[*dbobjectv1.DatabaseObject, databaseObjectIndex]{
store: newStore(
proto.CloneOf[*dbobjectv1.DatabaseObject],
map[databaseObjectIndex]func(*dbobjectv1.DatabaseObject) string{
databaseObjectNameIndex: func(r *dbobjectv1.DatabaseObject) string {
return r.GetMetadata().GetName()
},
}),
fetcher: func(ctx context.Context, loadSecrets bool) ([]*dbobjectv1.DatabaseObject, error) {
var out []*dbobjectv1.DatabaseObject
var nextToken string
for {
var page []*dbobjectv1.DatabaseObject
var err error
page, nextToken, err = upstream.ListDatabaseObjects(ctx, 0, nextToken)
if err != nil {
return nil, trace.Wrap(err)
}
out = append(out, page...)
if nextToken == "" {
break
}
}
return out, nil
},
headerTransform: func(hdr *types.ResourceHeader) *dbobjectv1.DatabaseObject {
return &dbobjectv1.DatabaseObject{
Kind: hdr.Kind,
Version: hdr.Version,
Metadata: &headerv1.Metadata{
Name: hdr.Metadata.Name,
},
}
},
watch: w,
}, nil
}
func (c *Cache) GetDatabaseObject(ctx context.Context, name string) (*dbobjectv1.DatabaseObject, error) {
ctx, span := c.Tracer.Start(ctx, "cache/GetDatabaseObject")
defer span.End()
getter := genericGetter[*dbobjectv1.DatabaseObject, databaseObjectIndex]{
cache: c,
collection: c.collections.databaseObjects,
index: databaseObjectNameIndex,
upstreamGet: c.Config.DatabaseObjects.GetDatabaseObject,
}
out, err := getter.get(ctx, name)
return out, trace.Wrap(err)
}
func (c *Cache) ListDatabaseObjects(ctx context.Context, size int, pageToken string) ([]*dbobjectv1.DatabaseObject, string, error) {
ctx, span := c.Tracer.Start(ctx, "cache/ListDatabaseObjects")
defer span.End()
lister := genericLister[*dbobjectv1.DatabaseObject, databaseObjectIndex]{
cache: c,
collection: c.collections.databaseObjects,
index: databaseObjectNameIndex,
upstreamList: c.Config.DatabaseObjects.ListDatabaseObjects,
nextToken: func(dbo *dbobjectv1.DatabaseObject) string {
return dbo.GetMetadata().GetName()
},
}
out, next, err := lister.list(ctx, size, pageToken)
return out, next, trace.Wrap(err)
}