Files
teleport/lib/utils/jsontools.go
T
Tim Buckley f216605ae9 Enable map key sorting in utils.FastMarshal (#10070)
* Enable map key sorting in `utils.FastMarshal`

This enables map key sorting during JSON serialization to ensure
`CompareAndSwap` opertions work consistently if the resource in
question has embedded map values (e.g. labels).

Note that this is hypothetically a breaking change: it makes
comparisons consistent, so if it saves a variant that consistently
fails a `CompareAndSwap()`, it will... fail consistently rather
than sometimes work. In practice, today only `CertificateAuthority`
resources use `CompareAndSwap()` and under normal circumstances they
never have labels attached.

In the unlikely event that some resource is affected, a load/store
should save it with sorted key ordering and fix the problem.

* Log a warning if CAs fail a compare-and-swap with multiple labels

This attempts to mitigate compare-and-swap failures if CAs have
multiple labels by logging a warning instructing users to re-save
their CertificateAuthority resource.

* Fix copied comment typo and make the logged warning actionable

* Fix log.Warn() call with formatting directives
2022-02-07 23:32:58 +00:00

176 lines
4.6 KiB
Go

/*
Copyright 2014 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package utils
import (
"bytes"
"io"
"reflect"
"unicode"
"github.com/gravitational/trace"
jsoniter "github.com/json-iterator/go"
"github.com/ghodss/yaml"
kyaml "k8s.io/apimachinery/pkg/util/yaml"
)
// ToJSON converts a single YAML document into a JSON document
// or returns an error. If the document appears to be JSON the
// YAML decoding path is not used (so that error messages are
// JSON specific).
// Creds to: k8s.io for the code
func ToJSON(data []byte) ([]byte, error) {
if hasJSONPrefix(data) {
return data, nil
}
return yaml.YAMLToJSON(data)
}
var jsonPrefix = []byte("{")
// hasJSONPrefix returns true if the provided buffer appears to start with
// a JSON open brace.
func hasJSONPrefix(buf []byte) bool {
return hasPrefix(buf, jsonPrefix)
}
// Return true if the first non-whitespace bytes in buf is
// prefix.
func hasPrefix(buf []byte, prefix []byte) bool {
trim := bytes.TrimLeftFunc(buf, unicode.IsSpace)
return bytes.HasPrefix(trim, prefix)
}
// FastUnmarshal uses the json-iterator library for fast JSON unmarshalling.
// Note, this function marshals floats with 6 digits precision.
func FastUnmarshal(data []byte, v interface{}) error {
iter := jsoniter.ConfigFastest.BorrowIterator(data)
defer jsoniter.ConfigFastest.ReturnIterator(iter)
iter.ReadVal(v)
if iter.Error != nil {
return trace.Wrap(iter.Error)
}
return nil
}
// SafeConfig uses jsoniter's ConfigFastest settings but enables map key
// sorting to ensure CompareAndSwap checks consistently succeed.
var SafeConfig = jsoniter.Config{
EscapeHTML: false,
MarshalFloatWith6Digits: true, // will lose precision
ObjectFieldMustBeSimpleString: true, // do not unescape object field
SortMapKeys: true,
}.Froze()
// FastMarshal uses the json-iterator library for fast JSON marshalling.
// Note, this function unmarshals floats with 6 digits precision.
func FastMarshal(v interface{}) ([]byte, error) {
data, err := SafeConfig.Marshal(v)
if err != nil {
return nil, trace.Wrap(err)
}
return data, nil
}
const yamlDocDelimiter = "---"
// WriteYAML detects whether value is a list
// and marshals multiple documents delimited by `---`, otherwise, marshals
// a single value
func WriteYAML(w io.Writer, values interface{}) error {
if reflect.TypeOf(values).Kind() != reflect.Slice {
return trace.Wrap(writeYAML(w, values))
}
// first pass makes sure that all values are documents (objects or maps)
slice := reflect.ValueOf(values)
allDocs := func() bool {
for i := 0; i < slice.Len(); i++ {
if !isDoc(slice.Index(i)) {
return false
}
}
return true
}
if !allDocs() {
return trace.Wrap(writeYAML(w, values))
}
// second pass can marshal documents
for i := 0; i < slice.Len(); i++ {
err := writeYAML(w, slice.Index(i).Interface())
if err != nil {
return trace.Wrap(err)
}
if i != slice.Len()-1 {
if _, err := w.Write([]byte(yamlDocDelimiter + "\n")); err != nil {
return trace.Wrap(err)
}
}
}
return nil
}
// isDoc detects whether value constitutes a document
func isDoc(val reflect.Value) bool {
iterations := 0
for val.Kind() == reflect.Interface || val.Kind() == reflect.Ptr {
val = val.Elem()
// preventing cycles
iterations++
if iterations > 10 {
return false
}
}
return val.Kind() == reflect.Struct || val.Kind() == reflect.Map
}
// writeYAML writes marshaled YAML to writer
func writeYAML(w io.Writer, values interface{}) error {
data, err := yaml.Marshal(values)
if err != nil {
return trace.Wrap(err)
}
_, err = w.Write(data)
return trace.Wrap(err)
}
// ReadYAML can unmarshal a stream of documents, used in tests.
func ReadYAML(reader io.Reader) (interface{}, error) {
decoder := kyaml.NewYAMLOrJSONDecoder(reader, 32*1024)
var values []interface{}
for {
var val interface{}
err := decoder.Decode(&val)
if err != nil {
if err == io.EOF {
if len(values) == 0 {
return nil, trace.BadParameter("no resources found, empty input?")
}
if len(values) == 1 {
return values[0], nil
}
return values, nil
}
return nil, trace.Wrap(err)
}
values = append(values, val)
}
}