Tiago Silva ec57cd5a67 Uniform equal function names to IsEqual (#40441) ...

* Uniform equal function names to `IsEqual`

Our API doesn't define any naming or characteristics for object
comparison functions like `IsEqual`. Checks rely on using
`services.CompareResources` that has some coverage but doesn't cover all
resources otherwise it fallsback to expensive `cmp.Equal` comparison.

This PR moves the `IsEqual` interface to `api` so we can ensure objects
satisfy the same interface required by `services.CompareResources`.

Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>

* handle review comments

* keep  equal

---------

Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>

2024-04-19 09:22:43 +00:00

..

accesslist

Uniform equal function names to IsEqual (#40441)

2024-04-19 09:22:43 +00:00

accessmonitoringrule

Add initial access monitoring rule resource (#36745)

2024-03-08 15:46:00 +00:00

common

Add discovery for Kubernetes apps (#28988)

2023-08-09 14:44:58 +00:00

compare

Uniform equal function names to IsEqual (#40441)

2024-04-19 09:22:43 +00:00

discoveryconfig

Uniform equal function names to IsEqual (#40441)

2024-04-19 09:22:43 +00:00

events

Update web_session_id description in DeviceMetadata (#40637)

2024-04-18 07:06:06 +00:00

externalauditstorage

External Audit Storage: rename from ExternalCloudAudit (part 1) (#34961)

2023-11-27 19:02:52 +00:00

header

Uniform equal function names to IsEqual (#40441)

2024-04-19 09:22:43 +00:00

installers

jq has been missing in the installer scripts (#39594)

2024-03-19 22:30:03 +00:00

kubewaitingcontainer

Introduce patch_type to KubernetesWaitingContainer (#39738)

2024-03-22 19:35:46 +00:00

label

Implement persistence for db_object_import_rule resource (#37806)

2024-02-22 03:54:27 +00:00

samlsp

feat: adds relay_state to SAMLIdPServiceProviderSpecV1 (#39276)

2024-03-15 13:50:20 +00:00

secreports

Security Reports (#30853)

2023-10-16 10:11:54 +00:00

trait

Add the AccessList to the cache. (#29119)

2023-07-18 15:29:22 +00:00

userloginstate

Machine ID: Introduce BotService (#35441)

2023-12-21 12:00:12 +00:00

webauthn

Remove the webauthn.User proto (#39950)

2024-03-28 16:49:38 +00:00

wrappers

…

access_request_test.go

Use new access request filters in webUI (#39625)

2024-03-27 18:21:55 +00:00

access_request.go

Use new access request filters in webUI (#39625)

2024-03-27 18:21:55 +00:00

accountrecovery.go

Fixed additional license format issues (#34726)

2023-11-17 21:14:08 +00:00

app_test.go

Add Integration field to App resource (#39670)

2024-03-22 08:01:42 +00:00

app.go

Uniform equal function names to IsEqual (#40441)

2024-04-19 09:22:43 +00:00

appserver_or_saml_idp_sp_test.go

add saml apps to webui apps list (#28041)

2023-07-20 16:56:43 +00:00

appserver_or_saml_idp_sp.go

Improve performance of resource filtering (#39724)

2024-03-25 17:38:49 +00:00

appserver_test.go

Support app servers on different types of tunnels. (#23749)

2023-03-29 18:13:48 +00:00

appserver.go

Add PinnedResources to ListUnifiedResources Request (#32077)

2023-10-10 22:48:25 +00:00

assertion_info_test.go

…

assertion_info.go

…

audit.go

Add Revision to resource metadata (#31107)

2023-08-29 17:31:34 +00:00

authentication_authpreference_test.go

Device Trust: TPM Enrollment support EKCerts (#27070)

2023-05-29 18:42:41 +00:00

authentication_mfadevice_test.go

Allow unknown fields when unmarshaling types.MFADevice (#25437)

2023-05-01 22:41:01 +00:00

authentication_test.go

Add support for Hardware Key PIN (#31743)

2023-10-13 19:07:43 +00:00

authentication.go

Convert api to use slog instead of logrus (#39255)

2024-03-18 21:20:28 +00:00

authority_test.go

fix rotation handling in GenerateHostCerts

2022-10-19 16:35:51 -07:00

authority.go

add CA filter for all known CAs to cache configs (#36361)

2024-01-09 18:30:41 +00:00

clone_test.go

use "google.golang.org/protobuf" to clone protobuf messages (#25466)

2023-05-04 21:22:01 +00:00

cluster_alert_test.go

chore: Bump golangci-lint to v1.56.0 (#37854)

2024-02-07 19:54:00 +00:00

cluster_alert.go

Alert ack API + CLI implementation (#19480)

2023-01-24 17:30:07 +00:00

clustername.go

Add Revision to resource metadata (#31107)

2023-08-29 17:31:34 +00:00

cmp_test.go

Rename protoEqual and add a big warning (#21491)

2023-02-08 20:57:18 +00:00

cmp.go

Rename protoEqual and add a big warning (#21491)

2023-02-08 20:57:18 +00:00

connection_diagnostic.go

Adds Origin and Label functions to ResourceHeader. (#20847)

2023-01-30 16:23:24 +00:00

constants.go

Introduce role friendly name labels and frontend utilities. (#40113)

2024-04-05 12:40:40 +00:00

database_permissions_test.go

Add DatabasePermissions field to role (#37797)

2024-02-07 20:03:11 +00:00

database_permissions.go

Add DatabasePermissions field to role (#37797)

2024-02-07 20:03:11 +00:00

database_test.go

Improve error message when auto-user provisioning fails on reader endpoints (#37557)

2024-02-08 19:48:07 +00:00

database.go

Uniform equal function names to IsEqual (#40441)

2024-04-19 09:22:43 +00:00

databaseserver_test.go

Remove GetAppSessions and deprecated DatabaseServerSpecV3 fiels (#30141)

2023-08-08 16:59:46 +00:00

databaseserver.go

Add PinnedResources to ListUnifiedResources Request (#32077)

2023-10-10 22:48:25 +00:00

databaseservice.go

AWSOIDC: Collect required vpcs and its subnets for use in web UI (#35930)

2023-12-22 16:29:56 +00:00

derived.gen.go

Add derived equals for other types within Teleport. (#39081)

2024-03-26 20:32:44 +00:00

desktop_test.go

Validate desktop names (#31739)

2023-09-12 18:56:31 +00:00

desktop.go

Uniform equal function names to IsEqual (#40441)

2024-04-19 09:22:43 +00:00

device_test.go

Add the os_id field to device messages (#34588)

2023-11-16 13:05:47 +00:00

device.go

Add the os_id field to device messages (#34588)

2023-11-16 13:05:47 +00:00

device.pb.go

Add the os_id field to device messages (#34588)

2023-11-16 13:05:47 +00:00

duration_test.go

…

duration.go

Enable GCI linter (#17894)

2022-10-28 20:20:28 +00:00

events_test.go

add CA filter for all known CAs to cache configs (#36361)

2024-01-09 18:30:41 +00:00

events.go

add CA filter for all known CAs to cache configs (#36361)

2024-01-09 18:30:41 +00:00

extension.go

Add support for Protobuf Enums into Operator CRDs (#32469)

2023-09-26 13:43:50 +00:00

fuzz_test.go

Fuzzing test improvements (#28066)

2023-06-20 16:14:15 +00:00

github.go

Convert api to use slog instead of logrus (#39255)

2024-03-18 21:20:28 +00:00

headlessauthn.go

Fix headless authentication matching logic for watcher (#28843)

2023-07-11 20:05:17 +00:00

installer.go

Fixed additional license format issues (#34726)

2023-11-17 21:14:08 +00:00

instance_test.go

rework instance hbs to be more scalable and to track upgraders (#27895)

2023-07-08 02:15:56 +00:00

instance.go

Prevent overflow in sort functions provided to slices.SortFunc (#38642)

2024-02-26 20:44:07 +00:00

integration_awsoidc.go

AWSOIDC: Compute Proxy's Endpoint for issuing a token (#37253)

2024-01-26 13:35:16 +00:00

integration_test.go

AWS OIDC: Accept custom issuers (#38785)

2024-03-15 18:08:35 +00:00

integration.go

AWS OIDC: Accept custom issuers (#38785)

2024-03-15 18:08:35 +00:00

jamf_test.go

fix: Use correct sync defaults and validation (#28540)

2023-06-30 20:21:06 +00:00

jamf.go

Use pkg slices from the standard library (#35905)

2023-12-19 23:06:53 +00:00

jwt.go

Add option to configure JWT claim rewriting (#29687)

2023-08-08 10:30:27 +00:00

kubernetes_server_test.go

Fix some lint issues (#38913)

2024-03-07 18:04:51 +00:00

kubernetes_server.go

Uniform equal function names to IsEqual (#40441)

2024-04-19 09:22:43 +00:00

kubernetes_test.go

Fix some lint issues (#38913)

2024-03-07 18:04:51 +00:00

kubernetes.go

Uniform equal function names to IsEqual (#40441)

2024-04-19 09:22:43 +00:00

license_test.go

Adds IGS related fields to feature, module, and license objects (#34868)

2023-11-27 18:22:49 +00:00

license.go

Add Teleport Policy feature (#37013)

2024-01-24 17:03:42 +00:00

lock_test.go

Simplify LockTarget.IsEmpty implementation (#32568)

2023-09-26 17:36:03 +00:00

lock.go

lock: Remove deprecated lock per node (#36418)

2024-01-08 19:01:18 +00:00

maintenance_test.go

Add support for deploy service agent auto updates (#31982)

2023-10-10 22:00:09 +00:00

maintenance.go

Add support for deploy service agent auto updates (#31982)

2023-10-10 22:00:09 +00:00

matchers_accessgraph.go

Discovery: Add TAG sync object to Discovery config (#37908)

2024-02-12 11:43:48 +00:00

matchers_aws_test.go

DiscoveryMatchers: move checkandset to types package (#32857)

2023-10-04 13:48:09 +00:00

matchers_aws.go

Use pkg slices from the standard library (#35905)

2023-12-19 23:06:53 +00:00

matchers_azure_test.go

DiscoveryConfig: fix CheckAndSetDefaults for matchers (#33697)

2023-10-30 10:18:00 +00:00

matchers_azure.go

Use pkg slices from the standard library (#35905)

2023-12-19 23:06:53 +00:00

matchers_gcp_test.go

DiscoveryMatchers: move checkandset to types package (#32857)

2023-10-04 13:48:09 +00:00

matchers_gcp.go

Use pkg slices from the standard library (#35905)

2023-12-19 23:06:53 +00:00

matchers_kube_test.go

DiscoveryMatchers: move checkandset to types package (#32857)

2023-10-04 13:48:09 +00:00

matchers_kube.go

Use pkg slices from the standard library (#35905)

2023-12-19 23:06:53 +00:00

matchers.go

Move Discovery Matchers to their own files (#32325)

2023-09-22 07:42:30 +00:00

mfa.go

use "google.golang.org/protobuf" to clone protobuf messages (#25466)

2023-05-04 21:22:01 +00:00

namespace.go

Add Revision to resource metadata (#31107)

2023-08-29 17:31:34 +00:00

networking_test.go

Enable errorlint via golangci-lint (#37669)

2024-02-02 15:59:24 +00:00

networking.go

Add Revision to resource metadata (#31107)

2023-08-29 17:31:34 +00:00

oidc_external_test.go

…

oidc_external.go

…

oidc.go

Use pkg slices from the standard library (#35905)

2023-12-19 23:06:53 +00:00

okta_test.go

Add CompareResources support for custom equals functions. (#38981)

2024-03-07 02:02:11 +00:00

okta.go

Uniform equal function names to IsEqual (#40441)

2024-04-19 09:22:43 +00:00

order.go

…

plugin_data.go

Add Revision to resource metadata (#31107)

2023-08-29 17:31:34 +00:00

plugin_static_credentials.go

Introduce the Plugin Static Credentials object. (#27121)

2023-05-31 15:11:36 +00:00

plugin_test.go

Allow configuration of Okta access list importing. (#36569)

2024-01-11 16:08:27 +00:00

plugin.go

Introduce plugins cleanup command line function. (#40035)

2024-04-01 18:00:08 +00:00

presence.go

usagereporter: resource heartbeats (#23093)

2023-03-24 18:47:58 +00:00

provisioning_test.go

chore: Bump golangci-lint to v1.56.0 (#37854)

2024-02-07 19:54:00 +00:00

provisioning.go

Backend supporting changes for Bot creation flow (#37348)

2024-01-31 14:04:24 +00:00

proxied_service.go

…

register.go

…

remotecluster.go

Add Revision to resource metadata (#31107)

2023-08-29 17:31:34 +00:00

resource_153_test.go

Fix incorrect expiry when using resource153ToLegacyAdapter (#39761)

2024-03-25 14:17:04 +00:00

resource_153.go

Fix incorrect expiry when using resource153ToLegacyAdapter (#39761)

2024-03-25 14:17:04 +00:00

resource_ids_test.go

feat: support resource requests via tctl (#29418)

2023-07-24 20:35:12 +00:00

resource_ids.go

Use pkg slices from the standard library (#35905)

2023-12-19 23:06:53 +00:00

resource_test.go

Introduce role friendly name labels and frontend utilities. (#40113)

2024-04-05 12:40:40 +00:00

resource.go

Uniform equal function names to IsEqual (#40441)

2024-04-19 09:22:43 +00:00

restrictions.go

Add Revision to resource metadata (#31107)

2023-08-29 17:31:34 +00:00

role_test.go

remove saml_idp_service_provider_labels and saml_idp_service_provider_labels_expression (#40047)

2024-03-29 20:22:48 +00:00

role.go

remove saml_idp_service_provider_labels and saml_idp_service_provider_labels_expression (#40047)

2024-03-29 20:22:48 +00:00

saml_idp_service_provider_test.go

feat: adds relay_state to SAMLIdPServiceProviderSpecV1 (#39276)

2024-03-15 13:50:20 +00:00

saml_idp_service_provider.go

configure entity descriptor based on preset value (#39385)

2024-03-18 18:30:15 +00:00

saml_test.go

Enable testify lint (#34222)

2023-11-06 20:38:38 +00:00

saml.go

Allow setting metadata via types.SAMLConnector interface (#37309)

2024-01-28 10:32:15 +00:00

semaphore.go

Security Reports (#30853)

2023-10-16 10:11:54 +00:00

server_info_test.go

EC2 Auto-Discovery: EICE support (#35504)

2024-03-26 16:16:20 +00:00

server_info.go

EC2 Auto-Discovery: EICE support (#35504)

2024-03-26 16:16:20 +00:00

server_test.go

DiscoveryService: prevent EICE Node duplication (#40220)

2024-04-15 13:24:33 +00:00

server.go

DiscoveryService: prevent EICE Node duplication (#40220)

2024-04-15 13:24:33 +00:00

session_tracker_test.go

Fix moderated session presence checking (#25988)

2023-06-08 20:27:13 +00:00

session_tracker.go

Use pkg slices from the standard library (#35905)

2023-12-19 23:06:53 +00:00

session.go

Move types.NewWebSessionRequest to lib/auth/sessions.go. (#39742)

2024-04-02 18:41:24 +00:00

sessionrecording.go

Use pkg slices from the standard library (#35905)

2023-12-19 23:06:53 +00:00

sortby_test.go

…

sortby.go

Use new access request filters in webUI (#39625)

2024-03-27 18:21:55 +00:00

statictokens.go

Add Revision to resource metadata (#31107)

2023-08-29 17:31:34 +00:00

system_role_test.go

Make system roles case-insensitive in provision tokens (#33053)

2023-10-10 20:19:30 +00:00

system_role.go

refactor(types): change role signup string return (#36048)

2024-01-09 20:04:43 +00:00

traits.go

…

trust.go

Machine ID: Add Workload Identity Service (#38181)

2024-02-26 11:43:51 +00:00

trustedcluster.go

Use pkg slices from the standard library (#35905)

2023-12-19 23:06:53 +00:00

tunnel_strategy_test.go

…

tunnel_strategy.go

Enable GCI linter (#17894)

2022-10-28 20:20:28 +00:00

tunnel.go

Add Revision to resource metadata (#31107)

2023-08-29 17:31:34 +00:00

tunnelconn.go

Add Revision to resource metadata (#31107)

2023-08-29 17:31:34 +00:00

types.pb.go

Fix tpm joining protobuf oneof (#40514)

2024-04-12 19:16:44 +00:00

ui_config.go

Fixed additional license format issues (#34726)

2023-11-17 21:14:08 +00:00

user.go

Keep track of whether the user has a real password set (#39576)

2024-04-10 10:28:05 +00:00

usergroup_test.go

Add mapping between user groups and applications. (#27812)

2023-06-16 17:52:31 +00:00

usergroup.go

Uniform equal function names to IsEqual (#40441)

2024-04-19 09:22:43 +00:00

usertoken.go

Add Revision to resource metadata (#31107)

2023-08-29 17:31:34 +00:00

usertokensecrets.go

Add Revision to resource metadata (#31107)

2023-08-29 17:31:34 +00:00

watch_status.go

Additional license format fixes (#34738)

2023-11-17 22:58:02 +00:00