mirror of
https://github.com/gravitational/teleport.git
synced 2026-10-29 17:58:15 +08:00
Mike Jensen
e923525197
* Disable `build-macos` and `build-windows` on PR This commit removes the `build-macos` and `build-windows` from the PR flow, instead delegating to the bypass job. These jobs still run at the merge queue point. This of course means that failures in these two jobs may not be known until the merge queue. There is an unequestionable disadvantage in not discovering those issues until that point, but this change is being recommended because: * Currently MacOS builds are 31% of our Teleport Actions spend (~$3,500 / week) * Windows builds are also significant at 13% (~$1,400 / week) * There has been relatively few failures of these jobs (without other jobs also failing) Although merge queue verification is not ideal because it's later in the process, it is considered the most critical in ensuring that `master` remains stable. * Make sure all bypass jobs run on `ubuntu-latest` In a couple cases this allows the jobs to be run on a cheaper instance.
38 lines
1.0 KiB
YAML
38 lines
1.0 KiB
YAML
# This workflow is required to ensure that required Github check passes even if
|
|
# the actual "Build on Windows" workflow skipped due to path filtering. Otherwise
|
|
# it will stay forever pending.
|
|
#
|
|
# See "Handling skipped but required checks" for more info:
|
|
#
|
|
# https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/troubleshooting-required-status-checks#handling-skipped-but-required-checks
|
|
#
|
|
# Note both workflows must have the same name.
|
|
|
|
name: Build on Windows
|
|
run-name: Skip Build on Windows
|
|
|
|
on:
|
|
pull_request:
|
|
merge_group:
|
|
# We only build tsh on Windows so only consider Go code as tsh doesn't
|
|
# run any Rust.
|
|
paths-ignore:
|
|
- '.github/workflows/build-windows.yaml'
|
|
- '**.go'
|
|
- 'go.mod'
|
|
- 'go.sum'
|
|
- 'build.assets/Makefile'
|
|
- 'build.assets/Dockerfile*'
|
|
- 'Makefile'
|
|
|
|
jobs:
|
|
build:
|
|
name: Build on Windows
|
|
runs-on: ubuntu-latest
|
|
|
|
permissions:
|
|
contents: none
|
|
|
|
steps:
|
|
- run: 'echo "No code changes"'
|