Files
teleport/lib/utils/cli_test.go
T
Chris ThachandZac Bergquist e16a7ad8ef Add debug logging to tsh when there is a SAN mismatch connecting to Auth via Proxy (#61059)
* Add debug logging to `tsh login` when there is a DNS SAN mismatch

Signed-off-by: Chris Thach <chris.thach@goteleport.com>

* Fix formatting so it is consistent

Signed-off-by: Chris Thach <chris.thach@goteleport.com>

* Filter for only proxy env vars. Improve message.

Signed-off-by: Chris Thach <chris.thach@goteleport.com>

* Add unit tests for formatCertError.

Signed-off-by: Chris Thach <chris.thach@goteleport.com>

* Revert copyright update

* Pretty print proxy env and certificate

Signed-off-by: Chris Thach <chris.thach@goteleport.com>

* Print NotBefore

Signed-off-by: Chris Thach <chris.thach@goteleport.com>

* Add case where there is a network intermediary

Signed-off-by: Chris Thach <chris.thach@goteleport.com>

* Revert general HostnameError case. Add message for just the case of connecting to Auth.

Signed-off-by: Chris Thach <chris.thach@goteleport.com>

* Apply suggestions from code review

Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>

* Fix missing deref. Only build in the special case.

Signed-off-by: Chris Thach <chris.thach@goteleport.com>

* Remove internal cluster domain and move hostname to debug info.

Signed-off-by: Chris Thach <chris.thach@goteleport.com>

* Add vertical space.

Signed-off-by: Chris Thach <chris.thach@goteleport.com>

---------

Signed-off-by: Chris Thach <chris.thach@goteleport.com>
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
2025-11-10 18:36:40 +00:00

258 lines
6.7 KiB
Go

/*
* Teleport
* Copyright (C) 2023 Gravitational, Inc.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
package utils
import (
"crypto/x509"
"errors"
"fmt"
"log/slog"
"testing"
"github.com/alecthomas/kingpin/v2"
"github.com/gravitational/trace"
"github.com/stretchr/testify/require"
)
func TestUserMessageFromError(t *testing.T) {
// Behavior is different in debug
defaultLogger := slog.Default()
var leveler slog.LevelVar
leveler.Set(slog.LevelInfo)
slog.SetDefault(slog.New(slog.DiscardHandler))
t.Cleanup(func() {
slog.SetDefault(defaultLogger)
})
tests := []struct {
comment string
inError error
outString string
}{
{
comment: "outputs x509-specific unknown authority message",
inError: trace.Wrap(x509.UnknownAuthorityError{}),
outString: "WARNING:\n\n The proxy you are connecting to has presented a",
},
{
comment: "outputs x509-specific invalid certificate message",
inError: trace.Wrap(x509.CertificateInvalidError{}),
outString: "WARNING:\n\n The certificate presented by the proxy is invalid",
},
{
comment: "outputs user message as provided",
inError: trace.Errorf("bad thing occurred"),
outString: "\x1b[31mERROR: \x1b[0mbad thing occurred",
},
}
for _, tt := range tests {
message := UserMessageFromError(tt.inError)
require.Contains(t, message, tt.outString)
}
}
// TestEscapeControl tests escape control
func TestEscapeControl(t *testing.T) {
t.Parallel()
tests := []struct {
in string
out string
}{
{
in: "hello, world!",
out: "hello, world!",
},
{
in: "hello,\nworld!",
out: `"hello,\nworld!"`,
},
{
in: "hello,\r\tworld!",
out: `"hello,\r\tworld!"`,
},
}
for i, tt := range tests {
require.Equal(t, tt.out, EscapeControl(tt.in), fmt.Sprintf("test case %v", i))
}
}
// TestAllowWhitespace tests escape control that allows (some) whitespace characters.
func TestAllowWhitespace(t *testing.T) {
t.Parallel()
tests := []struct {
in string
out string
}{
{
in: "hello, world!",
out: "hello, world!",
},
{
in: "hello,\nworld!",
out: "hello,\nworld!",
},
{
in: "\thello, world!",
out: "\thello, world!",
},
{
in: "\t\thello, world!",
out: "\t\thello, world!",
},
{
in: "hello, world!\n",
out: "hello, world!\n",
},
{
in: "hello, world!\n\n",
out: "hello, world!\n\n",
},
{
in: string([]byte{0x68, 0x00, 0x68}),
out: "\"h\\x00h\"",
},
{
in: string([]byte{0x68, 0x08, 0x68}),
out: "\"h\\bh\"",
},
{
in: string([]int32{0x00000008, 0x00000009, 0x00000068}),
out: "\"\\b\"\th",
},
{
in: string([]int32{0x00000090}),
out: "\"\\u0090\"",
},
{
in: "hello,\r\tworld!",
out: `"hello,\r"` + "\tworld!",
},
{
in: "hello,\n\r\tworld!",
out: "hello,\n" + `"\r"` + "\tworld!",
},
{
in: "hello,\t\n\r\tworld!",
out: "hello,\t\n" + `"\r"` + "\tworld!",
},
}
for i, tt := range tests {
require.Equal(t, tt.out, AllowWhitespace(tt.in), fmt.Sprintf("test case %v", i))
}
}
// TestFilterArguments tests filtering command arguments.
func TestFilterArguments(t *testing.T) {
t.Parallel()
app := kingpin.New("tsh", "")
app.Flag("proxy", "").String()
app.Flag("check-update", "").Bool()
tests := []struct {
args []string
expected []string
}{
{
args: []string{"--insecure", "--proxy", "localhost", "--check-update", "test"},
expected: []string{"--proxy", "localhost", "--check-update"},
},
{
args: []string{"--insecure", "--proxy=localhost", "--check-update", "test"},
expected: []string{"--proxy=localhost", "--check-update"},
},
{
args: []string{"--proxy", "localhost", "test"},
expected: []string{"--proxy", "localhost"},
},
{
args: []string{"--proxy"},
expected: []string(nil),
},
{
args: []string{"--insecure", "--check-update", "test", "--proxy=localhost"},
expected: []string{"--proxy=localhost", "--check-update"},
},
{
args: []string{"--insecure", "--check-update", "test", "--proxy1=localhost"},
expected: []string{"--check-update"},
},
{
args: []string{"--check-update", "test", "--proxy1", "localhost"},
expected: []string{"--check-update"},
},
{
args: []string{"--insecure", "test", "--proxy1", "localhost", "--check-update"},
expected: []string{"--check-update"},
},
}
for i, tt := range tests {
require.Equal(t, tt.expected, FilterArguments(tt.args, app.Model()), fmt.Sprintf("test case %v", i))
}
}
// TestFormatCertError tests the formatCertError function for various x509 error types and messages.
func TestFormatCertError(t *testing.T) {
t.Run("UnknownAuthorityError", func(t *testing.T) {
err := x509.UnknownAuthorityError{}
msg := formatCertError(err)
require.Contains(t, msg, "The proxy you are connecting to has presented a certificate signed by a")
})
t.Run("HostnameErrorConnectingToAuth", func(t *testing.T) {
cert := &x509.Certificate{Raw: []byte("dummy")}
err := x509.HostnameError{Certificate: cert, Host: "99999999999999999999999999999999.teleport.cluster.local"}
msg := formatCertError(err)
require.Contains(t, msg, "Cannot connect to the Auth service via the Teleport Proxy.")
require.Contains(t, msg, "Host: 99999999999999999999999999999999.teleport.cluster.local")
})
t.Run("HostnameError", func(t *testing.T) {
cert := &x509.Certificate{Raw: []byte("dummy")}
err := x509.HostnameError{Certificate: cert, Host: "example.com"}
msg := formatCertError(err)
require.Contains(t, msg, "Cannot establish https connection to example.com")
})
t.Run("CertificateInvalidError", func(t *testing.T) {
err := x509.CertificateInvalidError{Reason: x509.Expired, Cert: &x509.Certificate{}}
msg := formatCertError(err)
require.Contains(t, msg, "The certificate presented by the proxy is invalid")
})
t.Run("CertificateNotTrustedError", func(t *testing.T) {
err := errors.New("certificate is not trusted")
msg := formatCertError(err)
require.Contains(t, msg, "The proxy you are connecting to has presented a certificate signed by")
})
t.Run("NoMatch", func(t *testing.T) {
err := errors.New("some other error")
msg := formatCertError(err)
require.Empty(t, msg)
})
}