Dan UptonandZac Bergquist 7b3a563c93 Allow machineid.AutoUpdateVersionReporter to shut down correctly (#60219) ...

* Allow `machineid.AutoUpdateVersionReporter` to shut down correctly

Fixes an issue where, because we were starting the leader election routine
inside `auth.NewServer`, nothing was waiting for it to shut down correctly,
and we were failing to release the semaphore.

There wasn't a huge user-facing impact (as the semaphore lease would eventually
expire) but it leads to a confusing error message in the logs and delays things
unnecessarily.

* Use `Clock.Since` instead of manually subtracting time

Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>

---------

Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>

2025-10-14 15:35:16 +00:00

..

accessmonitoringrules/accessmonitoringrulesv1

Modernize lib/auth and lib/utils (#55976)

2025-06-22 10:53:52 +00:00

accesspoint

Refactor WebToken interface (#59902)

2025-10-03 15:35:22 +00:00

authclient

[api] Add ListSnowflakeSessions (#59591)

2025-10-14 10:37:05 +00:00

authtest

Refactor WebToken interface (#59902)

2025-10-03 15:35:22 +00:00

autoupdate/autoupdatev1

MWI: Add /webapi/.../machine-id/bot-instance/metrics endpoint (#59896)

2025-10-08 09:47:34 +00:00

clusterconfig/clusterconfigv1

Add missing handling for recording encryption configs and keys (#57279)

2025-08-13 15:14:20 +00:00

crownjewel

Bump golangci-lint to v2 (#54410)

2025-05-07 22:14:51 +00:00

dbobject/dbobjectv1

Modernize lib/auth and lib/utils (#55976)

2025-06-22 10:53:52 +00:00

dbobjectimportrule/dbobjectimportrulev1

Modernize lib/auth and lib/utils (#55976)

2025-06-22 10:53:52 +00:00

discoveryconfig/discoveryconfigv1

Modernize lib/auth and lib/utils (#55976)

2025-06-22 10:53:52 +00:00

dynamicwindows/dynamicwindowsv1

Update several admin actions to allow reusable MFA challenges (#49095)

2024-11-19 18:56:32 +00:00

gitserver/gitserverv1

GitHub proxy part 5: OAuth flow to retrieve GitHub identity (#49849)

2024-12-10 17:31:32 +00:00

healthcheckconfig/healthcheckconfigv1

Introduce logtest package (#56741)

2025-07-15 18:11:10 +00:00

integration

Disable EC2 access using EICE method (#60016)

2025-10-10 09:22:21 +00:00

join

MWI: Static keys and environment loading for bound keypair joining params (#59620)

2025-10-03 02:27:37 +00:00

keygen

feat: initial new join service backend (#58520)

2025-09-18 18:38:07 +00:00

keystore

using more reliable method of validating key bit length (#58635)

2025-09-03 01:55:50 +00:00

kubewaitingcontainer/kubewaitingcontainerv1

Modernize lib/auth and lib/utils (#55976)

2025-06-22 10:53:52 +00:00

loginrule/loginrulev1

Unify naming and location of auth RPC services (#46559)

2024-09-12 22:34:58 +00:00

machineid

Allow machineid.AutoUpdateVersionReporter to shut down correctly (#60219)

2025-10-14 15:35:16 +00:00

mfatypes

Use json compatible struct for SSOMFASessionData (#47826)

2024-10-31 19:59:53 +00:00

migration

Introduce logtest package (#56741)

2025-07-15 18:11:10 +00:00

mocku2f

Modernize lib/auth and lib/utils (#55976)

2025-06-22 10:53:52 +00:00

moderation

feat: expand Session recording RBAC support (#58114)

2025-08-29 19:17:50 +00:00

notifications/notificationsv1

remove RoleAdmin requirement for notification commands (#57895)

2025-08-19 17:19:30 +00:00

okta

Okta: Don't allow creating user_group Access Request in RO (#55420)

2025-06-10 11:09:04 +00:00

presence/presencev1

Migrate all tests to use lib/auth/authtest helpers (#57030)

2025-07-24 18:27:14 +00:00

recordingencryption

adding rotation process to Manager and exposing with new RPCs and (#57577)

2025-08-26 21:06:16 +00:00

recordingmetadata

Add the new session recording player component (#58586)

2025-09-09 15:37:03 +00:00

scopes

high level scoped role/assignment cache, api, and commands (#56331)

2025-07-11 17:29:12 +00:00

secreports/secreportsv1

Register unimplemented secreportsv1 RPC service in OSS builds (#55056)

2025-05-22 16:30:33 +00:00

stableunixusers

Introduce logtest package (#56741)

2025-07-15 18:11:10 +00:00

state

Reduce the number of custom set implementations (#57480)

2025-08-10 22:10:17 +00:00

storage

remove most remaining Process.Config.HostUUID refs (#57876)

2025-08-29 18:32:36 +00:00

summarizer

Expose a flag that tells if session summarizer is enabled (#57992)

2025-08-20 17:04:12 +00:00

testauthority

Add host fields and protos for ssh identities (#51024)

2025-01-27 18:51:37 +00:00

touchid

Modernize lib/auth and lib/utils (#55976)

2025-06-22 10:53:52 +00:00

trust/trustv1

core scope pinning logic (#58377)

2025-10-01 20:30:50 +00:00

userloginstate

Fix inherited AccessList ownership permissions (#60036)

2025-10-08 16:51:23 +00:00

userpreferences/userpreferencesv1

Convert auth rpc services to use slog (#50513)

2024-12-20 20:28:23 +00:00

userprovisioning/userprovisioningv2

feat: expand Session recording RBAC support (#58114)

2025-08-29 19:17:50 +00:00

users/usersv1

enforce max username size for creating new users and matching connectors (#57638)

2025-09-18 16:29:47 +00:00

usertasks/usertasksv1

WebAPI: Add state as filter for UserTasks listing endpoint (#52191)

2025-02-20 09:24:06 +00:00

vnetconfig/vnetconfigv1

Update several admin actions to allow reusable MFA challenges (#49095)

2024-11-19 18:56:32 +00:00

webauthn

Modernize lib/auth and lib/utils (#55976)

2025-06-22 10:53:52 +00:00

webauthncli

Bump golangci-lint to v2 (#54410)

2025-05-07 22:14:51 +00:00

webauthntypes

Modernize lib/auth and lib/utils (#55976)

2025-06-22 10:53:52 +00:00

webauthnwin

Pin tool versions using Go tool deps (#59540)

2025-09-24 19:18:56 +00:00

access_request_test.go

Refactor auth test helpers (#56491)

2025-07-21 17:32:26 +00:00

access_test.go

Refactor auth test helpers (#56491)

2025-07-21 17:32:26 +00:00

access.go

Replace more Logrus usage with Slog (#46757)

2024-09-19 18:37:51 +00:00

accountrecovery_test.go

Refactor auth test helpers (#56491)

2025-07-21 17:32:26 +00:00

accountrecovery.go

Modernize lib/auth and lib/utils (#55976)

2025-06-22 10:53:52 +00:00

apiserver_test.go

Refactor auth test helpers (#56491)

2025-07-21 17:32:26 +00:00

apiserver.go

core scope pinning logic (#58377)

2025-10-01 20:30:50 +00:00

app_access_aws_credentials.go

Fix AWS CLI access using AWS OIDC integration (#57843)

2025-08-15 00:04:24 +00:00

auth_login_test.go

core scope pinning logic (#58377)

2025-10-01 20:30:50 +00:00

auth_test.go

Respect WebIdleTimeout in bearerTokenTTL (#59645)

2025-10-09 21:50:41 +00:00

auth_with_roles_okta_rbac_test.go

Refactor auth test helpers (#56491)

2025-07-21 17:32:26 +00:00

auth_with_roles_test.go

[api] Add ListSnowflakeSessions (#59591)

2025-10-14 10:37:05 +00:00

auth_with_roles.go

[api] Add ListSnowflakeSessions (#59591)

2025-10-14 10:37:05 +00:00

auth.go

Allow machineid.AutoUpdateVersionReporter to shut down correctly (#60219)

2025-10-14 15:35:16 +00:00

autoupdate_agent_version_report_test.go

Introduce logtest package (#56741)

2025-07-15 18:11:10 +00:00

autoupdate_agent_version_report.go

autoupdate canary support: inventory and auth primitives (#56261)

2025-07-03 19:36:35 +00:00

autoupdate_rollout_test.go

Fix autoupdate canary sampling for the catch-all group (#57035)

2025-07-22 16:36:39 +00:00

autoupdate_rollout.go

Fix autoupdate canary sampling for the catch-all group (#57035)

2025-07-22 16:36:39 +00:00

aws_certs.go

Extend EC2 joining method to other AWS regions (#39045)

2024-03-07 09:40:31 +00:00

azure_certs_test.go

Refactor auth test helpers (#56491)

2025-07-21 17:32:26 +00:00

azure_certs.go

…

bot_test.go

Condolidate fake IDP libraries (#58987)

2025-09-11 18:06:58 +00:00

bot.go

core scope pinning logic (#58377)

2025-10-01 20:30:50 +00:00

bound_keypair_tokens.go

feat: bound keypair support in new join service (#58963)

2025-10-01 19:48:51 +00:00

client_tls_config_generator.go

verify cluster name of TLS peer certificates (#52128)

2025-02-13 21:25:52 +00:00

db_test.go

winpki: prevent CRL common names from overflowing (#57867)

2025-08-14 15:52:55 +00:00

db.go

Support HSM for Windows Desktop and database AD access (#55429)

2025-07-17 19:41:30 +00:00

desktop_test.go

Refactor auth test helpers (#56491)

2025-07-21 17:32:26 +00:00

desktop.go

Fix CRLs in the backend (#57822)

2025-08-14 00:39:54 +00:00

export_test.go

core scope pinning logic (#58377)

2025-10-01 20:30:50 +00:00

externalauditstorage.go

Fix EAS Token generation (#40154)

2024-04-05 13:06:03 +00:00

fuzz_test.go

…

github_test.go

MWI: Generate AutoUpdateBotInstanceReport resource (#59738)

2025-10-07 14:32:36 +00:00

github.go

Add support for using the relay in tsh and Machine ID (#59095)

2025-09-17 10:14:04 +00:00

grpcserver_test.go

Refactor test assertions to use consistent variable naming in require.EventuallyWithT calls (#58997)

2025-09-15 15:19:53 +00:00

grpcserver.go

[api] Add ListSnowflakeSessions (#59591)

2025-10-14 10:37:05 +00:00

init_test.go

Stop using the sqlite backend in tests (#60153)

2025-10-10 20:13:25 +00:00

init.go

[mcp] add a preset mcp-access role (#58243)

2025-09-02 13:29:33 +00:00

join_azure_devops_test.go

Refactor auth test helpers (#56491)

2025-07-21 17:32:26 +00:00

join_azure_devops.go

Azure DevOps join implementation (#54729)

2025-05-15 08:19:35 +00:00

join_azure_test.go

Support azure joining with VMSS (#58015)

2025-08-19 23:31:46 +00:00

join_azure.go

feat: initial new join service backend (#58520)

2025-09-18 18:38:07 +00:00

join_bitbucket_test.go

Refactor auth test helpers (#56491)

2025-07-21 17:32:26 +00:00

join_bitbucket.go

Refactor RegisterUsingToken for perf and better audit log on failure (#54745)

2025-05-13 12:51:13 +00:00

join_bound_keypair_adapter.go

feat: bound keypair support in new join service (#58963)

2025-10-01 19:48:51 +00:00

join_bound_keypair_test.go

port bound keypair tests to new join service (#59512)

2025-10-08 18:42:52 +00:00

join_circleci_test.go

Refactor auth test helpers (#56491)

2025-07-21 17:32:26 +00:00

join_circleci.go

Refactor RegisterUsingToken for perf and better audit log on failure (#54745)

2025-05-13 12:51:13 +00:00

join_ec2_test.go

Refactor auth test helpers (#56491)

2025-07-21 17:32:26 +00:00

join_ec2.go

Move ec2.go from lib/utils to lib/utils/aws (#59837)

2025-10-02 16:50:24 +00:00

join_gcp_test.go

Refactor auth test helpers (#56491)

2025-07-21 17:32:26 +00:00

join_gcp.go

Refactor RegisterUsingToken for perf and better audit log on failure (#54745)

2025-05-13 12:51:13 +00:00

join_github_test.go

Refactor auth test helpers (#56491)

2025-07-21 17:32:26 +00:00

join_github.go

Refactor RegisterUsingToken for perf and better audit log on failure (#54745)

2025-05-13 12:51:13 +00:00

join_gitlab_test.go

Refactor auth test helpers (#56491)

2025-07-21 17:32:26 +00:00

join_gitlab.go

Refactor RegisterUsingToken for perf and better audit log on failure (#54745)

2025-05-13 12:51:13 +00:00

join_iam_test.go

Refactor auth test helpers (#56491)

2025-07-21 17:32:26 +00:00

join_iam.go

feat: initial new join service backend (#58520)

2025-09-18 18:38:07 +00:00

join_kubernetes_test.go

Refactor auth test helpers (#56491)

2025-07-21 17:32:26 +00:00

join_kubernetes.go

Add a caching OIDC validator for use with Kubernetes OIDC (#57862)

2025-09-25 02:01:40 +00:00

join_oracle_test.go

Refactor auth test helpers (#56491)

2025-07-21 17:32:26 +00:00

join_oracle.go

feat: initial new join service backend (#58520)

2025-09-18 18:38:07 +00:00

join_spacelift_test.go

Refactor auth test helpers (#56491)

2025-07-21 17:32:26 +00:00

join_spacelift.go

MWI: Support globby style matching in Spacelift join rules (#56836)

2025-07-17 09:15:46 +00:00

join_terraformcloud_test.go

Refactor auth test helpers (#56491)

2025-07-21 17:32:26 +00:00

join_terraformcloud.go

Refactor RegisterUsingToken for perf and better audit log on failure (#54745)

2025-05-13 12:51:13 +00:00

join_test.go

Refactor auth test helpers (#56491)

2025-07-21 17:32:26 +00:00

join_tpm_test.go

Refactor auth test helpers (#56491)

2025-07-21 17:32:26 +00:00

join_tpm.go

feat: initial new join service backend (#58520)

2025-09-18 18:38:07 +00:00

join.go

feat: initial new join service backend (#58520)

2025-09-18 18:38:07 +00:00

methods_test.go

Refactor auth test helpers (#56491)

2025-07-21 17:32:26 +00:00

methods.go

core scope pinning logic (#58377)

2025-10-01 20:30:50 +00:00

middleware_test.go

Refactor auth test helpers (#56491)

2025-07-21 17:32:26 +00:00

middleware.go

Prevent leaking the auth TLSServer (#56388)

2025-07-02 23:52:51 +00:00

moderated_sessions_test.go

Refactor auth test helpers (#56491)

2025-07-21 17:32:26 +00:00

notification_test.go

Rewrite notifications tests (#59414)

2025-09-26 21:18:09 +00:00

oidc.go

Convert lib/auth to use slog (#50577)

2025-01-06 21:31:53 +00:00

password_test.go

MWI: Generate AutoUpdateBotInstanceReport resource (#59738)

2025-10-07 14:32:36 +00:00

password.go

Fix violations of non-constant format strings linter (#51812)

2025-02-04 16:43:35 +00:00

periodic_test.go

Add OS label for registered servers metric (#59520)

2025-09-26 16:48:11 +00:00

periodic.go

Add OS label for registered servers metric (#59520)

2025-09-26 16:48:11 +00:00

recording_authorizer_test.go

Implement the session recording metadata service (#58031)

2025-08-19 16:32:19 +00:00

recording_authorizer.go

Implement the session recording metadata service (#58031)

2025-08-19 16:32:19 +00:00

register.go

chore: update IAM join method to use aws-sdk-go-v2 (#47044)

2024-10-02 00:58:00 +00:00

requestable_roles_test.go

implement paginated requestable roles listing (#56695)

2025-08-12 21:09:04 +00:00

rotate.go

Migrate GetClusterName to gRPC (#53164)

2025-03-20 10:07:02 +00:00

saml.go

Convert lib/auth to use slog (#50577)

2025-01-06 21:31:53 +00:00

server_info_test.go

Reduce testing symbols in production binaries (#55360)

2025-06-09 16:51:12 +00:00

server_info.go

Change the inventory to use modern protobuf types and codegen (#54977)

2025-05-23 07:47:39 +00:00

server_monitor.go

Change the inventory to use modern protobuf types and codegen (#54977)

2025-05-23 07:47:39 +00:00

sessions_test.go

Respect WebIdleTimeout in bearerTokenTTL (#59645)

2025-10-09 21:50:41 +00:00

sessions.go

Respect WebIdleTimeout in bearerTokenTTL (#59645)

2025-10-09 21:50:41 +00:00

sso_diag_context_test.go

…

sso_diag_context.go

Convert lib/auth to use slog (#50577)

2025-01-06 21:31:53 +00:00

sso_mfa_test.go

Refactor auth test helpers (#56491)

2025-07-21 17:32:26 +00:00

sso_mfa.go

add pkce code verifier (#53975)

2025-05-14 21:18:21 +00:00

tls_test.go

Refactor test assertions to use consistent variable naming in require.EventuallyWithT calls (#58997)

2025-09-15 15:19:53 +00:00

transport_credentials_test.go

Refactor test assertions to use consistent variable naming in require.EventuallyWithT calls (#58997)

2025-09-15 15:19:53 +00:00

transport_credentials.go

Refactor auth.Middleware to reduce dependencies on lib/auth (#55577)

2025-06-16 13:24:40 +00:00

trustedcluster_test.go

MWI: Generate AutoUpdateBotInstanceReport resource (#59738)

2025-10-07 14:32:36 +00:00

trustedcluster.go

improve trusted cluster updates (#58008)

2025-09-05 21:39:15 +00:00

usage_test.go

Refactor auth test helpers (#56491)

2025-07-21 17:32:26 +00:00

user.go

Convert lib/auth to use slog (#50577)

2025-01-06 21:31:53 +00:00

usertoken_test.go

Introduce 'ListResetPasswordTokens' RPC (#57665)

2025-08-08 05:26:25 +00:00

usertoken.go

Introduce 'ListResetPasswordTokens' RPC (#57665)

2025-08-08 05:26:25 +00:00

version.go

Changed error message for major version downgrade (#54767)

2025-05-13 19:57:58 +00:00

windows-configure-ad.ps1

Refactor lib/auth/windows package (#54963)

2025-05-23 23:21:20 +00:00