mirror of
https://github.com/gravitational/teleport.git
synced 2026-11-01 05:27:24 +08:00
Jakub Nyckowski
7ccf2f219a
When a client sends an SSH session before the shell process ends, Teleport sends the SIGKILL signal to the subprocess. This causes the still-leaving shell to be resigned to PID 1 and live forever. This PR tried to stop the terminal first before killing the subprocess to prevent the terminal from living forever. Closes #13335 Closes #6245 Closes #4469
134 lines
2.9 KiB
Go
134 lines
2.9 KiB
Go
/*
|
|
Copyright 2019 Gravitational, Inc.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package srv
|
|
|
|
import (
|
|
"context"
|
|
"os"
|
|
"os/exec"
|
|
"os/user"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/gravitational/trace"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestGetOwner(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
tests := []struct {
|
|
inUserLookup LookupUser
|
|
inGroupLookup LookupGroup
|
|
outUID int
|
|
outGID int
|
|
outMode os.FileMode
|
|
}{
|
|
// Group "tty" exists.
|
|
{
|
|
inUserLookup: func(s string) (*user.User, error) {
|
|
return &user.User{
|
|
Uid: "1000",
|
|
Gid: "1000",
|
|
}, nil
|
|
},
|
|
inGroupLookup: func(s string) (*user.Group, error) {
|
|
return &user.Group{
|
|
Gid: "5",
|
|
}, nil
|
|
},
|
|
outUID: 1000,
|
|
outGID: 5,
|
|
outMode: 0600,
|
|
},
|
|
// Group "tty" does not exist.
|
|
{
|
|
inUserLookup: func(s string) (*user.User, error) {
|
|
return &user.User{
|
|
Uid: "1000",
|
|
Gid: "1000",
|
|
}, nil
|
|
},
|
|
inGroupLookup: func(s string) (*user.Group, error) {
|
|
return &user.Group{}, trace.BadParameter("")
|
|
},
|
|
outUID: 1000,
|
|
outGID: 1000,
|
|
outMode: 0620,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
uid, gid, mode, err := getOwner("", tt.inUserLookup, tt.inGroupLookup)
|
|
require.NoError(t, err)
|
|
|
|
require.Equal(t, tt.outUID, uid)
|
|
require.Equal(t, tt.outGID, gid)
|
|
require.Equal(t, tt.outMode, mode)
|
|
}
|
|
}
|
|
|
|
func TestTerminal_KillUnderlyingShell(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
srv := newMockServer(t)
|
|
scx := newTestServerContext(t, srv, nil)
|
|
|
|
lsPath, err := exec.LookPath("sh")
|
|
require.NoError(t, err)
|
|
scx.execRequest.SetCommand(lsPath)
|
|
|
|
term, err := newLocalTerminal(scx)
|
|
require.NoError(t, err)
|
|
|
|
term.SetTermType("xterm")
|
|
|
|
ctx := context.Background()
|
|
|
|
// Run sh
|
|
err = term.Run(ctx)
|
|
require.NoError(t, err)
|
|
|
|
errors := make(chan error)
|
|
go func() {
|
|
// Call wait to avoid creating zombie process.
|
|
// Ignore exit code as we're checking term.cmd.ProcessState already
|
|
_, err := term.Wait()
|
|
|
|
errors <- err
|
|
}()
|
|
|
|
// Continue execution
|
|
err = scx.contw.Close()
|
|
require.NoError(t, err)
|
|
|
|
ctx, cancel := context.WithTimeout(ctx, 5*time.Second)
|
|
t.Cleanup(cancel)
|
|
|
|
err = term.KillUnderlyingShell(ctx)
|
|
require.NoError(t, err)
|
|
|
|
// Wait for the process to return.
|
|
require.NoError(t, <-errors)
|
|
|
|
// ProcessState should be not nil after the process exits.
|
|
require.NotNil(t, term.cmd.ProcessState)
|
|
require.NotZero(t, term.cmd.ProcessState.Pid())
|
|
// 255 is returned on subprocess kill.
|
|
require.Equal(t, 255, term.cmd.ProcessState.ExitCode())
|
|
}
|