mirror of
https://github.com/gravitational/teleport.git
synced 2026-11-02 14:27:33 +08:00
rosstimothy
3cca37fff6
* Fix web ssh session with proxy recording mode The agent was not being propagated when establishing an ssh session via the web which resulted in the error described in #18850. Providing the agent was straightforward, however, due to the changes from #18656 when using the forward server, as is required with proxy recording mode, the ssh connection is now being performed directly over a `net.Pipe`. Due to the synchronous nature of `net.Pipe` this causes a deadlock when performing the ssh handshake. To mitigate the deadlocks, `DualPipeNetConn` was changed to leverage `syscall.Socketpair` instead of `net.Pipe`. `TestTerminal` now has two cases, one for node recording mode and another for proxy recording mode. In order for the proxy recording mode test to pass the fake clock used in the test needed to be properly propagated to the `ssh.CertChecker` and `forward.ServerConfig`. Fixes #18850
94 lines
2.7 KiB
Go
94 lines
2.7 KiB
Go
/*
|
|
Copyright 2021 Gravitational, Inc.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package sshutils
|
|
|
|
import (
|
|
"github.com/gravitational/trace"
|
|
"github.com/jonboulle/clockwork"
|
|
"github.com/sirupsen/logrus"
|
|
"golang.org/x/crypto/ssh"
|
|
)
|
|
|
|
// CheckersGetter defines a function that returns a list of ssh public keys.
|
|
type CheckersGetter func() ([]ssh.PublicKey, error)
|
|
|
|
// HostKeyCallbackConfig is the host key callback configuration.
|
|
type HostKeyCallbackConfig struct {
|
|
// GetHostCheckers is used to fetch host checking (public) keys.
|
|
GetHostCheckers CheckersGetter
|
|
// HostKeyFallback sets optional callback to check non-certificate keys.
|
|
HostKeyFallback ssh.HostKeyCallback
|
|
// FIPS allows to set FIPS mode which will validate algorithms.
|
|
FIPS bool
|
|
// OnCheckCert is called on SSH certificate validation.
|
|
OnCheckCert func(*ssh.Certificate)
|
|
// Clock is used to set the Checker Time
|
|
Clock clockwork.Clock
|
|
}
|
|
|
|
// Check validates the config.
|
|
func (c *HostKeyCallbackConfig) Check() error {
|
|
if c.GetHostCheckers == nil {
|
|
return trace.BadParameter("missing GetHostCheckers")
|
|
}
|
|
if c.Clock == nil {
|
|
c.Clock = clockwork.NewRealClock()
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// NewHostKeyCallback returns host key callback function with the specified parameters.
|
|
func NewHostKeyCallback(conf HostKeyCallbackConfig) (ssh.HostKeyCallback, error) {
|
|
if err := conf.Check(); err != nil {
|
|
return nil, trace.Wrap(err)
|
|
}
|
|
checker := CertChecker{
|
|
CertChecker: ssh.CertChecker{
|
|
IsHostAuthority: makeIsHostAuthorityFunc(conf.GetHostCheckers),
|
|
HostKeyFallback: conf.HostKeyFallback,
|
|
Clock: conf.Clock.Now,
|
|
},
|
|
FIPS: conf.FIPS,
|
|
OnCheckCert: conf.OnCheckCert,
|
|
}
|
|
return checker.CheckHostKey, nil
|
|
}
|
|
|
|
func makeIsHostAuthorityFunc(getCheckers CheckersGetter) func(key ssh.PublicKey, host string) bool {
|
|
return func(key ssh.PublicKey, host string) bool {
|
|
checkers, err := getCheckers()
|
|
if err != nil {
|
|
logrus.WithError(err).Errorf("Failed to get checkers for %v.", host)
|
|
return false
|
|
}
|
|
for _, checker := range checkers {
|
|
switch v := key.(type) {
|
|
case *ssh.Certificate:
|
|
if KeysEqual(v.SignatureKey, checker) {
|
|
return true
|
|
}
|
|
default:
|
|
if KeysEqual(key, checker) {
|
|
return true
|
|
}
|
|
}
|
|
}
|
|
logrus.Debugf("No CA for host %v.", host)
|
|
return false
|
|
}
|
|
}
|