Gavin Frazar 3f0ef9f0ed improve aws utils and database validation (#23157) ...

* log a warning when an invalid AWS IAM role ARN is filtered out
* add tests for nested role arn path and remove superfluous test parallelism
* add extra godoc info for BuildRoleARN
* improve mock IAM error messages
  - Failing tests' error messages were not specific enough to know what
    happened.
* refactor code to call GetAWS() once
  - Avoids constantly fetching a full copy of the AWS metadata.
  - Reduces verbosity of code.
* reuse MetadataFromRedshiftCluster in meta fetcher
  - Avoids repeating the same logic inside the fetcher.
* improve database-access DynamoDB config checking
  - Don't early return from database CheckAndSetDefaults so AWS account ID
    is checked properly, and any other future checks added will apply to
    DynamoDB as well.
* add aws utils for parsing AWS IAM roles
  - ParseRoleARN will parse an AWS ARN and verify that it is a valid
    AWS IAM Role resource
  - CheckARNPartitionAndAccount is a helper that verifies an ARN partition
    and account ID matches the caller's expectations.
* use cmp.Diff instead of require.Equal in db tests
  - require.Equal spams a lot of protobuf noise.
  - cmp.Diff yields a precise, readable diff on test failure.

2023-03-17 00:45:25 +00:00

..

aws_test.go

improve aws utils and database validation (#23157)

2023-03-17 00:45:25 +00:00

aws.go

improve aws utils and database validation (#23157)

2023-03-17 00:45:25 +00:00

signing.go

improve aws utils and database validation (#23157)

2023-03-17 00:45:25 +00:00

xml_test.go

Support assumed roles for "tsh proxy aws" (#20568)

2023-01-30 21:21:43 +00:00

xml.go

Support assumed roles for "tsh proxy aws" (#20568)

2023-01-30 21:21:43 +00:00